New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 618642 link

Starred by 1 user
Status: Fixed
Merged: issue 624789
Owner:
senorblanco@chromium.org
Closed: Aug 2016
Cc:
nyerramilli@chromium.org
█ tkonch...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Solar system is not seen in 'Solar System' demo

Reported by lpa...@etouch.net, Jun 9 2016 
Chrome Version: 53.0.2763.0 (Official Build) dd933bda0baa6a13ab0120f0056a2b783e459efb-refs/heads/master@{#398752} 32/64 bit
OS: Windows(7,8,10), Linux (14.04 LTS), Mac(10.10.5, 10.11.4)
URL: https://chrome.google.com/webstore/detail/color-enhancer/ipkjmjaledkapilfdigkgfmpekpfnkih

Steps:
1. Launch chrome, navigate to above url and add the extention.
2. Navigate to http://solarsystemdemo.com/ and observe the demo.

Actual: Solar system is not seen.

Expected: Solar system should be visible.

This is a regression issue broken in M-48.

Good Build: 48.0.2549.0
Bad Build: 48.0.2550.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/870f3e99a1282023753fe8d8aed90879cbc6838f..f6206288763f3192e9481e6df6c6384e98fcaa83?pretty=fuller&n=100

Suspecting: r356693 ?

Please re-assign if your change is not the cause of this issue.
Actual.png
316 KB View Download
Expected.png
942 KB View Download
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 6 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by senorblanco@chromium.org, Aug 8 2016

Mergedinto: 624789
Status: Duplicate (was: Assigned)
I strongly suspect this is a dupe of 624789.

Comment 3 by senorblanco@chromium.org, Aug 11 2016

Status: Assigned (was: Duplicate)
On second thought, I'm unduping, since I can repro this one, but I can't repro 624789.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/711409eabeacb27e2debfd5a7be631a1967f500f

commit 711409eabeacb27e2debfd5a7be631a1967f500f
Author: senorblanco <senorblanco@chromium.org>
Date: Thu Aug 11 22:47:39 2016

CSS filters: fix filtered parent with composited, transformed child.

When computing the filter region for CSS filters, we must take
composited, transformed children into account. This required
plumbing this preference through
PaintLayer::physicalBoundingBoxIncludingReflectionAndStackingChildren().

This is a followup to https://codereview.chromium.org/1459953002/,
which fixed the problem for non-composited children.

BUG= 620394 , 618642 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2230593002
Cr-Commit-Position: refs/heads/master@{#411432}

[add] https://crrev.com/711409eabeacb27e2debfd5a7be631a1967f500f/third_party/WebKit/LayoutTests/css3/filters/filter-region-transformed-composited-child-expected.html
[add] https://crrev.com/711409eabeacb27e2debfd5a7be631a1967f500f/third_party/WebKit/LayoutTests/css3/filters/filter-region-transformed-composited-child.html
[modify] https://crrev.com/711409eabeacb27e2debfd5a7be631a1967f500f/third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp
[modify] https://crrev.com/711409eabeacb27e2debfd5a7be631a1967f500f/third_party/WebKit/Source/core/paint/PaintLayer.cpp
[modify] https://crrev.com/711409eabeacb27e2debfd5a7be631a1967f500f/third_party/WebKit/Source/core/paint/PaintLayer.h

Comment 5 by senorblanco@chromium.org, Aug 12 2016

Status: Fixed (was: Assigned)

Comment 6 by ssamanoori@chromium.org, Aug 16 2016

Labels: TE-Verified-54.0.2830.0 TE-Verified-M54
Tested the issue on Windows 7, Mac 10.11.6, Ubuntu 14.04 using 54.0.2830.0.Solar system is visible.
Please find attached screencast.

Marking it as TE-Verified.
618642.mp4
1.2 MB View Download
►

Sign in to add a comment