New issue
Advanced search Search tips

Issue 618638 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

some svg layout tests needs another rebaseline

Project Member Reported by xidac...@chromium.org, Jun 9 2016

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/773ae64e0c2a3bf3f32731f882fb2ef699e8361d

commit 773ae64e0c2a3bf3f32731f882fb2ef699e8361d
Author: xidachen <xidachen@chromium.org>
Date: Thu Jun 09 11:29:35 2016

Another rebaseline for some SVG layout tests

Just on Win and Mac

BUG= 618638 
NOTRY=true
TBR=wangxianzhu@chromium.org

Review-Url: https://codereview.chromium.org/2057503002
Cr-Commit-Position: refs/heads/master@{#398841}

[modify] https://crrev.com/773ae64e0c2a3bf3f32731f882fb2ef699e8361d/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6663114a287ed1b56b21b2988ea3fabacd01aa60

commit 6663114a287ed1b56b21b2988ea3fabacd01aa60
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Thu Jun 09 13:22:45 2016

Auto-rebaseline for r398841

https://chromium.googlesource.com/chromium/src/+/773ae64e0

BUG= 618638 
TBR=xidachen@chromium.org

Review URL: https://codereview.chromium.org/2046123005 .

Cr-Commit-Position: refs/heads/master@{#398858}

[modify] https://crrev.com/6663114a287ed1b56b21b2988ea3fabacd01aa60/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/relative-sized-image-expected.png
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/mac-retina/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/mac-retina/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.txt
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/mac-retina/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/mac-retina/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.txt
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/mac-retina/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/mac-retina/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.txt
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/mac-retina/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/mac-retina/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.txt
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/mac-retina/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/mac-retina/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.txt
[modify] https://crrev.com/6663114a287ed1b56b21b2988ea3fabacd01aa60/third_party/WebKit/LayoutTests/platform/win/svg/custom/relative-sized-image-expected.png
[rename] https://crrev.com/6663114a287ed1b56b21b2988ea3fabacd01aa60/third_party/WebKit/LayoutTests/platform/win/svg/custom/relative-sized-image-expected.txt
[modify] https://crrev.com/6663114a287ed1b56b21b2988ea3fabacd01aa60/third_party/WebKit/LayoutTests/platform/win7/svg/custom/relative-sized-image-expected.png
[add] https://crrev.com/6663114a287ed1b56b21b2988ea3fabacd01aa60/third_party/WebKit/LayoutTests/platform/win7/svg/custom/relative-sized-image-expected.txt
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/win7/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/win7/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/win7/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/win7/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/win7/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png

apparently this: svg/custom/relative-sized-image.xhtml test needs to rebaseline again on win10

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/11139
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3095dfc612b58cc32dea3011e313d041372d1186

commit 3095dfc612b58cc32dea3011e313d041372d1186
Author: xidachen <xidachen@chromium.org>
Date: Thu Jun 09 14:46:29 2016

Rebaseline svg/custom/relative-sized-image.xhtml again

It is still failing on Win10 after first rebaseline here
https://codereview.chromium.org/2046123005

BUG= 618638 
NOTRY=true
TBR=wangxianzhu@chromium.org

Review-Url: https://codereview.chromium.org/2050253002
Cr-Commit-Position: refs/heads/master@{#398877}

[modify] https://crrev.com/3095dfc612b58cc32dea3011e313d041372d1186/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c30f46be5118eab322dfc14df77e3af096f0cce9

commit c30f46be5118eab322dfc14df77e3af096f0cce9
Author: xidachen <xidachen@chromium.org>
Date: Thu Jun 09 18:53:15 2016

Rebaseline svg/custom/relative-sized-image.xhtml one more time

It still fails on win10:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/11147

BUG= 618638 
NOTRY=true
TBR=wangxianzhu@chromium.org

Review-Url: https://codereview.chromium.org/2050203004
Cr-Commit-Position: refs/heads/master@{#398970}

[modify] https://crrev.com/c30f46be5118eab322dfc14df77e3af096f0cce9/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/773ae64e0c2a3bf3f32731f882fb2ef699e8361d

commit 773ae64e0c2a3bf3f32731f882fb2ef699e8361d
Author: xidachen <xidachen@chromium.org>
Date: Thu Jun 09 11:29:35 2016

Another rebaseline for some SVG layout tests

Just on Win and Mac

BUG= 618638 
NOTRY=true
TBR=wangxianzhu@chromium.org

Review-Url: https://codereview.chromium.org/2057503002
Cr-Commit-Position: refs/heads/master@{#398841}

[modify] https://crrev.com/773ae64e0c2a3bf3f32731f882fb2ef699e8361d/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6663114a287ed1b56b21b2988ea3fabacd01aa60

commit 6663114a287ed1b56b21b2988ea3fabacd01aa60
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Thu Jun 09 13:22:45 2016

Auto-rebaseline for r398841

https://chromium.googlesource.com/chromium/src/+/773ae64e0

BUG= 618638 
TBR=xidachen@chromium.org

Review URL: https://codereview.chromium.org/2046123005 .

Cr-Commit-Position: refs/heads/master@{#398858}

[modify] https://crrev.com/6663114a287ed1b56b21b2988ea3fabacd01aa60/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/mac-retina/svg/custom/relative-sized-image-expected.png
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/mac-retina/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/mac-retina/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.txt
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/mac-retina/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/mac-retina/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.txt
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/mac-retina/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/mac-retina/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.txt
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/mac-retina/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/mac-retina/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.txt
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/mac-retina/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/mac-retina/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.txt
[modify] https://crrev.com/6663114a287ed1b56b21b2988ea3fabacd01aa60/third_party/WebKit/LayoutTests/platform/win/svg/custom/relative-sized-image-expected.png
[rename] https://crrev.com/6663114a287ed1b56b21b2988ea3fabacd01aa60/third_party/WebKit/LayoutTests/platform/win/svg/custom/relative-sized-image-expected.txt
[modify] https://crrev.com/6663114a287ed1b56b21b2988ea3fabacd01aa60/third_party/WebKit/LayoutTests/platform/win7/svg/custom/relative-sized-image-expected.png
[add] https://crrev.com/6663114a287ed1b56b21b2988ea3fabacd01aa60/third_party/WebKit/LayoutTests/platform/win7/svg/custom/relative-sized-image-expected.txt
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/win7/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/win7/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/win7/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/win7/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png
[delete] https://crrev.com/3ae34f35b4618849690e871d76b0b1461ba08378/third_party/WebKit/LayoutTests/platform/win7/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3095dfc612b58cc32dea3011e313d041372d1186

commit 3095dfc612b58cc32dea3011e313d041372d1186
Author: xidachen <xidachen@chromium.org>
Date: Thu Jun 09 14:46:29 2016

Rebaseline svg/custom/relative-sized-image.xhtml again

It is still failing on Win10 after first rebaseline here
https://codereview.chromium.org/2046123005

BUG= 618638 
NOTRY=true
TBR=wangxianzhu@chromium.org

Review-Url: https://codereview.chromium.org/2050253002
Cr-Commit-Position: refs/heads/master@{#398877}

[modify] https://crrev.com/3095dfc612b58cc32dea3011e313d041372d1186/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 13 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c30f46be5118eab322dfc14df77e3af096f0cce9

commit c30f46be5118eab322dfc14df77e3af096f0cce9
Author: xidachen <xidachen@chromium.org>
Date: Thu Jun 09 18:53:15 2016

Rebaseline svg/custom/relative-sized-image.xhtml one more time

It still fails on win10:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/11147

BUG= 618638 
NOTRY=true
TBR=wangxianzhu@chromium.org

Review-Url: https://codereview.chromium.org/2050203004
Cr-Commit-Position: refs/heads/master@{#398970}

[modify] https://crrev.com/c30f46be5118eab322dfc14df77e3af096f0cce9/third_party/WebKit/LayoutTests/TestExpectations

Sign in to add a comment