New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 618633 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Not on Chrome
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: On chrome://history page 'Close' button of search field is not working after dragging link into it.

Reported by rk...@etouch.net, Jun 9 2016

Issue description

Chrome version : 53.0.2763.0 (Official Build) dd933bda0baa6a13ab0120f0056a2b783e459efb-refs/heads/master@{#398752} 32/64 bit
OS :  Windows (7,8,8.1,10),Linux (14.04 LTS), Mac(10.10.5, 10.11.4)

What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://history
(2) Drag any link in search text field and click on 'Close' button, observe

'Close' button of search field is not working after dragging link into it.

'Close' button of search field should be working after dragging link into search field.

This is a regression issue, broken in 'M-53' , below is bisect info:

Good Build: 53.0.2749.0
Bad Build: 53.0.2750.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/ef7aca16ba536b6e3b4d4ca2c7d60ef547f44267..2f51b95ab526d0bac7b08ed525ec51e27850c119?pretty=fuller&n=50

Suspecting: r396115



 
Actual_History.mp4
647 KB View Download
Expected_History.mp4
441 KB View Download
Labels: ReleaseBlock-Stable
Adding RB label as this is a recent regression.
Labels: -ReleaseBlock-Stable
This feature is behind a flag and should not block release.
Labels: Proj-MaterialDesign-WebUI
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b28158033e882c541f6ff3dc0111b94f59a2ed0

commit 7b28158033e882c541f6ff3dc0111b94f59a2ed0
Author: tsergeant <tsergeant@chromium.org>
Date: Thu Jun 23 02:54:00 2016

MD Search Field: Properly respond to external changes to search value.

Ensures that when the search value is changed by something other than
direct typing the search field will still open correctly. This fixes
issues with dragging or pasting text into the input field.

BUG= 616740 , 618633 , 622074 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2090513002
Cr-Commit-Position: refs/heads/master@{#401527}

[modify] https://crrev.com/7b28158033e882c541f6ff3dc0111b94f59a2ed0/chrome/test/data/webui/cr_elements/cr_toolbar_search_field_tests.js
[modify] https://crrev.com/7b28158033e882c541f6ff3dc0111b94f59a2ed0/ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js
[modify] https://crrev.com/7b28158033e882c541f6ff3dc0111b94f59a2ed0/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html
[modify] https://crrev.com/7b28158033e882c541f6ff3dc0111b94f59a2ed0/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js

Status: Fixed (was: Assigned)

Sign in to add a comment