New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 618624 link

Starred by 2 users
Status: Fixed
Owner:
est...@chromium.org
Closed: Jan 2017
Cc:
█ hdodda@chromium.org
nyerramilli@chromium.org
█ tkonch...@chromium.org
dtrainor@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Saving of page dose not get paused after clicking on 'Pause' button.

Reported by rk...@etouch.net, Jun 9 2016 
Chrome version : 53.0.2763.0 (Official Build) dd933bda0baa6a13ab0120f0056a2b783e459efb-refs/heads/master@{#398752} 32/64 bit
OS :  Windows (7,8,8.1,10),Linux (14.04 LTS), Mac(10.10.5, 10.11.4)
  
What steps will reproduce the problem?
(1) Launch chrome, navigate to https://chrome.google.com/webstore/category/apps
(2) Press Ctrl+S to save the page, pause the download by clicking on 'Pause' button 
(3) Observe 

Saving of page does not get paused after clicking on Pause button.

Saving of page should get paused after clicking on Pause button.

This is a Non-regression issue, seen from 'M-30'(30.0.1549.0)

Comment 1 by rk...@etouch.net, Jun 9 2016

Summary: Saving of page dose not get paused after clicking on 'Pause' button. (was: Saving of page doss not get paused after clicking on 'Pause' button.)

Comment 2 by tkonch...@chromium.org, Jun 9 2016

Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on mac 10.11 chrome version 53.0.2763.0
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 6 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by tkent@chromium.org, Aug 31 2016

Components: -Blink>SavePage UI>Browser>Downloads

Comment 5 by dah...@chromium.org, Jan 10 2017

Cc: dtrainor@chromium.org
Labels: -Pri-2 -M-54 -MovedFrom-53 Pri-3
Owner: est...@chromium.org
Evan, trying to bring in pause functionality is going to be prohibitively expensive, so it looks like the best option for this may be to remove the pause button, so that we don't have no-op UI. Can you take a look?

Comment 6 by dah...@chromium.org, Jan 10 2017

Status: Assigned (was: Untriaged)
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63dcc86b88089a26a04bd3a55964f8c25df52b69

commit 63dcc86b88089a26a04bd3a55964f8c25df52b69
Author: estade <estade@chromium.org>
Date: Wed Jan 11 00:23:41 2017

Disable "pause" item in context menu for "Save Page As..." downloads.

BUG= 618624 

Review-Url: https://codereview.chromium.org/2623613009
Cr-Commit-Position: refs/heads/master@{#442740}

[modify] https://crrev.com/63dcc86b88089a26a04bd3a55964f8c25df52b69/chrome/browser/download/download_commands.cc
[modify] https://crrev.com/63dcc86b88089a26a04bd3a55964f8c25df52b69/chrome/browser/download/download_commands_unittest.cc

Comment 8 by est...@chromium.org, Jan 11 2017

Status: Fixed (was: Assigned)

Comment 9 by hdodda@chromium.org, Jan 12 2017

Cc: hdodda@chromium.org
Labels: TE-Verified-57.0.2979.2 TE-Verified-57.0.2979.0 TE-Verified-M57
Verified on Mac OS 10.12.2 , ubuntu 14.04 and Windows 7 using chrome Dev M57 #57.0.2979.0 and windows clang #57.0.2979.2 and issue is fixed.

As per comment #7 , pause option is disabled in context menu .

Attached screencast for reference.

Adding TE-Verified Labels.

Thanks!
618624.mp4
955 KB View Download
►

Sign in to add a comment