Regression: Mid click opens in two tabs instead of one for links of Synced History |
||||||||||||||||
Issue descriptionVersion: 53.0.2763.0 dev OS: Ubuntu 14.04,Windows What steps will reproduce the problem? (1) Sign in to Chrome and let the history from other devices get synced. (2) Now mid-click using mouse wheel on any link from synced history and observe for opned tab Expected: Only one tab should be opened on mid click using mouse wheel. Actual: Instead two tabs with same link gets opened. This is a regression issue broken in M53. Manual Bisect info: Good Build: 53.0.2762.0 dev Bad Build: 53.0.2763.0 dev Unable to do tool bisect as we can't sign in to chromium to get synced history. Hence providing Cr CR: https://chromium.googlesource.com/chromium/src/+log/53.0.2762.0..53.0.2763.0?pretty=fuller&n=10000 Unable to find suspect.. Please help in assigning to appropriate owner.
,
Jun 9 2016
From the above Changelog range in C#0. Suspecting: https://codereview.chromium.org/2036643003. nzolghadr@: Could you please take a look at this.
,
Jun 9 2016
I'll be looking at it.
,
Jun 9 2016
,
Jun 16 2016
Gentle ping! Do we have any update on the fix? Thank you!
,
Jun 17 2016
I'm sorry. There has been a few bugs related to this issue. I was planning to put the fix in for all of them by the end of June if you don't mind this waiting until then.
,
Jun 23 2016
Just to update: M-53 will be branched in coming week and would be good to have the fix landed for these bugs before M-53 is branched.
,
Jun 23 2016
M53 is branching soon and will be promoted to Beta in July.Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix ASAP. Thank you.
,
Jun 28 2016
M53 is branching this week and will be promoted to Beta in July.Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix ASAP. Thank you.
,
Jul 1 2016
Friendly ping for nzolghadr@ to get an update on this Blocker issue.
,
Jul 1 2016
I'm trying to land the change as soon as I get the bots pass.
,
Jul 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d9d9183fe8c1a4dbfac9f4a6ef8a337b05c1a40 commit 4d9d9183fe8c1a4dbfac9f4a6ef8a337b05c1a40 Author: nzolghadr <nzolghadr@chromium.org> Date: Fri Jul 01 19:02:51 2016 Revert middle click related changes This is the CL to revert the related middle button click changes. We decided to revert those changes because the issues that were caused by suppressing click event for middle button was hard to fix without having that event. Particularly the ability to prevent opening a new tab which can be done by "preventDefault"ing the click event of middle button was removed as the result of the original change. For now we revert these changes and we pursue the line of adding a new event for non-primary button click to be able to fix these problem in a more clean way. Revert "Prevent sending click event for non primary button" This reverts commit 76fea00a18f75886ea649414393228180306e13d. Revert "Dispatch middle click manually by tracking mouse" This reverts commit 88eb1110baafcba070e750866a343e81b6bcc524. Revert "Fix history page middle click action" This reverts commit a154aed1a3813cf28c6f477579ed7974a2528570. BUG= 255 , 618593 , 617444 , 611019 , 617875 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2107093003 Cr-Commit-Position: refs/heads/master@{#403496} [modify] https://crrev.com/4d9d9183fe8c1a4dbfac9f4a6ef8a337b05c1a40/chrome/browser/resources/history/history.js [modify] https://crrev.com/4d9d9183fe8c1a4dbfac9f4a6ef8a337b05c1a40/chrome/browser/resources/ntp4/new_tab.html [delete] https://crrev.com/afd007a5a072039641b7b81eddd9aa488cec4996/chrome/browser/resources/synthetic_middleclick.js [modify] https://crrev.com/4d9d9183fe8c1a4dbfac9f4a6ef8a337b05c1a40/chrome/browser/ui/browser_browsertest.cc [modify] https://crrev.com/4d9d9183fe8c1a4dbfac9f4a6ef8a337b05c1a40/testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter [modify] https://crrev.com/4d9d9183fe8c1a4dbfac9f4a6ef8a337b05c1a40/third_party/WebKit/LayoutTests/fast/events/mouse-click-events-expected.txt [modify] https://crrev.com/4d9d9183fe8c1a4dbfac9f4a6ef8a337b05c1a40/third_party/WebKit/LayoutTests/fast/events/script-tests/mouse-click-events.js [modify] https://crrev.com/4d9d9183fe8c1a4dbfac9f4a6ef8a337b05c1a40/third_party/WebKit/Source/core/events/MouseEvent.cpp [modify] https://crrev.com/4d9d9183fe8c1a4dbfac9f4a6ef8a337b05c1a40/third_party/WebKit/Source/core/input/EventHandler.cpp
,
Jul 1 2016
M53 is branched today (2785) and will be promoted to Beta this month.Your bug is labelled as Beta ReleaseBlock, pls make sure to land and merge the fix to M53 branch 2785 by 5:00 PM PST on Friday 07/22 (sooner the better so it gets chance to bake in M53 dev releases it self). Thank you.
,
Jul 4 2016
Verified the revert on the latest M-54(54.0.2787.0) on Windows-7, Mac OS 10.11.5 and Linux Ubuntu 14.04. This is working as intended.
,
Jul 4 2016
,
Jul 4 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jul 4 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 4 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jul 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0dfcc7e4b98d8c891bb3a8bf03900403aab0637 commit f0dfcc7e4b98d8c891bb3a8bf03900403aab0637 Author: Dave Tapuska <dtapuska@chromium.org> Date: Mon Jul 04 14:25:31 2016 Revert middle click related changes This is the CL to revert the related middle button click changes. We decided to revert those changes because the issues that were caused by suppressing click event for middle button was hard to fix without having that event. Particularly the ability to prevent opening a new tab which can be done by "preventDefault"ing the click event of middle button was removed as the result of the original change. For now we revert these changes and we pursue the line of adding a new event for non-primary button click to be able to fix these problem in a more clean way. Revert "Prevent sending click event for non primary button" This reverts commit 76fea00a18f75886ea649414393228180306e13d. Revert "Dispatch middle click manually by tracking mouse" This reverts commit 88eb1110baafcba070e750866a343e81b6bcc524. Revert "Fix history page middle click action" This reverts commit a154aed1a3813cf28c6f477579ed7974a2528570. BUG= 255 , 618593 , 617444 , 611019 , 617875 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2107093003 Cr-Commit-Position: refs/heads/master@{#403496} (cherry picked from commit 4d9d9183fe8c1a4dbfac9f4a6ef8a337b05c1a40) Review URL: https://codereview.chromium.org/2121003002 . Cr-Commit-Position: refs/branch-heads/2785@{#12} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/f0dfcc7e4b98d8c891bb3a8bf03900403aab0637/chrome/browser/resources/history/history.js [modify] https://crrev.com/f0dfcc7e4b98d8c891bb3a8bf03900403aab0637/chrome/browser/resources/ntp4/new_tab.html [delete] https://crrev.com/aaad16cd6a623d566e75f072db80264e4a5836ac/chrome/browser/resources/synthetic_middleclick.js [modify] https://crrev.com/f0dfcc7e4b98d8c891bb3a8bf03900403aab0637/chrome/browser/ui/browser_browsertest.cc [modify] https://crrev.com/f0dfcc7e4b98d8c891bb3a8bf03900403aab0637/testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter [modify] https://crrev.com/f0dfcc7e4b98d8c891bb3a8bf03900403aab0637/third_party/WebKit/LayoutTests/fast/events/mouse-click-events-expected.txt [modify] https://crrev.com/f0dfcc7e4b98d8c891bb3a8bf03900403aab0637/third_party/WebKit/LayoutTests/fast/events/script-tests/mouse-click-events.js [modify] https://crrev.com/f0dfcc7e4b98d8c891bb3a8bf03900403aab0637/third_party/WebKit/Source/core/events/MouseEvent.cpp [modify] https://crrev.com/f0dfcc7e4b98d8c891bb3a8bf03900403aab0637/third_party/WebKit/Source/core/input/EventHandler.cpp
,
Jul 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eaaefc24ebb90ea1586f1ce7aee411da3da9d16e commit eaaefc24ebb90ea1586f1ce7aee411da3da9d16e Author: Dave Tapuska <dtapuska@chromium.org> Date: Mon Jul 04 14:43:01 2016 Revert middle click related changes This is the CL to revert the related middle button click changes. We decided to revert those changes because the issues that were caused by suppressing click event for middle button was hard to fix without having that event. Particularly the ability to prevent opening a new tab which can be done by "preventDefault"ing the click event of middle button was removed as the result of the original change. For now we revert these changes and we pursue the line of adding a new event for non-primary button click to be able to fix these problem in a more clean way. Revert "Prevent sending click event for non primary button" This reverts commit 76fea00a18f75886ea649414393228180306e13d. Revert "Dispatch middle click manually by tracking mouse" This reverts commit 88eb1110baafcba070e750866a343e81b6bcc524. Revert "Fix history page middle click action" This reverts commit a154aed1a3813cf28c6f477579ed7974a2528570. BUG= 255 , 618593 , 617444 , 611019 , 617875 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2107093003 Cr-Commit-Position: refs/heads/master@{#403496} (cherry picked from commit 4d9d9183fe8c1a4dbfac9f4a6ef8a337b05c1a40) Review URL: https://codereview.chromium.org/2124533002 . Cr-Commit-Position: refs/branch-heads/2743@{#580} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/eaaefc24ebb90ea1586f1ce7aee411da3da9d16e/chrome/browser/resources/history/history.js [modify] https://crrev.com/eaaefc24ebb90ea1586f1ce7aee411da3da9d16e/chrome/browser/resources/ntp4/new_tab.html [delete] https://crrev.com/5f87571138ba5e85759984e956efcb6691cf3770/chrome/browser/resources/synthetic_middleclick.js [modify] https://crrev.com/eaaefc24ebb90ea1586f1ce7aee411da3da9d16e/chrome/browser/ui/browser_browsertest.cc [modify] https://crrev.com/eaaefc24ebb90ea1586f1ce7aee411da3da9d16e/testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter [modify] https://crrev.com/eaaefc24ebb90ea1586f1ce7aee411da3da9d16e/third_party/WebKit/LayoutTests/fast/events/mouse-click-events-expected.txt [modify] https://crrev.com/eaaefc24ebb90ea1586f1ce7aee411da3da9d16e/third_party/WebKit/LayoutTests/fast/events/script-tests/mouse-click-events.js [modify] https://crrev.com/eaaefc24ebb90ea1586f1ce7aee411da3da9d16e/third_party/WebKit/Source/core/events/MouseEvent.cpp [modify] https://crrev.com/eaaefc24ebb90ea1586f1ce7aee411da3da9d16e/third_party/WebKit/Source/core/input/EventHandler.cpp
,
Jul 5 2016
ajha@ if you are testing this that would be great if you test it on both M53 and M52.
,
Jul 7 2016
Verified the issue on Mac 10.11.5,Win 7 and Ubuntu 14.04 using 53.0.2785.8 & 52.0.2743.69 its working fine.
,
Jul 8 2016
Added the respective labels as per the above comment #22.
,
Jul 13 2016
Verified the issue on Latest Beta# 52.0.2743.75 and is working as intended. Hence adding TE-Verified Labels. Thank You.
,
Sep 27 2016
,
Oct 5 2016
|
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by ajha@chromium.org
, Jun 9 2016Status: Untriaged (was: Unconfirmed)