New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 618580 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 425625



Sign in to add a comment

[MD History] Clicking bookmark star should remove bookmark

Project Member Reported by tsergeant@chromium.org, Jun 9 2016

Issue description

In the old history page, clicking the bookmark icon removes the bookmark from that URL. We should replicate the same behavior.

See: https://cs.chromium.org/chromium/src/chrome/browser/resources/history/history.js?q=history.js&sq=package:chromium&dr&l=208
 
Cc: bettes@chromium.org tbuck...@chromium.org
 Issue 620041  has been merged into this issue.
Cc: -calamity@chromium.org
Owner: calamity@chromium.org
Status: Assigned (was: Available)
Cc: calamity@chromium.org
Owner: lshang@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/064a34e7e54d2458dc56e76e6c3e343c622f327b

commit 064a34e7e54d2458dc56e76e6c3e343c622f327b
Author: lshang <lshang@chromium.org>
Date: Fri Jul 01 07:14:27 2016

MD History: Remove bookmark when clicking bookmark star

On current history page, history items with bookmarks will show a bookmark
star, and it's unclickable.

Remove the url's bookmark when clicking bookmark star.

BUG= 618580 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2097003002
Cr-Commit-Position: refs/heads/master@{#403419}

[modify] https://crrev.com/064a34e7e54d2458dc56e76e6c3e343c622f327b/chrome/browser/resources/md_history/browser_service.js
[modify] https://crrev.com/064a34e7e54d2458dc56e76e6c3e343c622f327b/chrome/browser/resources/md_history/compiled_resources2.gyp
[modify] https://crrev.com/064a34e7e54d2458dc56e76e6c3e343c622f327b/chrome/browser/resources/md_history/history_item.html
[modify] https://crrev.com/064a34e7e54d2458dc56e76e6c3e343c622f327b/chrome/browser/resources/md_history/history_item.js
[modify] https://crrev.com/064a34e7e54d2458dc56e76e6c3e343c622f327b/chrome/browser/resources/md_history/history_list.js
[modify] https://crrev.com/064a34e7e54d2458dc56e76e6c3e343c622f327b/chrome/browser/ui/webui/md_history_ui.cc
[modify] https://crrev.com/064a34e7e54d2458dc56e76e6c3e343c622f327b/chrome/test/data/webui/md_history/history_item_test.js

Cc: nyerramilli@chromium.org tkonch...@chromium.org
 Issue 620275  has been merged into this issue.
Status: Fixed (was: Assigned)

Sign in to add a comment