We should imitate the confirmation dialog in the existing history page. This should be easy to do using <paper-dialog>
Specs on dialogs https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/specs#%2FSPEC-settings_dialogs.png%3Fz=width +dave who's been working on dialogs
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1152c9bfedb85a1d802cfd274699d729bc7bad74 commit 1152c9bfedb85a1d802cfd274699d729bc7bad74 Author: tsergeant <tsergeant@chromium.org> Date: Tue Jun 21 09:38:01 2016 MD WebUI: Extract settings-dialog into shared cr-dialog element MD History needs to add a dialog which looks the same as settings' dialogs. This CL moves <settings-dialog> to cr_elements as <cr-dialog> and converts all of settings to use the new element. BUG= 618579 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2071543003 Cr-Commit-Position: refs/heads/master@{#400932} [modify] https://crrev.com/1152c9bfedb85a1d802cfd274699d729bc7bad74/chrome/browser/resources/settings/about_page/channel_switcher_dialog.html [modify] https://crrev.com/1152c9bfedb85a1d802cfd274699d729bc7bad74/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html [modify] https://crrev.com/1152c9bfedb85a1d802cfd274699d729bc7bad74/chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.html [modify] https://crrev.com/1152c9bfedb85a1d802cfd274699d729bc7bad74/chrome/browser/resources/settings/certificate_manager_page/certificate_delete_confirmation_dialog.html [modify] https://crrev.com/1152c9bfedb85a1d802cfd274699d729bc7bad74/chrome/browser/resources/settings/certificate_manager_page/certificate_password_decryption_dialog.html [modify] https://crrev.com/1152c9bfedb85a1d802cfd274699d729bc7bad74/chrome/browser/resources/settings/certificate_manager_page/certificate_password_encryption_dialog.html [modify] https://crrev.com/1152c9bfedb85a1d802cfd274699d729bc7bad74/chrome/browser/resources/settings/certificate_manager_page/certificates_error_dialog.html [modify] https://crrev.com/1152c9bfedb85a1d802cfd274699d729bc7bad74/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html [modify] https://crrev.com/1152c9bfedb85a1d802cfd274699d729bc7bad74/chrome/browser/resources/settings/device_page/display_overscan_dialog.html [modify] https://crrev.com/1152c9bfedb85a1d802cfd274699d729bc7bad74/chrome/browser/resources/settings/on_startup_page/startup_url_dialog.html [modify] https://crrev.com/1152c9bfedb85a1d802cfd274699d729bc7bad74/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html [modify] https://crrev.com/1152c9bfedb85a1d802cfd274699d729bc7bad74/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html [modify] https://crrev.com/1152c9bfedb85a1d802cfd274699d729bc7bad74/chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.html [modify] https://crrev.com/1152c9bfedb85a1d802cfd274699d729bc7bad74/chrome/browser/resources/settings/people_page/users_add_user_dialog.html [modify] https://crrev.com/1152c9bfedb85a1d802cfd274699d729bc7bad74/chrome/browser/resources/settings/privacy_page/privacy_page.js [modify] https://crrev.com/1152c9bfedb85a1d802cfd274699d729bc7bad74/chrome/browser/resources/settings/reset_page/powerwash_dialog.html [modify] https://crrev.com/1152c9bfedb85a1d802cfd274699d729bc7bad74/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html [modify] https://crrev.com/1152c9bfedb85a1d802cfd274699d729bc7bad74/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html [modify] https://crrev.com/1152c9bfedb85a1d802cfd274699d729bc7bad74/chrome/browser/resources/settings/settings_resources.grd [modify] https://crrev.com/1152c9bfedb85a1d802cfd274699d729bc7bad74/chrome/browser/resources/settings/settings_shared_css.html [modify] https://crrev.com/1152c9bfedb85a1d802cfd274699d729bc7bad74/chrome/browser/resources/settings/site_settings/add_site_dialog.html [rename] https://crrev.com/1152c9bfedb85a1d802cfd274699d729bc7bad74/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html [rename] https://crrev.com/1152c9bfedb85a1d802cfd274699d729bc7bad74/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js [add] https://crrev.com/1152c9bfedb85a1d802cfd274699d729bc7bad74/ui/webui/resources/cr_elements/shared_style_css.html [modify] https://crrev.com/1152c9bfedb85a1d802cfd274699d729bc7bad74/ui/webui/resources/cr_elements_resources.grdp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30f026e96aa37ab078efff5521153a2b4bad73fe commit 30f026e96aa37ab078efff5521153a2b4bad73fe Author: tsergeant <tsergeant@chromium.org> Date: Fri Jul 08 09:28:08 2016 MD History: Add confirmation dialog when deleting items from the toolbar BUG= 618579 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2077483002 Cr-Commit-Position: refs/heads/master@{#404319} [modify] https://crrev.com/30f026e96aa37ab078efff5521153a2b4bad73fe/chrome/browser/resources/md_history/app.js [modify] https://crrev.com/30f026e96aa37ab078efff5521153a2b4bad73fe/chrome/browser/resources/md_history/history_list.js [modify] https://crrev.com/30f026e96aa37ab078efff5521153a2b4bad73fe/chrome/browser/resources/md_history/list_container.html [modify] https://crrev.com/30f026e96aa37ab078efff5521153a2b4bad73fe/chrome/browser/resources/md_history/list_container.js [modify] https://crrev.com/30f026e96aa37ab078efff5521153a2b4bad73fe/chrome/browser/ui/webui/history_ui.cc [modify] https://crrev.com/30f026e96aa37ab078efff5521153a2b4bad73fe/chrome/browser/ui/webui/history_ui.h [modify] https://crrev.com/30f026e96aa37ab078efff5521153a2b4bad73fe/chrome/browser/ui/webui/md_history_ui.cc [modify] https://crrev.com/30f026e96aa37ab078efff5521153a2b4bad73fe/chrome/test/data/webui/md_history/history_list_test.js
Comment 1 by bettes@chromium.org
, Jun 14 2016