New issue
Advanced search Search tips

Issue 618536 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

ASAN Debug lkgr bot broke since switching to gn

Project Member Reported by thakis@chromium.org, Jun 9 2016

Issue description

last good: https://build.chromium.org/p/chromium.lkgr/builders/ASAN%20Debug/builds/4476
GYP_DEFINES='asan=1 lsan=1 sanitizer_coverage=edge enable_ipc_fuzzer=1 component=shared_library use_goma=1 gomadir=../../../../goma'
python build/gyp_chromium -G output_dir=out
Updating projects from gyp files...
program finished with exit code 0


first bad: https://build.chromium.org/p/chromium.lkgr/builders/ASAN%20Debug/builds/4477
Writing """\
enable_ipc_fuzzer = true
goma_dir = "../../../../goma"
is_asan = true
is_component_build = true
is_debug = true
is_lsan = true
sanitizer_coverage_flags = "edge"
use_goma = true
""" to /mnt/data/b/build/slave/ASAN_Debug/build/src/out/None/args.gn.

/mnt/data/b/build/slave/ASAN_Debug/build/src/buildtools/linux64/gn gen //out/None --check
  -> returned 1
ERROR at //build/config/sanitizers/sanitizers.gni:119:1: Assertion failed.
assert(!is_debug || !(is_msan || is_lsan || is_tsan || is_ubsan ||
^-----
Sanitizers should generally be used in release (set is_debug=false).
See //BUILD.gn:12:1: whence it was imported.
import("//build/config/sanitizers/sanitizers.gni")
^------------------------------------------------
GN gen failed: 1


Caused by https://codereview.chromium.org/2006173002

Not clear what the right fix is. Should that assert be removed? Should the bot be removed?

Things used to work fine with gyp.

There's also https://cs.chromium.org/chromium/src/tools/ipc_fuzzer/BUILD.gn?q=enable_ipc_fuzzer+file:%5C.gn&sq=package:chromium&l=23&dr=C

  assert(!is_component_build, "IPC fuzzer does not support component builds.")

Should that be removed for debug builds? It seemed to work at least on ASAN Debug.
 

Comment 1 by aarya@google.com, Jun 9 2016

Owner: mbarbe...@chromium.org
Status: Fixed (was: Untriaged)
Fixed by Marty in https://codereview.chromium.org/2047323003/.

Sign in to add a comment