New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 618518 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 76362
issue 618472
issue 621538



Sign in to add a comment

Disable #RRGGBBAA and #RGBA color values due to compat issues

Project Member Reported by rbyers@chromium.org, Jun 9 2016

Issue description

As discussed here: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Y6Q69fwcexo/EhGUN_ySBgAJ

Need to disable this feature ( issue 618472 ) until a targetSdk quirk can be added for WebView ( issue 618472 ) and ideally a little more web compat analysis is done.

Reverting looks painful (lots of code) and unnecessary - I'll prepare a tiny patch to move the feature to "experimental" status.
 
Blocking: 618472
Blocking: 76362
samli@ It's not obvious to me how to make the 4/8-digit support in devTools conditional on a RuntimeEnabledFeature (or if that's even strictly necessary).  Can you do that or revert your patch?

Comment 4 by samli@chromium.org, Jun 9 2016

I don't see any necessity to revert devtools side support.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7bc5783027ae86ff6eb6912d0a6112cda6a8814

commit b7bc5783027ae86ff6eb6912d0a6112cda6a8814
Author: rbyers <rbyers@chromium.org>
Date: Thu Jun 09 04:57:08 2016

Disable 4 and 8 digit hex CSS colors

New compat concerns have been raised with 4 and 8 digit HEX color
values in CSS.  In particular, a targetSdk quirk needs to be added
for Android WebView to avoid breaking Android apps.

Demote this feature to "experimental" status until an owner can be found.

BUG= 618518 ,  76362 

Review-Url: https://codereview.chromium.org/2047413003
Cr-Commit-Position: refs/heads/master@{#398789}

[modify] https://crrev.com/b7bc5783027ae86ff6eb6912d0a6112cda6a8814/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/b7bc5783027ae86ff6eb6912d0a6112cda6a8814/third_party/WebKit/Source/platform/graphics/Color.cpp

Labels: Te-NeedsFurtherTriage
Labels: Needs-Feedback
rbyers@, can this be tested manually so that we can verify it on Canary before it gets merged in to M52 branch ?

Comment 8 by timloh@chromium.org, Jun 15 2016

Confirmed the issues is resolved on 53.0.2768.0
Labels: OS-All
Looks like OS-All, so tagging as such, re-tag if needed.

In the future please make sure all ReleaseBlock-* issues have an OS set, that's how release teams manage blockers.
A friendly reminder that M52 Stable is launching soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch by July 12. All changes MUST be merged into the release branch by 5pm on July 15 to make into the desktop Stable final build cut. Thank you!
rbyers@, As per comment #8 could you please let us know if this can be closed.
Blocking: 621538
Sorry for the delay - BlinkOn.  This has stuck in canary and seems like the lowest-risk thing we can merge to avoid the problem discussed in  issue 618472 .  Requesting merge of b7bc5783027ae86ff6eb6912d0a6112cda6a8814 for 52.

Filed  issue 621538  to track DevTools support separately.

Labels: -Te-NeedsFurtherTriage
Re #7: simple test page: http://jsbin.com/moyobo
The box will be transparent (grey) when the feature is disabled, and blue when supported.
Labels: Merge-Request-52

Comment 16 by tin...@google.com, Jun 20 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
I see the transparent box on [Version 53.0.2773.0 canary (64-bit)] - Win, Mac OSX & Linux/Ubuntu 14.04 . Seems like this is the intended behavior as the feature is disabled.

rbyers@, 
Please also have the CL merged in to M52 branch by EOD so that it gets picked up for beta promotion scheduled this week.

618518 Screenshot.PNG
13.1 KB View Download
Project Member

Comment 19 by bugdroid1@chromium.org, Jun 20 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c24aa54c19c702703d68bc0bc62b7a5449d3755

commit 1c24aa54c19c702703d68bc0bc62b7a5449d3755
Author: Rick Byers <rbyers@chromium.org>
Date: Mon Jun 20 21:20:27 2016

Disable 4 and 8 digit hex CSS colors

New compat concerns have been raised with 4 and 8 digit HEX color
values in CSS.  In particular, a targetSdk quirk needs to be added
for Android WebView to avoid breaking Android apps.

Demote this feature to "experimental" status until an owner can be found.

BUG= 618518 ,  76362 

Review-Url: https://codereview.chromium.org/2047413003
Cr-Commit-Position: refs/heads/master@{#398789}
(cherry picked from commit b7bc5783027ae86ff6eb6912d0a6112cda6a8814)

Review URL: https://codereview.chromium.org/2086433003 .

Cr-Commit-Position: refs/branch-heads/2743@{#413}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/1c24aa54c19c702703d68bc0bc62b7a5449d3755/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/1c24aa54c19c702703d68bc0bc62b7a5449d3755/third_party/WebKit/Source/platform/graphics/Color.cpp

Status: Fixed (was: Started)
Labels: TE-Verified-52.0.2743.49 TE-Verified-M52
Tested the issue on windows 7, Linux Ubuntu 14.04 and Mac 10.11.5 using chrome version 52.0.2743.49.Observed the transparent box.Please find the attached screen shot for the same.

Adding TE-Verified label.

Thanks,
618518.png
71.2 KB View Download

Sign in to add a comment