New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 618513 link

Starred by 1 user
Status: Fixed
Owner:
simonhatch@chromium.org
Closed: Jun 2016
Cc:
█ nednguyen@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression



Sign in to add a comment

jetstream failure on chromium.perf on Win/Mac/Linux

Project Member Reported by simonhatch@chromium.org, Jun 9 2016 
Traceback (most recent call last):
  RunBenchmark at /b/build/slave/Linux_Perf__3_/build/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:312
    benchmark.ShouldTearDownStateAfterEachStoryRun())
  Run at /b/build/slave/Linux_Perf__3_/build/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:225
    _RunStoryAndProcessErrorIfNeeded(story, results, state, test)
  _RunStoryAndProcessErrorIfNeeded at /b/build/slave/Linux_Perf__3_/build/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:84
    state.RunStory(results)
  RunStory at /b/build/slave/Linux_Perf__3_/build/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py:308
    self._current_page, self._current_tab, results)
  ValidateAndMeasurePage at /b/build/slave/Linux_Perf__3_/build/src/tools/perf/benchmarks/jetstream.py:59
    tab.WaitForDocumentReadyStateToBeComplete()
UnboundLocalError: local variable 'tab' referenced before assignment

Likely culprit: https://codereview.chromium.org/1914233003

Comment 1 by nedngu...@google.com, Jun 9 2016 

OOps, I will send out patch fix right away.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e432fca730be8b7af2889419d12342420f7ffcb

commit 2e432fca730be8b7af2889419d12342420f7ffcb
Author: simonhatch <simonhatch@chromium.org>
Date: Thu Jun 09 00:49:33 2016

Fix jetstream unreferenced tab variable.

BUG= 618513 
NOTRY=true

Review-Url: https://codereview.chromium.org/2051673003
Cr-Commit-Position: refs/heads/master@{#398751}

[modify] https://crrev.com/2e432fca730be8b7af2889419d12342420f7ffcb/tools/perf/benchmarks/jetstream.py

Comment 3 by nedngu...@google.com, Jun 9 2016

Owner: simonhatch@chromium.org
Status: Fixed (was: Untriaged)
Should be fixed by Simon's patch.
►

Sign in to add a comment