New issue
Advanced search Search tips

Issue 618508 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

[Media Router WebUI] Cast button in route details is too wide

Project Member Reported by btolsch@chromium.org, Jun 9 2016

Issue description

Version: 53.0.2750.0

A recent Polymer roll (https://chromium.googlesource.com/chromium/src/+/d98decf326acae85fe4bb758ca760abcd0caf5f7) has caused the cast button to be too wide.  This also makes it difficult tell where the boundary is between the cast button and the stop button, as the paper-button elements don't have background colors.
 
Components: Blink>PresentationAPI
Labels: OS-All
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4a9571b30800a635327ab6fe40eb8014901f8e0

commit b4a9571b30800a635327ab6fe40eb8014901f8e0
Author: btolsch <btolsch@chromium.org>
Date: Thu Jun 09 20:46:48 2016

[Media Router WebUI] Remove flex layout from cast button

The cast button in the route details view should not fill the remaining
horizontal space it has, so this change removes the flex property from
it.

BUG= 618508 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2049953003
Cr-Commit-Position: refs/heads/master@{#399003}

[modify] https://crrev.com/b4a9571b30800a635327ab6fe40eb8014901f8e0/chrome/browser/resources/media_router/elements/route_details/route_details.css

Status: Fixed (was: Assigned)
Labels: Merge-Request-52

Comment 5 by tin...@google.com, Jun 13 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 13 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3f0677b933ff9d1cc2f3547a635ad529415e1a1

commit c3f0677b933ff9d1cc2f3547a635ad529415e1a1
Author: btolsch <btolsch@chromium.org>
Date: Mon Jun 13 18:43:08 2016

[Media Router WebUI] Remove flex layout from cast button

The cast button in the route details view should not fill the remaining
horizontal space it has, so this change removes the flex property from
it.

BUG= 618508 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2049953003
Cr-Commit-Position: refs/heads/master@{#399003}
(cherry picked from commit b4a9571b30800a635327ab6fe40eb8014901f8e0)

Review-Url: https://codereview.chromium.org/2059353002
Cr-Commit-Position: refs/branch-heads/2743@{#337}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/c3f0677b933ff9d1cc2f3547a635ad529415e1a1/chrome/browser/resources/media_router/elements/route_details/route_details.css

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4a9571b30800a635327ab6fe40eb8014901f8e0

commit b4a9571b30800a635327ab6fe40eb8014901f8e0
Author: btolsch <btolsch@chromium.org>
Date: Thu Jun 09 20:46:48 2016

[Media Router WebUI] Remove flex layout from cast button

The cast button in the route details view should not fill the remaining
horizontal space it has, so this change removes the flex property from
it.

BUG= 618508 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2049953003
Cr-Commit-Position: refs/heads/master@{#399003}

[modify] https://crrev.com/b4a9571b30800a635327ab6fe40eb8014901f8e0/chrome/browser/resources/media_router/elements/route_details/route_details.css

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3f0677b933ff9d1cc2f3547a635ad529415e1a1

commit c3f0677b933ff9d1cc2f3547a635ad529415e1a1
Author: btolsch <btolsch@chromium.org>
Date: Mon Jun 13 18:43:08 2016

[Media Router WebUI] Remove flex layout from cast button

The cast button in the route details view should not fill the remaining
horizontal space it has, so this change removes the flex property from
it.

BUG= 618508 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2049953003
Cr-Commit-Position: refs/heads/master@{#399003}
(cherry picked from commit b4a9571b30800a635327ab6fe40eb8014901f8e0)

Review-Url: https://codereview.chromium.org/2059353002
Cr-Commit-Position: refs/branch-heads/2743@{#337}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/c3f0677b933ff9d1cc2f3547a635ad529415e1a1/chrome/browser/resources/media_router/elements/route_details/route_details.css

Labels: Needs-Feedback
btolsch@, can you please let us know if this can be tested manually ?
Labels: -Needs-Feedback
This can be tested as follows:

1. Enable Media Router with the media-router flag (command line or chrome://flags).
2. Go to a youtube video, click the cast icon in the video, and select a device to which to cast.
3. Close the tab.
4. Navigate back to the same youtube video and click the cast icon again.
5. Observe that there is a "cast" button in the dialog.
6. The "cast" and "stop" buttons should be right-aligned in the dialog and overall width of the "cast" button should not be much wider than the text. The width can be verified with the developer tools or by holding the mouse down (click down) on the button to see the background fill.

Sign in to add a comment