Update the text color on "Guest" on guest mode |
||||||||||||
Issue descriptionReported by ainslie@ Version: 53.0.2762.0 (Official Build) canary (64-bit) OS: OSX What steps will reproduce the problem? (1) Switch person > Browse as guest (2) Open another widnow (3) See the string color contrast on "Guest" chip (top right corner): http://leaverou.github.io/contrast-ratio/#%23fff-on-rgb%28227%2C227%2C227%29 Suggested fix: use the same text color(#000?) used on the regular mode. Recommended contrast ratio is 4.5 or higher.
,
Jun 9 2016
Looks like this is set in updateAvatarButtonAndLayoutParent at https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm?sq=package:chromium&dr=C. Since noms@ is inactive, assigning to rsesek@ for further triage/action.
,
Jun 9 2016
,
Jun 9 2016
,
Jun 9 2016
spqchan@ - would you please put together a cl to fix this? Thank you.
,
Jun 9 2016
,
Jun 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb1df9d42a87c280c4add2366c51fa2e8bff8f36 commit bb1df9d42a87c280c4add2366c51fa2e8bff8f36 Author: spqchan <spqchan@chromium.org> Date: Thu Jun 09 20:18:54 2016 [Mac][Material]Update the text color on Guest Mode Chip BUG= 618506 Review-Url: https://codereview.chromium.org/2050303003 Cr-Commit-Position: refs/heads/master@{#398995} [modify] https://crrev.com/bb1df9d42a87c280c4add2366c51fa2e8bff8f36/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm
,
Jun 9 2016
,
Jun 10 2016
Verified the issue on Mac OS 10.11.5 using chrome latest canary M53-53.0.2764.0 and observed the text color on guest mode is seen as expected screen-shot provided in comment #0. Hence adding TE-Verified label.
,
Jun 10 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 10 2016
Please have the CL merged to M52 branch so that it gets picked up for Beta Promotion scheduled on 06/15.
,
Jun 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9f68e49da45c26307cbd0ec49a1231d646addd6 commit a9f68e49da45c26307cbd0ec49a1231d646addd6 Author: spqchan <spqchan@chromium.org> Date: Fri Jun 10 23:38:05 2016 [Mac][Material]Update the text color on Guest Mode Chip BUG= 618506 Review-Url: https://codereview.chromium.org/2050303003 Cr-Commit-Position: refs/heads/master@{#398995} (cherry picked from commit bb1df9d42a87c280c4add2366c51fa2e8bff8f36) Review URL: https://codereview.chromium.org/2062563002 . Cr-Commit-Position: refs/branch-heads/2743@{#321} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/a9f68e49da45c26307cbd0ec49a1231d646addd6/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm
,
Jun 10 2016
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb1df9d42a87c280c4add2366c51fa2e8bff8f36 commit bb1df9d42a87c280c4add2366c51fa2e8bff8f36 Author: spqchan <spqchan@chromium.org> Date: Thu Jun 09 20:18:54 2016 [Mac][Material]Update the text color on Guest Mode Chip BUG= 618506 Review-Url: https://codereview.chromium.org/2050303003 Cr-Commit-Position: refs/heads/master@{#398995} [modify] https://crrev.com/bb1df9d42a87c280c4add2366c51fa2e8bff8f36/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9f68e49da45c26307cbd0ec49a1231d646addd6 commit a9f68e49da45c26307cbd0ec49a1231d646addd6 Author: spqchan <spqchan@chromium.org> Date: Fri Jun 10 23:38:05 2016 [Mac][Material]Update the text color on Guest Mode Chip BUG= 618506 Review-Url: https://codereview.chromium.org/2050303003 Cr-Commit-Position: refs/heads/master@{#398995} (cherry picked from commit bb1df9d42a87c280c4add2366c51fa2e8bff8f36) Review URL: https://codereview.chromium.org/2062563002 . Cr-Commit-Position: refs/branch-heads/2743@{#321} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/a9f68e49da45c26307cbd0ec49a1231d646addd6/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm
,
Jun 15 2016
Verified the issue on Mac OS 10.11.5 using chrome latest Beta M52-52.0.2743.41 and observed the text color on guest mode is seen as expected screen-shot provided in comment #0. Hence adding TE-Verified label. |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by hwi@chromium.org
, Jun 9 201637.0 KB
37.0 KB View Download