Clobber isn't clobbering |
|||
Issue descriptionI tried doing a clobber build via this UI: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac%20Builder%20%28dbg%29 Build 156887 (https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac%20Builder%20%28dbg%29/builds/156887) has the flag set. The compile step clearly isn't building from a clean output dir though. thakis@ any ideas?
,
Jun 8 2016
Errrr, I mean property. The clobber build property is set on the linked build.
,
Jun 8 2016
Do you think this is a regression from bug 574557 ? From what I understand, that button sets the 'clobber' buildbot property, and I don't know if recipes generally look at those (which means this wouldn't have worked ever since we switched to recipes). Can you remember using this box successfully in the somewhat recent past?
,
Jun 9 2016
Sorry, I've never used it before today. I was just told this was how I was supposed to be able to clobber a builder and that this should result in a clean forced build. dpranke suggested I file a bug and mentioned you had been changing clobber behavior
,
Jun 9 2016
,
Jun 9 2016
I think this is a regression, yes, and the recipes did look at the property.
,
Jun 9 2016
Do you happen to know how to look at a property in a recipe, or where the old clobber logic looked at…oooh I think I know where. Fixing...
,
Jun 9 2016
https://codereview.chromium.org/2045403003/ might help
,
Jun 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/dceceeb31bd3506493793ce20bc7639c3a1f0d99 commit dceceeb31bd3506493793ce20bc7639c3a1f0d99 Author: thakis <thakis@chromium.org> Date: Thu Jun 09 01:24:06 2016 Try to fix the "Clobber" button in the buildbot UI. I probably broke it in https://codereview.chromium.org/2033513002 BUG= 574557 , 618484 Review-Url: https://codereview.chromium.org/2045403003 [modify] https://crrev.com/dceceeb31bd3506493793ce20bc7639c3a1f0d99/scripts/slave/recipe_modules/chromium/api.py
,
Jun 9 2016
rockot: can you try again? (don't have corp access today)
,
Jun 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/beb1c223dc40e3c86b5eebca74292b6c4c408dce commit beb1c223dc40e3c86b5eebca74292b6c4c408dce Author: recipe-roller <recipe-roller@chromium.org> Date: Thu Jun 09 01:39:18 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/f98a8fcef0990839d565fe4564bb42368a4dccf3 lkgr: Convert mac asan bots to recipes/ (thakis@chromium.org) https://crrev.com/dceceeb31bd3506493793ce20bc7639c3a1f0d99 Try to fix the "Clobber" button in the buildbot UI. (thakis@chromium.org) R=thakis@chromium.org BUG= 574557 , 618484 , 618425 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2052543005 [modify] https://crrev.com/beb1c223dc40e3c86b5eebca74292b6c4c408dce/infra/config/recipes.cfg
,
Jun 9 2016
This appears to work now. I kicked off a clobber build and it looks like a clean one. Thanks!
,
Jun 9 2016
You should see a "rmtree clobber" step on the step list.
,
Jun 9 2016
Indeed I do
,
Jun 17 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/532b2bf88f72c234812c0d7368b25d297a914563 commit 532b2bf88f72c234812c0d7368b25d297a914563 Author: recipe-roller <recipe-roller@chromium.org> Date: Thu Jun 09 01:28:18 2016 |
|||
►
Sign in to add a comment |
|||
Comment 1 by thakis@chromium.org
, Jun 8 2016