New issue
Advanced search Search tips

Issue 618480 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----



Sign in to add a comment

Download notification display issue when resuming a download after browser is killed

Project Member Reported by qin...@chromium.org, Jun 8 2016

Issue description


Steps to reproduce:
(1) Disable System Downloadmanager, and download a large file.
(2) while file is downloading, kill the browser by swiping it away from recents
(3) Click the resume button to resume the download

Expected result:
Download should resume and notification should show the progress

Actual result:
After 10 seconds, the notification changes to a state as if the progress cannot be determined, and then changes back.

The issue is caused by auto resumption. When browser starts, we resumes all download after 10 seconds. It will change the download notification to the unknown percentage state, and thus impacting the existing notification if it is already in progress.




 
Labels: -M52 M-52
Status: Assigned (was: Unconfirmed)
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 9 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fced9ce5b94c3385b2be0cbe6e102007a9dea54b

commit fced9ce5b94c3385b2be0cbe6e102007a9dea54b
Author: qinmin <qinmin@chromium.org>
Date: Fri Jun 10 18:42:27 2016

Fix a bug that in progress notification can change when auto resumption starts

When a download is in progress, auto resumption should be an
no-op for it.
However, auto resumption changes the notification icon when started.
This CL fixes that issue.

BUG= 618480 

Review-Url: https://codereview.chromium.org/2053523002
Cr-Commit-Position: refs/heads/master@{#399237}

[modify] https://crrev.com/fced9ce5b94c3385b2be0cbe6e102007a9dea54b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/fced9ce5b94c3385b2be0cbe6e102007a9dea54b/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fced9ce5b94c3385b2be0cbe6e102007a9dea54b

commit fced9ce5b94c3385b2be0cbe6e102007a9dea54b
Author: qinmin <qinmin@chromium.org>
Date: Fri Jun 10 18:42:27 2016

Fix a bug that in progress notification can change when auto resumption starts

When a download is in progress, auto resumption should be an
no-op for it.
However, auto resumption changes the notification icon when started.
This CL fixes that issue.

BUG= 618480 

Review-Url: https://codereview.chromium.org/2053523002
Cr-Commit-Position: refs/heads/master@{#399237}

[modify] https://crrev.com/fced9ce5b94c3385b2be0cbe6e102007a9dea54b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/fced9ce5b94c3385b2be0cbe6e102007a9dea54b/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java

Comment 5 by qin...@chromium.org, Jun 15 2016

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Works as per expected behavior , Download resumes and notification shows the progress after tapping resume button. 
Tested on 53.0.2774.2

Sign in to add a comment