Webview layout tests failed not finding window.chrome? |
|||
Issue descriptionhttps://build.chromium.org/p/chromium.android/builders/Android%20Webview%20L%20%28dbg%29/builds/14399/steps/Instrumentation%20test%20SystemWebViewShellLayoutTest/logs/stdio C 81.209s Main [FAIL] org.chromium.webview_shell.test.WebViewLayoutTest#testWebViewIncludedStableInterfaces: C 81.209s Main junit.framework.ComparisonFailure: Missing webview interfaces found expected:<[]> but was:<[[GLOBAL OBJECT].attribute chrome C 81.209s Main ]> C 81.209s Main at org.chromium.webview_shell.test.WebViewLayoutTest.testWebViewIncludedStableInterfaces(WebViewLayoutTest.java:201) C 81.209s Main at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214) C 81.209s Main at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199) C 81.209s Main at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192) C 81.209s Main at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:129) C 81.209s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) C 81.210s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) C 81.210s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555) C 81.210s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853) Not obvious which blink CL changed this, or if it's a flake..
,
Jun 9 2016
it's not a flake, it appears to be due to https://codereview.chromium.org/1994683004/ which adds a new window.chrome attribute. I've filed a bug to investigate whether it should be exposed in webview.
,
Jun 9 2016
going to add to excluded interfaces for now to unbreak the bots until there is more clarity on the blocking bug
,
Jun 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b2cc9a2b30067cbbd3327ad9d1a2ebcb930dbaa commit 9b2cc9a2b30067cbbd3327ad9d1a2ebcb930dbaa Author: timvolodine <timvolodine@chromium.org> Date: Thu Jun 09 11:54:38 2016 [WebView] Unbreak layout tests on the Android WebView L/M bots. Add the "window.chrome" attribute to excluded interfaces for WebView. BUG= 618471 TBR=torne@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2053633002 Cr-Commit-Position: refs/heads/master@{#398846} [modify] https://crrev.com/9b2cc9a2b30067cbbd3327ad9d1a2ebcb930dbaa/android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt
,
Jun 9 2016
window.chrome is not actually web-exposed, it is only exposed in layout tests so we can simply add it to the exclusions
,
Jun 9 2016
the bots are green now
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b2cc9a2b30067cbbd3327ad9d1a2ebcb930dbaa commit 9b2cc9a2b30067cbbd3327ad9d1a2ebcb930dbaa Author: timvolodine <timvolodine@chromium.org> Date: Thu Jun 09 11:54:38 2016 [WebView] Unbreak layout tests on the Android WebView L/M bots. Add the "window.chrome" attribute to excluded interfaces for WebView. BUG= 618471 TBR=torne@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2053633002 Cr-Commit-Position: refs/heads/master@{#398846} [modify] https://crrev.com/9b2cc9a2b30067cbbd3327ad9d1a2ebcb930dbaa/android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt |
|||
►
Sign in to add a comment |
|||
Comment 1 by timvolod...@chromium.org
, Jun 9 2016