New issue
Advanced search Search tips

Issue 618468 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocked on:
issue 626492



Sign in to add a comment

Flip all remaining Mac bots to GN

Project Member Reported by dpranke@chromium.org, Jun 8 2016

Issue description

We're ready to flip all of the remaining Mac bots to GN.
 
Blocking: 431177 621679
Labels: M-53
Only some (well, most) of the builders need to be flipped over before we ship GN. All of them need to be flipped over before we drop GYP support, obviously.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04817566fb446d8315cbc4049266c4859a010a74

commit 04817566fb446d8315cbc4049266c4859a010a74
Author: rsesek <rsesek@chromium.org>
Date: Tue Jun 21 04:49:12 2016

Flip Mac CQ bots and matching waterfall bots to GN.

This affects:

tryserver.chromium.mac:
  - mac_chromium_compile_dbg_ng
  - mac_chromium_compile_rel_ng
  - mac_chromium_dbg_ng
  - mac_chromium_rel_ng
chromium.mac:
  - Mac Builder
  - Mac Builder (dbg)
chromium.gpu:
  - GPU Mac Builder
  - GPU Mac Builder (dbg)
chromium.gpu.fyi
  - GPU Mac Builder
  - GPU Mac Builder (dbg)

patch from issue 2046863005 at patchset 60001 (http://crrev.com/2046863005#ps60001)

R=dpranke@chromium.org
BUG= 618468 

Review-Url: https://codereview.chromium.org/2085483003
Cr-Commit-Position: refs/heads/master@{#400895}

[modify] https://crrev.com/04817566fb446d8315cbc4049266c4859a010a74/tools/mb/mb_config.pyl
[modify] https://crrev.com/04817566fb446d8315cbc4049266c4859a010a74/tools/perf/chrome_telemetry_build/BUILD.gn

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a670a525b7507193ac9bfc03a84443120fde58a

commit 2a670a525b7507193ac9bfc03a84443120fde58a
Author: dpranke <dpranke@chromium.org>
Date: Tue Jun 21 16:50:19 2016

Actually flip the chromium.mac Mac builders to GN after r400895.

These were accidentally missed in r400895 and now the trybots
are out of sync w/ the continuous bots.

TBR=rsesek@chromium.org
NOTRY=true
BUG= 618468 

Review-Url: https://codereview.chromium.org/2082053002
Cr-Commit-Position: refs/heads/master@{#401017}

[modify] https://crrev.com/2a670a525b7507193ac9bfc03a84443120fde58a/tools/mb/mb_config.pyl

Marking as P1 until all of the builders we need to ship are flipped over.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edf8327a75981f91e292a8eeca4fef7aa2a942a3

commit edf8327a75981f91e292a8eeca4fef7aa2a942a3
Author: dpranke <dpranke@chromium.org>
Date: Wed Jun 22 15:40:12 2016

Flip more Mac builders to GN.

This flips the following builders to GN:

- chromium
  - Mac
- chromium.chrome
  - Google Chrome Mac
- chromium.perf
  - Mac Builder
- tryserver.chromium.mac
  - mac_chromium_10.10_rel_ng
  - mac_chromium_archive_rel_ng
  - mac_nacl_sdk
  - mac_nacl_sdk_build
  - mac_optional_gpu_tests_rel

Leaving pretty much just the internal official builders, the
memory/sanitizer builders, the angle trybots, and various fyi builders.

R=rsesek@chromium.org
BUG= 618468 

Review-Url: https://codereview.chromium.org/2084253002
Cr-Commit-Position: refs/heads/master@{#401288}

[modify] https://crrev.com/edf8327a75981f91e292a8eeca4fef7aa2a942a3/tools/mb/mb_config.pyl

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e235a0ebf9016b3ca88c3ebae3cf6706c5e57ec

commit 1e235a0ebf9016b3ca88c3ebae3cf6706c5e57ec
Author: dpranke <dpranke@chromium.org>
Date: Wed Jun 22 16:51:23 2016

Enable stripping on "Mac" builder on /p/chromium waterfall

The mb config wasn't setting the 'enable_stripping' flag and was
erroring out as a result after we flipped it to GN.

TBR=rsesek@chromium.org
NOTRY=true
BUG= 618468 ,  330301 

Review-Url: https://codereview.chromium.org/2091453002
Cr-Commit-Position: refs/heads/master@{#401307}

[modify] https://crrev.com/1e235a0ebf9016b3ca88c3ebae3cf6706c5e57ec/tools/mb/mb_config.pyl

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb929f6769c9a834e5941a2412ec2883b3b162fe

commit cb929f6769c9a834e5941a2412ec2883b3b162fe
Author: dpranke <dpranke@chromium.org>
Date: Wed Jun 22 17:25:13 2016

Flip remaining chromium.webrtc* builders to GN.

There are very few GYP builders remaining on the chromium waterfalls;
all of the main builders have been flipped to GN, so WebRTC should be
testing that config now.

R=kjellander@chromium.org
BUG= 605318 ,  618468 

Review-Url: https://codereview.chromium.org/2085873005
Cr-Commit-Position: refs/heads/master@{#401327}

[modify] https://crrev.com/cb929f6769c9a834e5941a2412ec2883b3b162fe/tools/mb/mb_config.pyl

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64cecdda60c559f9aa5dcdd7cb40e513bc0eab29

commit 64cecdda60c559f9aa5dcdd7cb40e513bc0eab29
Author: dpranke <dpranke@chromium.org>
Date: Wed Jun 22 17:27:14 2016

Remove client.skia section from mb_config.pyl.

The builders were removed so this section was useless.

TBR=borenet@google.com
BUG= 618468 ,  605318 

Review-Url: https://codereview.chromium.org/2089953002
Cr-Commit-Position: refs/heads/master@{#401329}

[modify] https://crrev.com/64cecdda60c559f9aa5dcdd7cb40e513bc0eab29/tools/mb/mb_config.pyl

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/884703f4bf5590d99218a3bae5b01247e16746fb

commit 884703f4bf5590d99218a3bae5b01247e16746fb
Author: dpranke <dpranke@chromium.org>
Date: Wed Jun 22 18:30:14 2016

Stop running tests on Mac GN builders and remove from the CQ.

Now that we've flipped the main Mac builders in the CQ to GN,
the GN builders are redundant and can be shut down.

R=jam@chromium.org, rsesek@chromium.org
BUG= 618468 

Review-Url: https://codereview.chromium.org/2088983002
Cr-Commit-Position: refs/heads/master@{#401361}

[modify] https://crrev.com/884703f4bf5590d99218a3bae5b01247e16746fb/infra/config/cq.cfg
[modify] https://crrev.com/884703f4bf5590d99218a3bae5b01247e16746fb/testing/buildbot/chromium.mac.json

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0e61fe77ee3b64299e38bb13ef093e26f148e45

commit b0e61fe77ee3b64299e38bb13ef093e26f148e45
Author: phoglund <phoglund@chromium.org>
Date: Thu Jun 23 10:00:09 2016

Revert of Flip remaining chromium.webrtc* builders to GN. (patchset #2 id:20001 of https://codereview.chromium.org/2085873005/ )

Reason for revert:
Reason for revert:
Speculative revert: causes H264 regression (?): https://bugs.chromium.org/p/chromium/issues/detail?id=622632

BUG=622632

Original issue's description:
> Flip remaining chromium.webrtc* builders to GN.
>
> There are very few GYP builders remaining on the chromium waterfalls;
> all of the main builders have been flipped to GN, so WebRTC should be
> testing that config now.
>
> R=kjellander@chromium.org
> BUG= 605318 ,  618468 
>
> Committed: https://crrev.com/cb929f6769c9a834e5941a2412ec2883b3b162fe
> Cr-Commit-Position: refs/heads/master@{#401327}

TBR=kjellander@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 605318 ,  618468 

Review-Url: https://codereview.chromium.org/2095473004
Cr-Commit-Position: refs/heads/master@{#401574}

[modify] https://crrev.com/b0e61fe77ee3b64299e38bb13ef093e26f148e45/tools/mb/mb_config.pyl

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6d02268650a10af563042109968d9f58a43170d

commit f6d02268650a10af563042109968d9f58a43170d
Author: phoglund <phoglund@chromium.org>
Date: Thu Jun 23 13:04:54 2016

Reland of Flip remaining chromium.webrtc* builders to GN. (patchset #1 id:1 of https://codereview.chromium.org/2088343003/ )

Reason for revert:
This revert broke the WebRTC win build (?)

Original issue's description:
> Revert of Flip remaining chromium.webrtc* builders to GN. (patchset #2 id:20001 of https://codereview.chromium.org/2085873005/ )
>
> Reason for revert:
> Speculative revert: causes H264 regression (?): https://bugs.chromium.org/p/chromium/issues/detail?id=622632
>
> BUG=622632
>
> Original issue's description:
> > Flip remaining chromium.webrtc* builders to GN.
> >
> > There are very few GYP builders remaining on the chromium waterfalls;
> > all of the main builders have been flipped to GN, so WebRTC should be
> > testing that config now.
> >
> > R=kjellander@chromium.org
> > BUG= 605318 ,  618468 
> >
> > Committed: https://crrev.com/cb929f6769c9a834e5941a2412ec2883b3b162fe
> > Cr-Commit-Position: refs/heads/master@{#401327}
>
> TBR=kjellander@chromium.org,dpranke@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 605318 ,  618468 

TBR=kjellander@chromium.org,dpranke@chromium.org,phoglund@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=622632

Review-Url: https://codereview.chromium.org/2081393005
Cr-Commit-Position: refs/heads/master@{#401593}

[modify] https://crrev.com/f6d02268650a10af563042109968d9f58a43170d/tools/mb/mb_config.pyl

Project Member

Comment 13 by bugdroid1@chromium.org, Jun 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63619254507db98dec507b02a4ac09a9a4629009

commit 63619254507db98dec507b02a4ac09a9a4629009
Author: dpranke <dpranke@chromium.org>
Date: Fri Jun 24 17:37:15 2016

Flip mac full builders to GN.

This flips the 'Mac' build on the 'chromium' waterfall and the
'Google Chrome Mac' build on the 'chromium.chrome' waterfall to GN.
If this sticks overnight, we can try to flip the official builders
to GN in the morning. This also flips the 'mac_chromium_archive_rel_ng'
MB config to match the 'Mac' config so that we can test builds more
effectively.

The official build still isn't "right", since we haven't ported over
the installer for the remoting me2me host. I'm going to try and work
around that for now so that we can see what else might be missing.

R=rsesek@chromium.org
TBR=zijiehe@chromium.org, sergeyu@chromium.org
BUG= 618468 

Review-Url: https://codereview.chromium.org/2094783003
Cr-Commit-Position: refs/heads/master@{#401894}

[modify] https://crrev.com/63619254507db98dec507b02a4ac09a9a4629009/remoting/host/BUILD.gn
[modify] https://crrev.com/63619254507db98dec507b02a4ac09a9a4629009/tools/mb/mb_config.pyl

Project Member

Comment 14 by bugdroid1@chromium.org, Jun 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf63a9a5e547087e23a0773e5875a1e2fa4331b1

commit cf63a9a5e547087e23a0773e5875a1e2fa4331b1
Author: dpranke <dpranke@chromium.org>
Date: Fri Jun 24 18:12:27 2016

Flip mac and win "gn" builders back to GYP.

Now that the main builders are on GN, we can flip the dedicated
"gn" builders back to GYP and rename them to "gyp" to avoid
confusion and keep some GYP coverage on the main waterfalls
(they will build "all" but not run tests or be in the CQ for now).

R=rsesek@chromium.org
BUG= 618468 ,  605318 

Review-Url: https://codereview.chromium.org/2092173002
Cr-Commit-Position: refs/heads/master@{#401910}

[modify] https://crrev.com/cf63a9a5e547087e23a0773e5875a1e2fa4331b1/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/cf63a9a5e547087e23a0773e5875a1e2fa4331b1/testing/buildbot/chromium.win.json
[modify] https://crrev.com/cf63a9a5e547087e23a0773e5875a1e2fa4331b1/tools/mb/mb_config.pyl

Project Member

Comment 15 by bugdroid1@chromium.org, Jun 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2aab097442f421ec9d878ff0fe6f7a5f1895d261

commit 2aab097442f421ec9d878ff0fe6f7a5f1895d261
Author: rsesek <rsesek@chromium.org>
Date: Fri Jun 24 18:49:47 2016

[Mac/GN] Add missing import //build/config/zip.gni after cf63a9a5e547.

BUG= 618468 
TBR=dpranke@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2098773003
Cr-Commit-Position: refs/heads/master@{#401914}

[modify] https://crrev.com/2aab097442f421ec9d878ff0fe6f7a5f1895d261/remoting/host/BUILD.gn

Project Member

Comment 16 by bugdroid1@chromium.org, Jun 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68ce3ab21aa4ed68e31716f7ef74e3db8fecd4b3

commit 68ce3ab21aa4ed68e31716f7ef74e3db8fecd4b3
Author: dpranke <dpranke@chromium.org>
Date: Fri Jun 24 21:10:40 2016

Flip 'Google Chrome Mac' on 'chromium.chrome' back to GYP.

Looks like we're still seeing issues w/ dump_syms.

R=rsesek@chromium.org
NOTRY=true
BUG= 618468 ,  622406 

Review-Url: https://codereview.chromium.org/2097963002
Cr-Commit-Position: refs/heads/master@{#401970}

[modify] https://crrev.com/68ce3ab21aa4ed68e31716f7ef74e3db8fecd4b3/tools/mb/mb_config.pyl

Project Member

Comment 17 by bugdroid1@chromium.org, Jun 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/bc901b5d3297a636c684b4311161f526bdeece98

commit bc901b5d3297a636c684b4311161f526bdeece98
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Jun 24 23:42:08 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/11582d2d7d07ac1409907a39ed823b68a9916271 Rename Mac/Win GN builders to GYP builders. (dpranke@chromium.org)

R=rsesek@chromium.org,dpranke@chromium.org
BUG= 605318 , 618468 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2097983003

[modify] https://crrev.com/bc901b5d3297a636c684b4311161f526bdeece98/infra/config/recipes.cfg

Project Member

Comment 18 by bugdroid1@chromium.org, Jun 25 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager.git/+/396b1c80fd917c93985b0b709508ea49447240d9

commit 396b1c80fd917c93985b0b709508ea49447240d9
Author: dpranke <dpranke@google.com>
Date: Sat Jun 25 00:00:03 2016

Project Member

Comment 19 by bugdroid1@chromium.org, Jun 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b067bb0848308067e35c24c7a39273e2861fb53

commit 7b067bb0848308067e35c24c7a39273e2861fb53
Author: dpranke <dpranke@chromium.org>
Date: Sun Jun 26 19:27:01 2016

Flip mac, win trunk builders on official.desktop.continuous to GN.

TBR=rsesek@chromium.org, brettw@chromium.org
BUG= 618468 ,  605318 

Review-Url: https://codereview.chromium.org/2099943002
Cr-Commit-Position: refs/heads/master@{#402084}

[modify] https://crrev.com/7b067bb0848308067e35c24c7a39273e2861fb53/tools/mb/mb_config.pyl

Project Member

Comment 20 by bugdroid1@chromium.org, Jun 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea1a899ae5ff3f17eca472de434541715c1bc44e

commit ea1a899ae5ff3f17eca472de434541715c1bc44e
Author: dpranke <dpranke@chromium.org>
Date: Sun Jun 26 20:23:56 2016

Revert of Flip mac, win trunk builders on official.desktop.continuous to GN. (patchset #1 id:1 of https://codereview.chromium.org/2099943002/ )

Reason for revert:
Reverting now that the official.desktop.continuous builders have picked up at least one build.

Original issue's description:
> Flip mac, win trunk builders on official.desktop.continuous to GN.
>
> TBR=rsesek@chromium.org, brettw@chromium.org
> BUG= 618468 ,  605318 
>
> Committed: https://crrev.com/7b067bb0848308067e35c24c7a39273e2861fb53
> Cr-Commit-Position: refs/heads/master@{#402084}

TBR=brettw@chromium.org,rsesek@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 618468 ,  605318 

Review-Url: https://codereview.chromium.org/2098253002
Cr-Commit-Position: refs/heads/master@{#402087}

[modify] https://crrev.com/ea1a899ae5ff3f17eca472de434541715c1bc44e/tools/mb/mb_config.pyl

Labels: -M-53
We don't need to flip *all* bots before M-53, so clearing this.
Blocking: -621679
Project Member

Comment 23 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/f7b7c2a06a5b09e56df379be5de85a926dc1e01a

commit f7b7c2a06a5b09e56df379be5de85a926dc1e01a
Author: dpranke <dpranke@chromium.org>
Date: Wed Jun 29 01:42:32 2016

Remove traces of removed Mac/Win GN builders.

R=martiniss@chromium.org, kjellander@chromium.org
BUG= 618468 ,  605318 

Review-Url: https://codereview.chromium.org/2097223002

[modify] https://crrev.com/f7b7c2a06a5b09e56df379be5de85a926dc1e01a/scripts/slave/recipe_modules/chromium_tests/chromium_mac.py
[modify] https://crrev.com/f7b7c2a06a5b09e56df379be5de85a926dc1e01a/scripts/slave/recipe_modules/chromium_tests/chromium_webrtc_fyi.py
[modify] https://crrev.com/f7b7c2a06a5b09e56df379be5de85a926dc1e01a/scripts/slave/recipe_modules/chromium_tests/chromium_win.py
[modify] https://crrev.com/f7b7c2a06a5b09e56df379be5de85a926dc1e01a/scripts/slave/recipe_modules/chromium_tests/trybots.py
[delete] https://crrev.com/193ba3f132e19d7d0dadd1657eae0bb1d5c7cf0b/scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_GN.json
[delete] https://crrev.com/193ba3f132e19d7d0dadd1657eae0bb1d5c7cf0b/scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_GN__dbg_.json
[modify] https://crrev.com/f7b7c2a06a5b09e56df379be5de85a926dc1e01a/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Mac_GN.json
[modify] https://crrev.com/f7b7c2a06a5b09e56df379be5de85a926dc1e01a/scripts/slave/recipes/chromium.expected/full_chromium_webrtc_fyi_Mac_GN__dbg_.json
[delete] https://crrev.com/193ba3f132e19d7d0dadd1657eae0bb1d5c7cf0b/scripts/slave/recipes/chromium.expected/full_chromium_win_Win8_Aura.json
[delete] https://crrev.com/193ba3f132e19d7d0dadd1657eae0bb1d5c7cf0b/scripts/slave/recipes/chromium.expected/full_chromium_win_Win8_GN__dbg_.json
[delete] https://crrev.com/193ba3f132e19d7d0dadd1657eae0bb1d5c7cf0b/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_gn_dbg.json
[delete] https://crrev.com/193ba3f132e19d7d0dadd1657eae0bb1d5c7cf0b/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_gn_rel.json
[delete] https://crrev.com/193ba3f132e19d7d0dadd1657eae0bb1d5c7cf0b/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win8_chromium_gn_dbg.json
[delete] https://crrev.com/193ba3f132e19d7d0dadd1657eae0bb1d5c7cf0b/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win8_chromium_ng.json
[modify] https://crrev.com/f7b7c2a06a5b09e56df379be5de85a926dc1e01a/tests/masters_recipes_test.py

Project Member

Comment 24 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1286dbd329b0669e082ffcebe3cb2b7fa47e438d

commit 1286dbd329b0669e082ffcebe3cb2b7fa47e438d
Author: dpranke <dpranke@chromium.org>
Date: Wed Jun 29 01:43:28 2016

Flip full, perf Mac and Win builders back to GYP.

This will give us a bit more test coverage prior to
the branch.

R=brettw@chromium.org
BUG= 618468 ,  605318 

Review-Url: https://codereview.chromium.org/2105043003
Cr-Commit-Position: refs/heads/master@{#402631}

[modify] https://crrev.com/1286dbd329b0669e082ffcebe3cb2b7fa47e438d/tools/mb/mb_config.pyl

Project Member

Comment 25 by bugdroid1@chromium.org, Jun 29 2016

Project Member

Comment 26 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6311f0fdc42799da33b9e28e6b784a1eda788aa0

commit 6311f0fdc42799da33b9e28e6b784a1eda788aa0
Author: dpranke <dpranke@chromium.org>
Date: Wed Jun 29 23:41:46 2016

Add Mac, Win builders back to the CQ for extra coverage.

Given that we're not going to ship GN-built Mac and Win
releases in M53, let's add some GYP coverage back to the
CQ; this'll make sure the targets the official builders
really need build, although we won't run any tests. We
should have capacity, but start with a 50% experiment for
now.

R=phajdan.jr@chromium.org, jam@chromium.org
BUG= 618468 ,  605318 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.mac:mac_chromium_gyp_rel;tryserver.chromium.win:win8_chromium_gyp_rel

Review-Url: https://codereview.chromium.org/2111463002
Cr-Commit-Position: refs/heads/master@{#402999}

[modify] https://crrev.com/6311f0fdc42799da33b9e28e6b784a1eda788aa0/BUILD.gn
[modify] https://crrev.com/6311f0fdc42799da33b9e28e6b784a1eda788aa0/build/all.gyp
[modify] https://crrev.com/6311f0fdc42799da33b9e28e6b784a1eda788aa0/infra/config/cq.cfg
[modify] https://crrev.com/6311f0fdc42799da33b9e28e6b784a1eda788aa0/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/6311f0fdc42799da33b9e28e6b784a1eda788aa0/testing/buildbot/chromium.win.json

Blocking: -431177
As suggested by laforge@ and a conversation w/ the monorail folks, I'm going to try tracking GN-Migration related issues by *just* using the Proj-GN-Migration label, and not using blocking/rollup bugs, so that we can use blocking for just tasks that truly need to be completed before other tasks can make progress.
Labels: -Pri-1 Pri-2
Project Member

Comment 29 by bugdroid1@chromium.org, Jul 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39a588cf27ffda8ac9f504c87d7f897342cf180e

commit 39a588cf27ffda8ac9f504c87d7f897342cf180e
Author: dpranke <dpranke@chromium.org>
Date: Fri Jul 01 01:52:21 2016

Bump mac_chromium_gyp_rel to 100% in CQ, fix typo for win8_chromium_gyp_rel.

TBR=jam@chromium.org
BUG= 605318 ,  618468 

Review-Url: https://codereview.chromium.org/2113893003
Cr-Commit-Position: refs/heads/master@{#403386}

[modify] https://crrev.com/39a588cf27ffda8ac9f504c87d7f897342cf180e/infra/config/cq.cfg

Comment 30 by kbr@chromium.org, Jul 7 2016

Blockedon: 626492
Project Member

Comment 31 by bugdroid1@chromium.org, Jul 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7d150aa0ad0c54760d5593ac04afee50e1e5286

commit f7d150aa0ad0c54760d5593ac04afee50e1e5286
Author: dpranke <dpranke@chromium.org>
Date: Mon Jul 11 23:19:59 2016

Flip remaining main Mac bots to GN.

This flips the remaining main Mac bots to GN, e.g.:

- chromium
  - Mac
- chromium.chrome
  - Google Mac
- chromium.perf
  - Mac Builder
- official.desktop
  - mac64
- official.desktop.continuous
  - mac trunk

There are various FYI and memory builders still, plus the GYP
builder on the chromium.mac waterfall.

R=rsesek@chromium.org
NOTRY=true
BUG= 618468 

Review-Url: https://codereview.chromium.org/2136293002
Cr-Commit-Position: refs/heads/master@{#404744}

[modify] https://crrev.com/f7d150aa0ad0c54760d5593ac04afee50e1e5286/tools/mb/mb_config.pyl

Project Member

Comment 32 by bugdroid1@chromium.org, Jul 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f746c62413f7db8758bb21750af0d98938f3308a

commit f746c62413f7db8758bb21750af0d98938f3308a
Author: dpranke <dpranke@chromium.org>
Date: Tue Jul 12 01:51:06 2016

Revert of Flip remaining main Mac bots to GN. (patchset #1 id:1 of https://codereview.chromium.org/2136293002/ )

Reason for revert:
"Mac" builder on /p/chromium fails follow-up ninja build claiming that things are dirty:

https://build.chromium.org/p/chromium/builders/Mac/builds/17564/steps/compile/logs/stdio

The official.desktop.continuous builder is breaking due to the missing remoting crashreporting link that I had thought I fixed but maybe forgot to land ...

Original issue's description:
> Flip remaining main Mac bots to GN.
>
> This flips the remaining main Mac bots to GN, e.g.:
>
> - chromium
>   - Mac
> - chromium.chrome
>   - Google Mac
> - chromium.perf
>   - Mac Builder
> - official.desktop
>   - mac64
> - official.desktop.continuous
>   - mac trunk
>
> There are various FYI and memory builders still, plus the GYP
> builder on the chromium.mac waterfall.
>
> R=rsesek@chromium.org
> NOTRY=true
> BUG= 618468 
>
> Committed: https://crrev.com/f7d150aa0ad0c54760d5593ac04afee50e1e5286
> Cr-Commit-Position: refs/heads/master@{#404744}

TBR=rsesek@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 618468 

Review-Url: https://codereview.chromium.org/2138313002
Cr-Commit-Position: refs/heads/master@{#404765}

[modify] https://crrev.com/f746c62413f7db8758bb21750af0d98938f3308a/tools/mb/mb_config.pyl

Project Member

Comment 33 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c2379b4b176151b174aba1d81b6cd0eb9e1e920

commit 5c2379b4b176151b174aba1d81b6cd0eb9e1e920
Author: dpranke <dpranke@chromium.org>
Date: Wed Jul 13 16:30:46 2016

Re-land r404744 - Flip remaining Mac bots to GN.

The issues w/ the remoting targets have been addressed, so let's
give this another try.

TBR=rsesek@chromium.org
BUG= 618468 

Review-Url: https://codereview.chromium.org/2143863002
Cr-Commit-Position: refs/heads/master@{#405185}

[modify] https://crrev.com/5c2379b4b176151b174aba1d81b6cd0eb9e1e920/tools/mb/mb_config.pyl

Project Member

Comment 34 by bugdroid1@chromium.org, Jul 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/944255248a81d03034cfaf5d12255557d64a6dea

commit 944255248a81d03034cfaf5d12255557d64a6dea
Author: dpranke <dpranke@chromium.org>
Date: Thu Jul 14 01:18:26 2016

Flip the /p/chromium Mac builder (and trybot) back to GYP.

Until we get the fix for the `sizes` regression rolled in, we
should flip this builder back to GYP to keep it green.

TBR=rsesek@chromium.org, thakis@chromium.org, danbeam@chromium.org
NOTRY=true
BUG= 628052 ,  618468 

Review-Url: https://codereview.chromium.org/2152633002
Cr-Commit-Position: refs/heads/master@{#405382}

[modify] https://crrev.com/944255248a81d03034cfaf5d12255557d64a6dea/tools/mb/mb_config.pyl

Project Member

Comment 35 by bugdroid1@chromium.org, Jul 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3b350b39b0f2f79881778f6c026ad7dd6c12432

commit d3b350b39b0f2f79881778f6c026ad7dd6c12432
Author: dpranke <dpranke@chromium.org>
Date: Thu Jul 21 18:41:12 2016

Flip many of the remaining Mac GYP builders to GN.

This flips most (but not all) of the remaining Mac GYP builders
to GN:

- chromium.fyi
  - Chromium Mac 10.10 MacViews
  - Chromium Mac 10.11
  - Chromium Mac 10.11 Force Mac Toolchain
  - Chromium Mac 10.9 Goma Canary
  - Chromium Mac 10.9 Goma Canary (clobber)
  - Chromium Mac 10.9 Goma Canary (dbg)
  - Chromium Mac 10.9 Goma Canary (dbg)(clobber)
  - ClangToTMac
  - ClangToTMac (dbg)
- tryserver.chromium.mac:
  - mac_chromium_10.10_macviews

There are still some GYP builders on chromium.perf and chromium.lkgr,
but this CL is big enough as-is.

R=rsesek@chromium.org
BUG= 618468 

Review-Url: https://codereview.chromium.org/2169683002
Cr-Commit-Position: refs/heads/master@{#406917}

[modify] https://crrev.com/d3b350b39b0f2f79881778f6c026ad7dd6c12432/tools/mb/mb_config.pyl

Project Member

Comment 36 by bugdroid1@chromium.org, Jul 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c1c668160041d18193336f519b1ba4d325cc6b1

commit 8c1c668160041d18193336f519b1ba4d325cc6b1
Author: dpranke <dpranke@chromium.org>
Date: Thu Jul 21 21:22:00 2016

Flip remaining Mac tryserver perf builders to GN.

This affects the folllowing builders on the tryserver.chromium.perf
waterfall:
  - mac_10_10_perf_bisect
  - mac_10_11_perf_bisect
  - mac_fyi_perf_bisect
  - mac_hdd_perf_bisect
  - mac_perf_bisect_builder
  - mac_retina_perf_bisect
  - mac_retina_perf_cq

R=rsesek@chromium.org
BUG= 618468 

Review-Url: https://codereview.chromium.org/2164963004
Cr-Commit-Position: refs/heads/master@{#406947}

[modify] https://crrev.com/8c1c668160041d18193336f519b1ba4d325cc6b1/tools/mb/mb_config.pyl

Project Member

Comment 37 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aff2a7f0744e477a728d0cacd467445df5b4d4e5

commit aff2a7f0744e477a728d0cacd467445df5b4d4e5
Author: dpranke <dpranke@chromium.org>
Date: Thu Jul 28 06:17:11 2016

Flip the last Mac GYP bots to GN (the ASAN bots):

This flips the remaining Mac builders to GN. A number of
browser_tests that use NaCl are failing under ASAN, so
we disable NaCl for now.

This affects:

- chromium.fyi
  - ClangToTMacASan
- chromium.lkgr
  - Mac ASAN Debug
  - Mac ASAN Release Media
  - Mac ASAN Release
- chromium.memory:
  - Mac ASAN 64 Builder
- tryserver.chromium.mac:
  - mac_chromium_asan_rel_ng

TBR=rsesek@chromium.org, brettw@chromium.org, jyasskin@chromium.org
BUG= 618468 ,  630322 , 632059
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_asan_rel_ng

Review-Url: https://codereview.chromium.org/2168713003
Cr-Commit-Position: refs/heads/master@{#408345}

[modify] https://crrev.com/aff2a7f0744e477a728d0cacd467445df5b4d4e5/chrome/chrome_tests.gypi
[modify] https://crrev.com/aff2a7f0744e477a728d0cacd467445df5b4d4e5/chrome/test/BUILD.gn
[modify] https://crrev.com/aff2a7f0744e477a728d0cacd467445df5b4d4e5/tools/mb/mb_config.pyl

Project Member

Comment 38 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/788943c15aa5614f8b34e1933d4c1b367e4656a2

commit 788943c15aa5614f8b34e1933d4c1b367e4656a2
Author: benwells <benwells@chromium.org>
Date: Thu Jul 28 07:00:53 2016

Revert of Flip the last Mac GYP bots to GN (the ASAN bots) (patchset #4 id:60001 of https://codereview.chromium.org/2168713003/ )

Reason for revert:
The Mac ASAN bot is not compiling after this.

Example stdio: https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Builder/builds/40502/steps/compile/logs/stdio

Original issue's description:
> Flip the last Mac GYP bots to GN (the ASAN bots):
>
> This flips the remaining Mac builders to GN. A number of
> browser_tests that use NaCl are failing under ASAN, so
> we disable NaCl for now.
>
> This affects:
>
> - chromium.fyi
>   - ClangToTMacASan
> - chromium.lkgr
>   - Mac ASAN Debug
>   - Mac ASAN Release Media
>   - Mac ASAN Release
> - chromium.memory:
>   - Mac ASAN 64 Builder
> - tryserver.chromium.mac:
>   - mac_chromium_asan_rel_ng
>
> TBR=rsesek@chromium.org, brettw@chromium.org, jyasskin@chromium.org
> BUG= 618468 ,  630322 , 632059
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_asan_rel_ng
>
> Committed: https://crrev.com/aff2a7f0744e477a728d0cacd467445df5b4d4e5
> Cr-Commit-Position: refs/heads/master@{#408345}

TBR=rsesek@chromium.org,brettw@chromium.org,jyasskin@chromium.org,kinuko@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 618468 ,  630322 , 632059

Review-Url: https://codereview.chromium.org/2184363003
Cr-Commit-Position: refs/heads/master@{#408348}

[modify] https://crrev.com/788943c15aa5614f8b34e1933d4c1b367e4656a2/chrome/chrome_tests.gypi
[modify] https://crrev.com/788943c15aa5614f8b34e1933d4c1b367e4656a2/chrome/test/BUILD.gn
[modify] https://crrev.com/788943c15aa5614f8b34e1933d4c1b367e4656a2/tools/mb/mb_config.pyl

Project Member

Comment 39 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c07d4e0af781b15ad65c50f8a9127d4ab5db01f

commit 8c07d4e0af781b15ad65c50f8a9127d4ab5db01f
Author: dpranke <dpranke@chromium.org>
Date: Thu Jul 28 17:32:42 2016

Re-land "Flip the last Mac GYP bots to GN (the ASAN bots)"

This re-lands r408345 with the needed fix to the Mac ASAN 64
Builder on chromium.memory (by turning off lsan).

TBR=rsesek@chromium.org
BUG= 618468 ,  630322 , 632059

Review-Url: https://codereview.chromium.org/2191473006
Cr-Commit-Position: refs/heads/master@{#408422}

[modify] https://crrev.com/8c07d4e0af781b15ad65c50f8a9127d4ab5db01f/chrome/chrome_tests.gypi
[modify] https://crrev.com/8c07d4e0af781b15ad65c50f8a9127d4ab5db01f/chrome/test/BUILD.gn
[modify] https://crrev.com/8c07d4e0af781b15ad65c50f8a9127d4ab5db01f/tools/mb/mb_config.pyl

Project Member

Comment 40 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b6e0b85322994b4e785f9bcbe3e6f7deda24b2e

commit 6b6e0b85322994b4e785f9bcbe3e6f7deda24b2e
Author: dpranke <dpranke@chromium.org>
Date: Thu Jul 28 21:32:34 2016

Flip two Mac ASAN straggler builders to GN and fix mb audit.

The addition of the internal.client.kitchensync builder broke
mb audit (which can't audit internal builders), so this skips
that, and toggles two builders that were supposed to be flipped
to GN but I mistyped things :).

TBR=rsesek@chromium.org
BUG= 618468 

Review-Url: https://codereview.chromium.org/2187393002
Cr-Commit-Position: refs/heads/master@{#408485}

[modify] https://crrev.com/6b6e0b85322994b4e785f9bcbe3e6f7deda24b2e/tools/mb/mb.py
[modify] https://crrev.com/6b6e0b85322994b4e785f9bcbe3e6f7deda24b2e/tools/mb/mb_config.pyl

Status: Fixed (was: Started)

Sign in to add a comment