New issue
Advanced search Search tips

Issue 618460 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 701965



Sign in to add a comment

OOPIF: Perform direct routing of mouse events when pointer is locked

Project Member Reported by lfg@chromium.org, Jun 8 2016

Issue description

RenderWidgetHostInputEventRouter should be made aware of mouse lock and directly route mouse events from the browser to the subframe, instead of using the forwarding code path from parent to subframe.

 

Comment 1 by lfg@chromium.org, Oct 13 2016

Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84763c90521d17f4b30d3abaa8af472b579a63ff

commit 84763c90521d17f4b30d3abaa8af472b579a63ff
Author: lfg <lfg@chromium.org>
Date: Thu Feb 16 18:55:15 2017

Perform direct routing of mouse events when the pointer is locked.

BUG= 618460 

Review-Url: https://codereview.chromium.org/2592243002
Cr-Commit-Position: refs/heads/master@{#451031}

[add] https://crrev.com/84763c90521d17f4b30d3abaa8af472b579a63ff/content/browser/pointer_lock_browsertest.cc
[add] https://crrev.com/84763c90521d17f4b30d3abaa8af472b579a63ff/content/browser/pointer_lock_browsertest.h
[add] https://crrev.com/84763c90521d17f4b30d3abaa8af472b579a63ff/content/browser/pointer_lock_browsertest_mac.mm
[modify] https://crrev.com/84763c90521d17f4b30d3abaa8af472b579a63ff/content/browser/renderer_host/render_widget_host_delegate.cc
[modify] https://crrev.com/84763c90521d17f4b30d3abaa8af472b579a63ff/content/browser/renderer_host/render_widget_host_delegate.h
[modify] https://crrev.com/84763c90521d17f4b30d3abaa8af472b579a63ff/content/browser/renderer_host/render_widget_host_input_event_router.cc
[modify] https://crrev.com/84763c90521d17f4b30d3abaa8af472b579a63ff/content/browser/renderer_host/render_widget_host_view_event_handler.cc
[modify] https://crrev.com/84763c90521d17f4b30d3abaa8af472b579a63ff/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/84763c90521d17f4b30d3abaa8af472b579a63ff/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/84763c90521d17f4b30d3abaa8af472b579a63ff/content/browser/web_contents/web_contents_view_aura.cc
[modify] https://crrev.com/84763c90521d17f4b30d3abaa8af472b579a63ff/content/browser/web_contents/web_contents_view_aura.h
[modify] https://crrev.com/84763c90521d17f4b30d3abaa8af472b579a63ff/content/browser/web_contents/web_contents_view_mac.h
[modify] https://crrev.com/84763c90521d17f4b30d3abaa8af472b579a63ff/content/browser/web_contents/web_contents_view_mac.mm
[modify] https://crrev.com/84763c90521d17f4b30d3abaa8af472b579a63ff/content/test/BUILD.gn

Comment 4 by lfg@chromium.org, Feb 16 2017

Status: Fixed (was: Started)

Comment 5 by kbr@chromium.org, Mar 16 2017

Blocking: 701965

Sign in to add a comment