New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 618459 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

Add a common class for Mojo tasks that run on a utility process.

Project Member Reported by pmonette@chromium.org, Jun 8 2016

Issue description

Right new, each users of UtilityProcessHost must manually take care of managing the utility process and connecting to the Mojo service.

This redundant work should be done by a common class to make it very easy to add new Mojo services that run on a utility process.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6f1ea1a8b2145019c3e7a7248ab1fc1d880b069

commit e6f1ea1a8b2145019c3e7a7248ab1fc1d880b069
Author: pmonette <pmonette@chromium.org>
Date: Fri Jun 17 22:14:21 2016

Add the UtilityProcessMojoClient class and convert SafeJsonParser

This class takes care of the mundane job of managing the utility process
lifetime and connecting to the remote Mojo service in an effort to make
it very easy to add new Mojo services that run on a utility process.

As a first example, SafeJsonParser is converted to use this class.

BUG= 618459 

Review-Url: https://codereview.chromium.org/2049303002
Cr-Commit-Position: refs/heads/master@{#400522}

[modify] https://crrev.com/e6f1ea1a8b2145019c3e7a7248ab1fc1d880b069/components/safe_json/safe_json_parser_impl.cc
[modify] https://crrev.com/e6f1ea1a8b2145019c3e7a7248ab1fc1d880b069/components/safe_json/safe_json_parser_impl.h
[modify] https://crrev.com/e6f1ea1a8b2145019c3e7a7248ab1fc1d880b069/content/browser/service_worker/service_worker_version_unittest.cc
[add] https://crrev.com/e6f1ea1a8b2145019c3e7a7248ab1fc1d880b069/content/browser/utility_process_mojo_client_browsertest.cc
[modify] https://crrev.com/e6f1ea1a8b2145019c3e7a7248ab1fc1d880b069/content/content_browser.gypi
[modify] https://crrev.com/e6f1ea1a8b2145019c3e7a7248ab1fc1d880b069/content/content_tests.gypi
[add] https://crrev.com/e6f1ea1a8b2145019c3e7a7248ab1fc1d880b069/content/public/browser/utility_process_mojo_client.h
[modify] https://crrev.com/e6f1ea1a8b2145019c3e7a7248ab1fc1d880b069/content/public/test/test_mojo_app.cc
[modify] https://crrev.com/e6f1ea1a8b2145019c3e7a7248ab1fc1d880b069/content/public/test/test_mojo_app.h
[modify] https://crrev.com/e6f1ea1a8b2145019c3e7a7248ab1fc1d880b069/content/public/test/test_mojo_service.mojom
[modify] https://crrev.com/e6f1ea1a8b2145019c3e7a7248ab1fc1d880b069/content/shell/renderer/shell_content_renderer_client.cc
[modify] https://crrev.com/e6f1ea1a8b2145019c3e7a7248ab1fc1d880b069/content/shell/utility/shell_content_utility_client.cc

Cc: j.iso...@samsung.com
Status: Fixed (was: Assigned)

Sign in to add a comment