Can you add a screencast of the bug? I'm not sure I follow the repro steps.

+Anthony and Moe as FYI

I have attached the screenshot of the advanced sync setting page which is not being displayed in M53 while signing in.

Deleted: sync_passphrase.JPG 74.4 KB

	sync_passphrase.JPG 74.4 KB View Download

Sorry, what do you mean it's not being displayed? The dialogue shouldn't be displayed automatically - it should only be displayed if you click "Settings" from the confirmation screen.

It would be helpful if you could get a screencast of the entire flow, so I could understand what the issue is.

Sorry, if I was not clear earlier. The advanced sync settings dialog is automatically displayed if the account is encrypted with passphrase. If there is no passphrase then it is not displayed.

M52 sign in flow:
Chrome Settings page--> Sign in to chrome --> Enter credentials --> advanced sync settings page displayed

M53 sign in flow:
Chrome Settings page--> Sign in to chrome --> Enter credentials --> "you're now signed in to Chrome dialog is displayed --> click "OK, GOT IT" --> Sign in completed (advanced sync settings dialog not displayed)

I will also try to get a screen recording of the sign in flow.

The M53 sign in flow you're describing is WAI and is the desired flow. You should see a sync error surface once you've signed in that prompts you to open the advanced settings page to enter your passphrase.

We don't want to skip the confirmation screen, since it has important text about how your data is used for personalization once you sign in.

So if anything, the behavior you're describing for the M52 sign in flow is a bug. However, I suspect it's because you aren't opted-in to the new sign in flow on your beta channel. If you go to chrome://flags/#enable-password-separated-signin-flow and turn that on, do you see the same behavior on M52 as you do on M53?

In M52 if custom passphrase is enabled then chrome opens sync settings right after sign-in flow, prompting for passphrase. It is hard to miss, user still has context about action that caused it.

In M53 user has an option to skip sync settings with "OK, GOT IT". In this state chrome doesn't sync most datatypes. User is notified with orange "stop" app menu badge (BadgeType::GLOBAL_ERROR, AppMenuIconPainter::SEVERITY_MEDIUM).
I think M53 flow makes it easier for users to get into not syncing state because they didn't enter passphrase.

Re #6: are you sure that's the behavior in M52, even with chrome://flags/#enable-password-separated-signin-flow enabled? I'm observing something different (specifically, we open the confirmation dialogue).

We shouldn't skip showing the confirmation dialogue. It gives relevant information to the user about sync and how their data is used for personalization. The confirmation dialogue links to the sync settings screen where the user can enter their passphrase. They also see the badge as you described, which the user can use to get to the right spot to enter their passphrase.

I agree there's a higher likelihood of users getting stuck in a state without syncing, but most users who have passphrases set probably understand what they need to do in order for sync to start, so I'm not too worried about it.

The behavior in M52 is same as on M53 if I enable  #enable-password-separated-signin-flow flag. So is this WAI in the new sign in flow?

Yes, this is WAI