go/chrome-desktop-fre-dd We are redesigning the first-run/onboarding experience for Chrome Desktop. This bug tracks eng efforts. Windows 10 is tracked separately as there are platform-specific issues to be addressed.
Will this also affect new profiles e.g. create a new profile from the profile switcher (not specifically a first run).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3f9c38e402ea28ea28cab54059ac52897ecc1b5 commit e3f9c38e402ea28ea28cab54059ac52897ecc1b5 Author: tmartino <tmartino@chromium.org> Date: Tue Sep 13 14:05:32 2016 Adding client code for new desktop First Run Experience. BUG= 618454 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2252063002 Cr-Commit-Position: refs/heads/master@{#418232} [modify] https://crrev.com/e3f9c38e402ea28ea28cab54059ac52897ecc1b5/chrome/app/chromium_strings.grd [modify] https://crrev.com/e3f9c38e402ea28ea28cab54059ac52897ecc1b5/chrome/app/generated_resources.grd [modify] https://crrev.com/e3f9c38e402ea28ea28cab54059ac52897ecc1b5/chrome/app/google_chrome_strings.grd [modify] https://crrev.com/e3f9c38e402ea28ea28cab54059ac52897ecc1b5/chrome/app/theme/chrome_unscaled_resources.grd [modify] https://crrev.com/e3f9c38e402ea28ea28cab54059ac52897ecc1b5/chrome/browser/browser_resources.grd [add] https://crrev.com/e3f9c38e402ea28ea28cab54059ac52897ecc1b5/chrome/browser/resources/welcome/welcome.css [add] https://crrev.com/e3f9c38e402ea28ea28cab54059ac52897ecc1b5/chrome/browser/resources/welcome/welcome.html [add] https://crrev.com/e3f9c38e402ea28ea28cab54059ac52897ecc1b5/chrome/browser/resources/welcome/welcome.js [modify] https://crrev.com/e3f9c38e402ea28ea28cab54059ac52897ecc1b5/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/e3f9c38e402ea28ea28cab54059ac52897ecc1b5/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc [add] https://crrev.com/e3f9c38e402ea28ea28cab54059ac52897ecc1b5/chrome/browser/ui/webui/welcome_ui.cc [add] https://crrev.com/e3f9c38e402ea28ea28cab54059ac52897ecc1b5/chrome/browser/ui/webui/welcome_ui.h [modify] https://crrev.com/e3f9c38e402ea28ea28cab54059ac52897ecc1b5/chrome/common/url_constants.cc [modify] https://crrev.com/e3f9c38e402ea28ea28cab54059ac52897ecc1b5/chrome/common/url_constants.h [modify] https://crrev.com/e3f9c38e402ea28ea28cab54059ac52897ecc1b5/ui/webui/resources/webui_resources.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f0818b0f710e64cb3fa7fab222850013a5438b0 commit 7f0818b0f710e64cb3fa7fab222850013a5438b0 Author: tmartino <tmartino@chromium.org> Date: Tue Sep 27 23:39:07 2016 Adding JS and C++ handlers for events on new Welcome page. BUG= 618454 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2338213007 Cr-Commit-Position: refs/heads/master@{#421385} [modify] https://crrev.com/7f0818b0f710e64cb3fa7fab222850013a5438b0/chrome/browser/resources/welcome/welcome.html [modify] https://crrev.com/7f0818b0f710e64cb3fa7fab222850013a5438b0/chrome/browser/resources/welcome/welcome.js [modify] https://crrev.com/7f0818b0f710e64cb3fa7fab222850013a5438b0/chrome/browser/ui/BUILD.gn [add] https://crrev.com/7f0818b0f710e64cb3fa7fab222850013a5438b0/chrome/browser/ui/webui/welcome_handler.cc [add] https://crrev.com/7f0818b0f710e64cb3fa7fab222850013a5438b0/chrome/browser/ui/webui/welcome_handler.h [modify] https://crrev.com/7f0818b0f710e64cb3fa7fab222850013a5438b0/chrome/browser/ui/webui/welcome_ui.cc [modify] https://crrev.com/7f0818b0f710e64cb3fa7fab222850013a5438b0/chrome/browser/ui/webui/welcome_ui.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b930f6e90137299cc399cd35bcf7e7f89c19587e commit b930f6e90137299cc399cd35bcf7e7f89c19587e Author: tmartino <tmartino@chromium.org> Date: Thu Oct 06 19:46:33 2016 Refactoring startup logic for upcoming FRE changes (non-Win 10). Refactor goals (in descending order): 1. Consolidate the various places throughout startup where onboarding and other special-case tabs are added. 2. Reduce the massive number of branches, spaghetti calls, and seemingly-redundant checks into a manageable, linear flow. 3. Offload all policy logic (e.g., "Should we show the Welcome page?") for FRE to the more-appropriate first_run directory. 4. Where possible, consolidate code into testable units. BUG= 618454 , 248883 , 517248 Review-Url: https://codereview.chromium.org/2164033002 Cr-Commit-Position: refs/heads/master@{#423636} [modify] https://crrev.com/b930f6e90137299cc399cd35bcf7e7f89c19587e/chrome/browser/first_run/first_run.cc [modify] https://crrev.com/b930f6e90137299cc399cd35bcf7e7f89c19587e/chrome/browser/first_run/first_run.h [modify] https://crrev.com/b930f6e90137299cc399cd35bcf7e7f89c19587e/chrome/browser/first_run/first_run_internal.h [modify] https://crrev.com/b930f6e90137299cc399cd35bcf7e7f89c19587e/chrome/browser/first_run/first_run_unittest.cc [modify] https://crrev.com/b930f6e90137299cc399cd35bcf7e7f89c19587e/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/b930f6e90137299cc399cd35bcf7e7f89c19587e/chrome/browser/ui/startup/startup_browser_creator.h [modify] https://crrev.com/b930f6e90137299cc399cd35bcf7e7f89c19587e/chrome/browser/ui/startup/startup_browser_creator_impl.cc [modify] https://crrev.com/b930f6e90137299cc399cd35bcf7e7f89c19587e/chrome/browser/ui/startup/startup_browser_creator_impl.h [add] https://crrev.com/b930f6e90137299cc399cd35bcf7e7f89c19587e/chrome/browser/ui/startup/startup_browser_creator_impl_unittest.cc [add] https://crrev.com/b930f6e90137299cc399cd35bcf7e7f89c19587e/chrome/browser/ui/startup/startup_features.cc [add] https://crrev.com/b930f6e90137299cc399cd35bcf7e7f89c19587e/chrome/browser/ui/startup/startup_features.h [modify] https://crrev.com/b930f6e90137299cc399cd35bcf7e7f89c19587e/chrome/browser/ui/startup/startup_tab.cc [modify] https://crrev.com/b930f6e90137299cc399cd35bcf7e7f89c19587e/chrome/browser/ui/startup/startup_tab.h [add] https://crrev.com/b930f6e90137299cc399cd35bcf7e7f89c19587e/chrome/browser/ui/startup/startup_tab_provider.cc [add] https://crrev.com/b930f6e90137299cc399cd35bcf7e7f89c19587e/chrome/browser/ui/startup/startup_tab_provider.h [add] https://crrev.com/b930f6e90137299cc399cd35bcf7e7f89c19587e/chrome/browser/ui/startup/startup_tab_provider_unittest.cc [modify] https://crrev.com/b930f6e90137299cc399cd35bcf7e7f89c19587e/chrome/test/BUILD.gn
[Automated comment] removing mislabelled merge-merged-2840
Can we mark this as Fixed, Tommy?
Comment 1 by wfh@chromium.org
, Jul 28 2016