[Sync] PSS::RequestStart should NotifyObservers if it changes the IsSyncRequested state |
||
Issue descriptionI saw this test flake locally and the lack of NotifyObservers call is the only explanation I can see for it, as AndroidSyncSettings doesn't update until that is called. C 779.822s Main [FAIL] org.chromium.chrome.browser.sync.SyncCustomizationFragmentTest#testSyncSwitch: C 779.822s Main junit.framework.AssertionFailedError C 779.822s Main at org.chromium.chrome.browser.sync.SyncCustomizationFragmentTest.testSyncSwitch(SyncCustomizationFragmentTest.java:118) C 779.823s Main at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214) C 779.823s Main at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199) C 779.823s Main at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192) C 779.823s Main at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:765) C 779.823s Main at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161) C 779.823s Main at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124) C 779.823s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) C 779.823s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) C 779.823s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555) C 779.823s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)
,
Jun 9 2016
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af4a59689fe719e5bf944a74cfdc7dcdcf147e8f commit af4a59689fe719e5bf944a74cfdc7dcdcf147e8f Author: maxbogue <maxbogue@chromium.org> Date: Thu Jun 09 18:31:22 2016 [Sync] Notify observers when IsSyncRequested goes from true to false. BUG= 618453 Review-Url: https://codereview.chromium.org/2047383004 Cr-Commit-Position: refs/heads/master@{#398950} [modify] https://crrev.com/af4a59689fe719e5bf944a74cfdc7dcdcf147e8f/components/browser_sync/browser/profile_sync_service.cc |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jun 9 2016