ClangToTLinuxASan broken after switching it to gn |
|||||
Issue descriptionhttps://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASan/builds/4303 [1822/41873] LINK ./gdb_rsp_unittest FAILED: gdb_rsp_unittest ../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -fuse-ld=gold -B../../third_party/binutils/Linux_x64/Release/bin -pthread -m64 -Wl,-O1 -Wl,--gc-sections --sysroot=../../build/linux/debian_wheezy_amd64-sysroot -L/b/build/slave/ClangToTLinuxASan/build/src/build/linux/debian_wheezy_amd64-sysroot/lib/x86_64-linux-gnu -Wl,-rpath-link=/b/build/slave/ClangToTLinuxASan/build/src/build/linux/debian_wheezy_amd64-sysroot/lib/x86_64-linux-gnu -L/b/build/slave/ClangToTLinuxASan/build/src/build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-rpath-link=/b/build/slave/ClangToTLinuxASan/build/src/build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu -L/b/build/slave/ClangToTLinuxASan/build/src/build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6 -Wl,-rpath-link=/b/build/slave/ClangToTLinuxASan/build/src/build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6 -L/b/build/slave/ClangToTLinuxASan/build/src/build/linux/debian_wheezy_amd64-sysroot/usr/lib -Wl,-rpath-link=/b/build/slave/ClangToTLinuxASan/build/src/build/linux/debian_wheezy_amd64-sysroot/usr/lib -fsanitize=address -fsanitize=leak -Wl,-rpath-link=../Release -Wl,--disable-new-dtags -Wl,-rpath=\$ORIGIN/. -Wl,-rpath-link=. -o "./gdb_rsp_unittest" -Wl,--start-group @"./gdb_rsp_unittest.rsp" -Wl,--end-group -ldl -lrt ../../native_client/src/trusted/debug_stub/packet_test.cc:98: error: undefined reference to 'std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::~basic_string()' ../../buildtools/third_party/libc++/trunk/include/string:3833: error: undefined reference to 'std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::compare(unsigned long, unsigned long, char const*, unsigned long) const' ../../buildtools/third_party/libc++/trunk/include/string:3833: error: undefined reference to 'std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::compare(unsigned long, unsigned long, char const*, unsigned long) const' etc I'm guessing linking this target is broken in all gn asan builds and no other bot happens to build this.
,
Jun 8 2016
Hmm. It's not obvious to me why that would be any different from any other binary, and it looks like other links are succeeding. I will look into it.
,
Jun 8 2016
Okay, the executable() target is missing the '//build/config/sanitizers:DEPS' target that all executables must have. Unfortunately, there's no way to ensure that every executable has a shared set of deps, so we have to play whack-a-mole looking for ones that are missing. Since you are prone to building `all`, you're likely going to hit cases we haven't hit elsewhere.
,
Jun 8 2016
,
Jun 8 2016
I'll try a build locally to see if I can tell how many others might have issues, but I can't promise that I'll have the cycles immediately to fix them all.
,
Jun 9 2016
,
Jun 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab0dbc05ac45f3719311267059447b0bc8292bc9 commit ab0dbc05ac45f3719311267059447b0bc8292bc9 Author: nacl-deps-roller <nacl-deps-roller@chromium.org> Date: Fri Jun 10 08:04:50 2016 Roll src/native_client/ f9308087f..5152c12c4 (1 commit). https://chromium.googlesource.com/native_client/src/native_client.git/+log/f9308087f764..5152c12c4477 $ git log f9308087f..5152c12c4 --date=short --no-merges --format='%ad %ae %s' 2016-06-09 dpranke Fix NaCL executable linkages under ASAN. BUG= 618450 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build TBR=mseaborn@chromium.org Review-Url: https://codereview.chromium.org/2052203002 Cr-Commit-Position: refs/heads/master@{#399134} [modify] https://crrev.com/ab0dbc05ac45f3719311267059447b0bc8292bc9/DEPS
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab0dbc05ac45f3719311267059447b0bc8292bc9 commit ab0dbc05ac45f3719311267059447b0bc8292bc9 Author: nacl-deps-roller <nacl-deps-roller@chromium.org> Date: Fri Jun 10 08:04:50 2016 Roll src/native_client/ f9308087f..5152c12c4 (1 commit). https://chromium.googlesource.com/native_client/src/native_client.git/+log/f9308087f764..5152c12c4477 $ git log f9308087f..5152c12c4 --date=short --no-merges --format='%ad %ae %s' 2016-06-09 dpranke Fix NaCL executable linkages under ASAN. BUG= 618450 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build TBR=mseaborn@chromium.org Review-Url: https://codereview.chromium.org/2052203002 Cr-Commit-Position: refs/heads/master@{#399134} [modify] https://crrev.com/ab0dbc05ac45f3719311267059447b0bc8292bc9/DEPS
,
Jun 21 2016
I believe this is fixed now ... |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by thakis@chromium.org
, Jun 8 2016