New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 618445 link

Starred by 3 users
Status: Fixed
Owner:
█ staraz@chromium.org
Last visit > 30 days ago
Closed: Jun 2016
Cc:
msw@chromium.org
█ mfomitchev@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Mustash: Move methods out of ChromeLauncherController

Project Member Reported by mfomitchev@chromium.org, Jun 8 2016 
Implementation of the three methods below methods doesn't rely on internal state, and can be moved out of ChromeLauncherController API, so that both ChromeLauncherControllerImpl and ChromeLauncherControllerMus can share this implementation.

- IsBrowserFromActiveUser
- GetExtensionForAppID
- GetPinnable

Comment 1 by mkrohn2...@apps4pps.net, Jun 8 2016 

YES
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 10 2016

Labels: FoundIn-M-53 OS-Windows Fracas
Users experienced this crash on the following builds:

Win Canary 53.0.2763.0 -  1.13 CPM, 20 reports, 17 clients (signature [Out of Memory] v8::internal::HandleScopeImplementer::GetSpareOrNewBlock)

If this update was incorrect, please add "Fracas-Wrong" label to prevent future updates.

- Go/Fracas

Comment 3 by mfomitchev@chromium.org, Jun 13 2016

Labels: -OS-Windows -FoundIn-M-53 Fracas-Wrong

Comment 4 by mfomitchev@chromium.org, Jun 17 2016

Cc: mfomitchev@chromium.org
Owner: staraz@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c77e2215c1a904b40ef05bf85cc865cf760b39d

commit 9c77e2215c1a904b40ef05bf85cc865cf760b39d
Author: staraz <staraz@chromium.org>
Date: Tue Jun 28 15:49:46 2016

Moved methods that don't rely on internal state out of ChromeLauncherController.

BUG= 618445 

Review-Url: https://codereview.chromium.org/2090133003
Cr-Commit-Position: refs/heads/master@{#402482}

[modify] https://crrev.com/9c77e2215c1a904b40ef05bf85cc865cf760b39d/chrome/browser/ui/app_list/app_list_controller_delegate.h
[modify] https://crrev.com/9c77e2215c1a904b40ef05bf85cc865cf760b39d/chrome/browser/ui/ash/app_list/app_list_controller_ash.cc
[modify] https://crrev.com/9c77e2215c1a904b40ef05bf85cc865cf760b39d/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc
[modify] https://crrev.com/9c77e2215c1a904b40ef05bf85cc865cf760b39d/chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc
[modify] https://crrev.com/9c77e2215c1a904b40ef05bf85cc865cf760b39d/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc
[modify] https://crrev.com/9c77e2215c1a904b40ef05bf85cc865cf760b39d/chrome/browser/ui/ash/launcher/browser_status_monitor.cc
[modify] https://crrev.com/9c77e2215c1a904b40ef05bf85cc865cf760b39d/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
[modify] https://crrev.com/9c77e2215c1a904b40ef05bf85cc865cf760b39d/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc
[modify] https://crrev.com/9c77e2215c1a904b40ef05bf85cc865cf760b39d/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
[modify] https://crrev.com/9c77e2215c1a904b40ef05bf85cc865cf760b39d/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
[modify] https://crrev.com/9c77e2215c1a904b40ef05bf85cc865cf760b39d/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
[modify] https://crrev.com/9c77e2215c1a904b40ef05bf85cc865cf760b39d/chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc
[modify] https://crrev.com/9c77e2215c1a904b40ef05bf85cc865cf760b39d/chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.h
[add] https://crrev.com/9c77e2215c1a904b40ef05bf85cc865cf760b39d/chrome/browser/ui/ash/launcher/chrome_launcher_controller_util.cc
[add] https://crrev.com/9c77e2215c1a904b40ef05bf85cc865cf760b39d/chrome/browser/ui/ash/launcher/chrome_launcher_controller_util.h
[modify] https://crrev.com/9c77e2215c1a904b40ef05bf85cc865cf760b39d/chrome/browser/ui/ash/launcher/launcher_context_menu.cc
[modify] https://crrev.com/9c77e2215c1a904b40ef05bf85cc865cf760b39d/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc
[modify] https://crrev.com/9c77e2215c1a904b40ef05bf85cc865cf760b39d/chrome/chrome_browser_ui.gypi

Comment 6 by staraz@chromium.org, Jun 28 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment