New issue
Advanced search Search tips

Issue 618444 link

Starred by 0 users
Status: Fixed
Owner:
atotic@chromium.org
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

testharnessreport.js should report testresults on failure

Project Member Reported by atotic@chromium.org, Jun 8 2016 
<b>Version: <Kenneth, what is the frequency?></b>
OS: All
What steps will reproduce the problem?
(1) Run some LayoutTests that use testharness and are failing

What is the expected output?
Harness Error. harness_status.status , harness_status.message =
FAIL: Test 1
FAIL: Test 2

What do you see instead?
Harness Error. harness_status.status , harness_status.message =

This happens because testharnessreport does not report test results when tests fail.

I've discovered this when debugging my new ResizeObserver test suite.
Got a fix, I'll send a CL.

Comment 1 by atotic@chromium.org, Jun 8 2016

Components: Blink>Infra

Comment 2 by atotic@chromium.org, Jun 8 2016 

testSuccess: what test looks like on success
testFail: what test currently looks like when test11 times out
testFailWithFix: what test looks like with bugfix when test11 times out
testSuccess.png
57.0 KB View Download
testFail.png
21.8 KB View Download
testFailWithFix.png
60.9 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efc66f4fe0e3cbc13539db5b2bd47f042d618605

commit efc66f4fe0e3cbc13539db5b2bd47f042d618605
Author: atotic <atotic@google.com>
Date: Fri Jun 10 19:04:01 2016

testharnessreport: Print test results even if a test didn't complete.

BUG= 618444 

Review-Url: https://codereview.chromium.org/2052643002
Cr-Commit-Position: refs/heads/master@{#399245}

[modify] https://crrev.com/efc66f4fe0e3cbc13539db5b2bd47f042d618605/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/media-elements/playing-the-media-resource/pause-remove-from-document-networkState-expected.txt
[modify] https://crrev.com/efc66f4fe0e3cbc13539db5b2bd47f042d618605/third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/scripting/events/inline-event-handler-ordering-expected.txt
[modify] https://crrev.com/efc66f4fe0e3cbc13539db5b2bd47f042d618605/third_party/WebKit/LayoutTests/imported/wpt/resources/testharnessreport.js
[modify] https://crrev.com/efc66f4fe0e3cbc13539db5b2bd47f042d618605/third_party/WebKit/LayoutTests/imported/wpt/shadow-dom/Document-prototype-currentScript-expected.txt
[modify] https://crrev.com/efc66f4fe0e3cbc13539db5b2bd47f042d618605/third_party/WebKit/LayoutTests/imported/wpt/webrtc/simplecall-expected.txt
[modify] https://crrev.com/efc66f4fe0e3cbc13539db5b2bd47f042d618605/third_party/WebKit/LayoutTests/resources/testharnessreport.js

Comment 4 by atotic@chromium.org, Jun 10 2016

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efc66f4fe0e3cbc13539db5b2bd47f042d618605

commit efc66f4fe0e3cbc13539db5b2bd47f042d618605
Author: atotic <atotic@google.com>
Date: Fri Jun 10 19:04:01 2016

testharnessreport: Print test results even if a test didn't complete.

BUG= 618444 

Review-Url: https://codereview.chromium.org/2052643002
Cr-Commit-Position: refs/heads/master@{#399245}

[modify] https://crrev.com/efc66f4fe0e3cbc13539db5b2bd47f042d618605/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/media-elements/playing-the-media-resource/pause-remove-from-document-networkState-expected.txt
[modify] https://crrev.com/efc66f4fe0e3cbc13539db5b2bd47f042d618605/third_party/WebKit/LayoutTests/imported/wpt/html/webappapis/scripting/events/inline-event-handler-ordering-expected.txt
[modify] https://crrev.com/efc66f4fe0e3cbc13539db5b2bd47f042d618605/third_party/WebKit/LayoutTests/imported/wpt/resources/testharnessreport.js
[modify] https://crrev.com/efc66f4fe0e3cbc13539db5b2bd47f042d618605/third_party/WebKit/LayoutTests/imported/wpt/shadow-dom/Document-prototype-currentScript-expected.txt
[modify] https://crrev.com/efc66f4fe0e3cbc13539db5b2bd47f042d618605/third_party/WebKit/LayoutTests/imported/wpt/webrtc/simplecall-expected.txt
[modify] https://crrev.com/efc66f4fe0e3cbc13539db5b2bd47f042d618605/third_party/WebKit/LayoutTests/resources/testharnessreport.js
►

Sign in to add a comment