ASSERT in ScriptPromiseResolver when play() is rejected immediately with an exception |
||
Issue descriptionOnly happens in the Debug build. The failing assert is here: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h?rcl=0&l=53 Seems to be caused by https://codereview.chromium.org/1865933002 To reproduce: - navigate to a page that tries to play() video without user gesture (for instance, https://avayvod.github.io/autoplay-test.html) - open Chrome settings and navigate through them OR: Chrome crashes with ASSERT after some time ER: Chrome doesn't crash ::playForBindings method doesn't use the resolver created for play() in the case of DOMException but retrieves its promise and doesn't detach it. Not a serious issue as it's just a sanity DCHECK in the dtor.
,
Jun 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08c6f401940f2b255514c1380ded3c01fc9f7fa2 commit 08c6f401940f2b255514c1380ded3c01fc9f7fa2 Author: avayvod <avayvod@chromium.org> Date: Thu Jun 09 15:19:06 2016 [Blink, HTMLMediaElement] Fix ASSERT in ScriptPromiseResolver dtor Don't get promise() from the resolver if it's not used. BUG= 618429 TEST=the test page from the bug. Review-Url: https://codereview.chromium.org/2047313004 Cr-Commit-Position: refs/heads/master@{#398887} [modify] https://crrev.com/08c6f401940f2b255514c1380ded3c01fc9f7fa2/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
,
Jun 9 2016
,
Jun 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1bb90f6b88a2555e3f7cc485bc46e9d61d1d2201 commit 1bb90f6b88a2555e3f7cc485bc46e9d61d1d2201 Author: mlamouri <mlamouri@chromium.org> Date: Thu Jun 09 23:09:24 2016 Test for bug 618429 . BUG= 618429 R=avayvod@chromium.org Review-Url: https://codereview.chromium.org/2048393002 Cr-Commit-Position: refs/heads/master@{#399047} [add] https://crrev.com/1bb90f6b88a2555e3f7cc485bc46e9d61d1d2201/third_party/WebKit/LayoutTests/media/play-promise-crash.html
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08c6f401940f2b255514c1380ded3c01fc9f7fa2 commit 08c6f401940f2b255514c1380ded3c01fc9f7fa2 Author: avayvod <avayvod@chromium.org> Date: Thu Jun 09 15:19:06 2016 [Blink, HTMLMediaElement] Fix ASSERT in ScriptPromiseResolver dtor Don't get promise() from the resolver if it's not used. BUG= 618429 TEST=the test page from the bug. Review-Url: https://codereview.chromium.org/2047313004 Cr-Commit-Position: refs/heads/master@{#398887} [modify] https://crrev.com/08c6f401940f2b255514c1380ded3c01fc9f7fa2/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1bb90f6b88a2555e3f7cc485bc46e9d61d1d2201 commit 1bb90f6b88a2555e3f7cc485bc46e9d61d1d2201 Author: mlamouri <mlamouri@chromium.org> Date: Thu Jun 09 23:09:24 2016 Test for bug 618429 . BUG= 618429 R=avayvod@chromium.org Review-Url: https://codereview.chromium.org/2048393002 Cr-Commit-Position: refs/heads/master@{#399047} [add] https://crrev.com/1bb90f6b88a2555e3f7cc485bc46e9d61d1d2201/third_party/WebKit/LayoutTests/media/play-promise-crash.html |
||
►
Sign in to add a comment |
||
Comment 1 by avayvod@chromium.org
, Jun 8 2016