New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 618428 link

Starred by 0 users
Status: Fixed
Owner:
█ weiran@google.com
Email to this user bounced
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

typos in offline pages code

Project Member Reported by weiran@google.com, Jun 8 2016 
Steps to reproduce the problem:
1. search for offlien
2. search for archvie
3. 

What is the expected behavior?

What went wrong?
misspell the word

Did this work before? N/A 

Chrome version: 51.0.2704.84  Channel: stable
OS Version: 
Flash Version: Shockwave Flash 21.0 r0

Comment 1 by fgor...@chromium.org, Jun 8 2016

Cc: weiran@google.com
Components: UI>Browser>Offline
Labels: -Pri-2 -Via-Wizard Pri-3
Owner: fgor...@chromium.org
Status: Assigned (was: Unconfirmed)
Vivian is going to be using this to fix some typos and get familiarized with the checkin process. Setting ownership to myself until Vivian gets bug edit access.

Comment 2 by fgor...@chromium.org, Jun 8 2016

Cc: -weiran@google.com
Owner: weiran@google.com
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 9 2016

Labels: Hotlist-Google
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97bba89beabbc04af9b905f2da79f519e93d88a4

commit 97bba89beabbc04af9b905f2da79f519e93d88a4
Author: weiran <weiran@google.com>
Date: Thu Jun 09 17:51:46 2016

Fix typos on offline pages

Fix "kOfflinePageArchviesDirname" to "kOfflineArchivesDirname" at line 58 in chrome_constants.h
Fix "OfflienPageArchiver" to "OfflinePageArchiver" at line 46 in recent_tab_helper.h

BUG= 618428 

Review-Url: https://codereview.chromium.org/2041233007
Cr-Commit-Position: refs/heads/master@{#398940}

[modify] https://crrev.com/97bba89beabbc04af9b905f2da79f519e93d88a4/chrome/browser/android/offline_pages/offline_page_model_factory.cc
[modify] https://crrev.com/97bba89beabbc04af9b905f2da79f519e93d88a4/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
[modify] https://crrev.com/97bba89beabbc04af9b905f2da79f519e93d88a4/chrome/browser/android/offline_pages/recent_tab_helper.h
[modify] https://crrev.com/97bba89beabbc04af9b905f2da79f519e93d88a4/chrome/browser/android/offline_pages/test_offline_page_model_builder.cc
[modify] https://crrev.com/97bba89beabbc04af9b905f2da79f519e93d88a4/chrome/browser/net/chrome_network_delegate.cc
[modify] https://crrev.com/97bba89beabbc04af9b905f2da79f519e93d88a4/chrome/common/chrome_constants.cc
[modify] https://crrev.com/97bba89beabbc04af9b905f2da79f519e93d88a4/chrome/common/chrome_constants.h

Comment 5 by weiran@google.com, Jun 10 2016

Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97bba89beabbc04af9b905f2da79f519e93d88a4

commit 97bba89beabbc04af9b905f2da79f519e93d88a4
Author: weiran <weiran@google.com>
Date: Thu Jun 09 17:51:46 2016

Fix typos on offline pages

Fix "kOfflinePageArchviesDirname" to "kOfflineArchivesDirname" at line 58 in chrome_constants.h
Fix "OfflienPageArchiver" to "OfflinePageArchiver" at line 46 in recent_tab_helper.h

BUG= 618428 

Review-Url: https://codereview.chromium.org/2041233007
Cr-Commit-Position: refs/heads/master@{#398940}

[modify] https://crrev.com/97bba89beabbc04af9b905f2da79f519e93d88a4/chrome/browser/android/offline_pages/offline_page_model_factory.cc
[modify] https://crrev.com/97bba89beabbc04af9b905f2da79f519e93d88a4/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
[modify] https://crrev.com/97bba89beabbc04af9b905f2da79f519e93d88a4/chrome/browser/android/offline_pages/recent_tab_helper.h
[modify] https://crrev.com/97bba89beabbc04af9b905f2da79f519e93d88a4/chrome/browser/android/offline_pages/test_offline_page_model_builder.cc
[modify] https://crrev.com/97bba89beabbc04af9b905f2da79f519e93d88a4/chrome/browser/net/chrome_network_delegate.cc
[modify] https://crrev.com/97bba89beabbc04af9b905f2da79f519e93d88a4/chrome/common/chrome_constants.cc
[modify] https://crrev.com/97bba89beabbc04af9b905f2da79f519e93d88a4/chrome/common/chrome_constants.h
►

Sign in to add a comment