Document //services/shell |
||
Issue descriptionAdd services/shell/README Revisit services/shell/public/cpp/shell_client.h services/shell/public/interfaces/shell.mojom services/shell/shell.h class Shell services/README.md Describe terms 'shell', 'instance', and provide context and examples of subclasses demonstrating what these concepts mean. There are loose design docs that should be referenced from the code. e.g. https://docs.google.com/document/d/1U7mcQ2o25KgXfEuJSIXQUpEF6Y9134ysaqSNUcmR-ZI/edit#heading=h.u4fykshye0eb https://docs.google.com/document/d/15I7sQyQo6zsqXVNAlVd520tdGaS8FCicZHrN0yRu-oU/edit#heading=h.p37l9e7o0io5
,
Jun 8 2016
I added a link to the Mojo Shell user guide from the mojo design doc page. While there probably should be a design doc describing the implementation of the Shell itself, I consider that a lower priority right now given how little there is to it. I'll eventually get around to it.
,
Jun 8 2016
Thanks, though I think the //services/ directory README warrants improvement.
,
Jun 8 2016
What's unclear?
,
Jun 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3009e4ca38a82a09f8202c5dd86ad5a9179e0a1c commit 3009e4ca38a82a09f8202c5dd86ad5a9179e0a1c Author: jam <jam@chromium.org> Date: Thu Jun 09 16:34:05 2016 Add pointers from README files in /services to documentation on the wiki and in docs. BUG= 618411 Review-Url: https://codereview.chromium.org/2049973002 Cr-Commit-Position: refs/heads/master@{#398906} [modify] https://crrev.com/3009e4ca38a82a09f8202c5dd86ad5a9179e0a1c/services/README.md [add] https://crrev.com/3009e4ca38a82a09f8202c5dd86ad5a9179e0a1c/services/shell/README.md
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3009e4ca38a82a09f8202c5dd86ad5a9179e0a1c commit 3009e4ca38a82a09f8202c5dd86ad5a9179e0a1c Author: jam <jam@chromium.org> Date: Thu Jun 09 16:34:05 2016 Add pointers from README files in /services to documentation on the wiki and in docs. BUG= 618411 Review-Url: https://codereview.chromium.org/2049973002 Cr-Commit-Position: refs/heads/master@{#398906} [modify] https://crrev.com/3009e4ca38a82a09f8202c5dd86ad5a9179e0a1c/services/README.md [add] https://crrev.com/3009e4ca38a82a09f8202c5dd86ad5a9179e0a1c/services/shell/README.md |
||
►
Sign in to add a comment |
||
Comment 1 by jam@chromium.org
, Jun 8 2016Owner: ben@chromium.org