New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 618388 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 610899



Sign in to add a comment

[Android] Unable to display the toolbar or bring up keyboard

Project Member Reported by joedow@chromium.org, Jun 8 2016

Issue description

We are receiving reports that users cannot display the toolbar or keyboard on the M49 android client release.  It looks like this is an intermittent problem which affects some devices more frequently than others.

We need to address this issue in the next release.
 

Comment 1 by joedow@chromium.org, Jun 13 2016

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9707b3db49ad29d458932a5940d5df10ff14416

commit e9707b3db49ad29d458932a5940d5df10ff14416
Author: joedow <joedow@chromium.org>
Date: Wed Jun 15 19:02:49 2016

Fixing Toolbar flakiness in Android client.

This change addresses the problems that some users have been seeing in
the auto-hiding toolbar in our Android app.  The auto-hide behavior
appears to work correctly until the user brings up the soft keyboard.
At this point the toolbar might be hidden but attempts to display the
toolbar again will fail.

We rely on System UI visibility events being fired to tell us when to
show or hide the Toolbar and in some cases these are not firing
consistently which is the root cause of the issues above.

This CL changes the way in which we update the System UI visibility when
the soft keyboard is displayed.  I removed the old logic which would
hide the ToolBar and System UI (and rely on the underlying OS to finish
hiding the System UI when the keyboard was dismissed) and moved it to
our Keyboard detection method.  Now we only hide the ActionBar when the
auto-hide timer fires and the soft keyboard is present and only call to
hide the System UI once the soft keyboard is dismissed.

This also solves a usability problem we had previously where the call to
hide the System UI would cause it to turn transparent which made finding
the dismiss KB button difficult when it was rendered over a white
background.

I've also added a method which is used when we resume the app which
checks the current System UI state and updates the ActionBar visibility
(and timer) to match.  This fixes some behavior I saw bring the app back
from a stopped state where the System UI and ActionBar were out of sync.

BUG= 618388 

Review-Url: https://codereview.chromium.org/2067093002
Cr-Commit-Position: refs/heads/master@{#399980}

[modify] https://crrev.com/e9707b3db49ad29d458932a5940d5df10ff14416/remoting/android/java/src/org/chromium/chromoting/Desktop.java
[modify] https://crrev.com/e9707b3db49ad29d458932a5940d5df10ff14416/remoting/android/java/src/org/chromium/chromoting/DesktopView.java

Comment 3 by joedow@chromium.org, Jun 15 2016

Owner: ajnolley@chromium.org
Status: Fixed (was: Started)
AJ, can you take a look and make sure I didn't regress anything?

I tested this change on JellyBean, KitKat, Lollipop, and Marshmallow (across Nexus 4,5,7 and Samsung S7 devices) so I'm pretty confident the behavior has been improved, but it would be good to verify :)

Comment 4 Deleted

Comment 5 Deleted

Verified fixed in 53.0.2783.5. The toolbar does autohide, the system UI can be called at this point, and the keyboard can be dismissed by hitting the back button. I found no regressions related to this. 

Sign in to add a comment