New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 618385 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 610899



Sign in to add a comment

[Android] Do not adjust remote desktop to fit screen on launch

Project Member Reported by joedow@chromium.org, Jun 8 2016

Issue description

In M49, I made a change to resize the canvas used to display the remote desktop so that it would fit on the client device's screen.  This works great if you have similarly sized desktops and a single monitor however it works very poorly for those with multiple monitors.  Based on a discussion with the rest of the team I think this behavior should be reverted.
 
Blocking: 610899
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b144cbc55799ed4e4105ea21f030d51e9897a715

commit b144cbc55799ed4e4105ea21f030d51e9897a715
Author: joedow <joedow@chromium.org>
Date: Fri Jun 10 05:01:46 2016

Updating initial zoom level for remote connections in Android Client.

This change updates the method used for sizing the remote desktop image
to the Android device's screen.  The previous method was to scale down
the remote image so that the entire image would fit.  This worked great
for similarly sized displays but not so great for high resolution or
multi-monitor displays.

The method I use now is to scale up the remote image (if needed) such
that there isn't any empty space on the screen.  I do this by
calculating the width and height ratios and scaling the image by the
larger of the two.  This ensures that the local screen is filled with
the image of the remote display and is similar to the behavior that
existed prior to my last change.  The viewport is then translated to the
upper left of the screen for the default starting position.

Once the image is resized and positioned, I update starting coordinates
for the cursor so it is placed in the center of the viewport area.

BUG= 618385 

Review-Url: https://codereview.chromium.org/2058543002
Cr-Commit-Position: refs/heads/master@{#399103}

[modify] https://crrev.com/b144cbc55799ed4e4105ea21f030d51e9897a715/remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java
[modify] https://crrev.com/b144cbc55799ed4e4105ea21f030d51e9897a715/remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java

Comment 3 by joedow@chromium.org, Jun 10 2016

Owner: ajnolley@chromium.org
Status: Fixed (was: Assigned)
Updated behavior is that we try to maximize the amount of local screen space.  If the remote desktop is smaller than the client dimensions in x/y/both then we will scale the image enough to ensure that the local screen is filled.

If the remote desktop is larger than the local display in both dimensions, we do not adjust the zoom level and leave the default image as-is.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b144cbc55799ed4e4105ea21f030d51e9897a715

commit b144cbc55799ed4e4105ea21f030d51e9897a715
Author: joedow <joedow@chromium.org>
Date: Fri Jun 10 05:01:46 2016

Updating initial zoom level for remote connections in Android Client.

This change updates the method used for sizing the remote desktop image
to the Android device's screen.  The previous method was to scale down
the remote image so that the entire image would fit.  This worked great
for similarly sized displays but not so great for high resolution or
multi-monitor displays.

The method I use now is to scale up the remote image (if needed) such
that there isn't any empty space on the screen.  I do this by
calculating the width and height ratios and scaling the image by the
larger of the two.  This ensures that the local screen is filled with
the image of the remote display and is similar to the behavior that
existed prior to my last change.  The viewport is then translated to the
upper left of the screen for the default starting position.

Once the image is resized and positioned, I update starting coordinates
for the cursor so it is placed in the center of the viewport area.

BUG= 618385 

Review-Url: https://codereview.chromium.org/2058543002
Cr-Commit-Position: refs/heads/master@{#399103}

[modify] https://crrev.com/b144cbc55799ed4e4105ea21f030d51e9897a715/remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java
[modify] https://crrev.com/b144cbc55799ed4e4105ea21f030d51e9897a715/remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java

Status: Verified (was: Fixed)
Verified in 53.0.2783.5

Sign in to add a comment