In general, the dart factories use many things that no other factory uses. I think it's the only waterfall that still uses:

* visual studio for building on windows (instead of ninja)
* xcodebuild for building on mac (instead of ninja)
* --clobber as parameter to compile.py instead of clobbering as a separate step (see  bug 574557 )

I want to remove support for these things from compile.py soon, so please update the dartium waterfalls so they don't break when I do.

OK, I'll file issues for these and start working on them.  The timeframe should be weeks, not days, but I'll prioritize these things.  I'll put links to the issues here, as I create them.

Now starting work on this.  Our Dartium builders are still not on recipes - I'm making a recipe for them now.  Expect progress next week.

I'm not sure if the chromium recipe will work to build dartium, or if I should just do a general gclient checkout and build recipe.  I'd love to get help on this, if someone can do a VC or email thread with me, who understands the Chromium compilation recipes.

Dartium builds are now on recipes, not using dart_factory.py.  I'll delete dart_factory in an upcoming CL.

Other aspects of compilation, that are in the chromium repos, not the infra repos, can be changed freely, because we have a branch of chromium src and blink, and will not be updating past version 50.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/fedd382eb821d2766ff835440d6017b357b7edff

commit fedd382eb821d2766ff835440d6017b357b7edff
Author: whesse <whesse@google.com>
Date: Fri Sep 09 07:56:23 2016

Remove old dartium_factory builders, clean up slaves.cfg files.

Also removes dartium_factory code and fixes a bug in dartium recipe.

BUG=https://bugs.chromium.org/p/chromium/issues/detail?id=618379

Review-Url: https://codereview.chromium.org/2324463003

[modify] https://crrev.com/fedd382eb821d2766ff835440d6017b357b7edff/masters/master.client.dart.fyi/master.cfg
[modify] https://crrev.com/fedd382eb821d2766ff835440d6017b357b7edff/masters/master.client.dart.fyi/slaves.cfg
[modify] https://crrev.com/fedd382eb821d2766ff835440d6017b357b7edff/masters/master.client.dart/master.cfg
[modify] https://crrev.com/fedd382eb821d2766ff835440d6017b357b7edff/masters/master.client.dart/slaves.cfg
[modify] https://crrev.com/fedd382eb821d2766ff835440d6017b357b7edff/scripts/master/factory/dart/dart_factory.py
[modify] https://crrev.com/fedd382eb821d2766ff835440d6017b357b7edff/scripts/slave/recipes/dart/dartium.expected/dartium-linux-x64-dev.json
[modify] https://crrev.com/fedd382eb821d2766ff835440d6017b357b7edff/scripts/slave/recipes/dart/dartium.expected/dartium-win-ia32-be.json
[modify] https://crrev.com/fedd382eb821d2766ff835440d6017b357b7edff/scripts/slave/recipes/dart/dartium.py

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/d9ae56d79e8af63baf7e53a298f6fe8b0226aab6

commit d9ae56d79e8af63baf7e53a298f6fe8b0226aab6
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Sep 09 08:03:49 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8592bf9cac021f55ab1c118d00d92964d316aa6d

commit 8592bf9cac021f55ab1c118d00d92964d316aa6d
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Sep 09 08:10:26 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/fedd382eb821d2766ff835440d6017b357b7edff Remove old dartium_factory builders, clean up slaves.cfg files. (whesse@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=https://bugs.chromium.org/p/chromium/issues/detail?id=618379

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2319223005
Cr-Commit-Position: refs/heads/master@{#417534}

[modify] https://crrev.com/8592bf9cac021f55ab1c118d00d92964d316aa6d/infra/config/recipes.cfg

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/80c451802bd6c6ab1ae876b121f0cd923670d611

commit 80c451802bd6c6ab1ae876b121f0cd923670d611
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Sep 09 08:41:15 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/fedd382eb821d2766ff835440d6017b357b7edff Remove old dartium_factory builders, clean up slaves.cfg files. (whesse@google.com)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=https://bugs.chromium.org/p/chromium/issues/detail?id=618379

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2319093005

[modify] https://crrev.com/80c451802bd6c6ab1ae876b121f0cd923670d611/infra/config/recipes.cfg

Ping - please provide an update to your high priority bug. This bug is stale. Is it really P-1?

What's the status of this?

None of the dartium bots use DartFactory anymore, so the dependence of DartFactory on ChromiumFactory can be removed.  I am tracing all the builders that use DartFactory, to see their paths through the DartFactory code and how it can be replaced by recipes, but none of them should be going into the code paths that use ChromiumFactory.

Some are using Gclient factory, but I ill remove that dependence by removing their dependence on DartFactory, so DartFactory can be deleted.

My first move will be to remove any dependence on ChromiumFactory, though.

CL https://chromium-review.googlesource.com/c/509616/ removes all uses on client.dart and client.fyi.

A followup CL will remove the client.dart.packages uses, and all factory dependencies and code from factory/dart/dart_factory.py.

The followup should land within a day or two.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/fe6ec6a7fc18ec92c3dd779d8a98f1111a3ebb60

commit fe6ec6a7fc18ec92c3dd779d8a98f1111a3ebb60
Author: William Hesse <whesse@chromium.org>
Date: Tue May 23 12:14:12 2017

Dart: Switch remaining builders to recipes

Remove mips builders and testers on FYI.

Bug:  618379 
Bug: 717557
Change-Id: I6310d41e81cf6ba6cc21866fd6d45e16ad1223d8
Reviewed-on: https://chromium-review.googlesource.com/509616
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[add] https://crrev.com/fe6ec6a7fc18ec92c3dd779d8a98f1111a3ebb60/scripts/slave/recipes/dart/misc.expected/pub-win-dev.json
[modify] https://crrev.com/fe6ec6a7fc18ec92c3dd779d8a98f1111a3ebb60/masters/master.client.dart/slaves.cfg
[modify] https://crrev.com/fe6ec6a7fc18ec92c3dd779d8a98f1111a3ebb60/masters/master.client.dart/master.cfg
[modify] https://crrev.com/fe6ec6a7fc18ec92c3dd779d8a98f1111a3ebb60/masters/master.client.dart.fyi/master.cfg
[add] https://crrev.com/fe6ec6a7fc18ec92c3dd779d8a98f1111a3ebb60/scripts/slave/recipes/dart/misc.py
[add] https://crrev.com/fe6ec6a7fc18ec92c3dd779d8a98f1111a3ebb60/scripts/slave/recipes/dart/misc.expected/androidvm-linux-be.json
[modify] https://crrev.com/fe6ec6a7fc18ec92c3dd779d8a98f1111a3ebb60/masters/master.client.dart.fyi/slaves.cfg

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/11694893e25daed08a1fcd62ae953ee9654b2b30

commit 11694893e25daed08a1fcd62ae953ee9654b2b30
Author: William Hesse <whesse@chromium.org>
Date: Tue May 30 08:49:41 2017

Dart: Switch package builders to recipes, delete DartFactory class

Bug:  618379 
Change-Id: I8c31efb5524ed3d3e3cf2c04d564d8cb2363f3cf
Reviewed-on: https://chromium-review.googlesource.com/517787
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: William Hesse <whesse@google.com>

[add] https://crrev.com/11694893e25daed08a1fcd62ae953ee9654b2b30/scripts/slave/recipes/dart/packagebot.expected/packages-linux-async.json
[modify] https://crrev.com/11694893e25daed08a1fcd62ae953ee9654b2b30/masters/master.client.dart.packages/master.cfg
[add] https://crrev.com/11694893e25daed08a1fcd62ae953ee9654b2b30/scripts/slave/recipes/dart/packagebot.py
[add] https://crrev.com/11694893e25daed08a1fcd62ae953ee9654b2b30/scripts/slave/recipes/dart/packagebot.expected/packages-windows-intl.json

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/10498fb56d317dae4301250480c55e7d251fbe00

commit 10498fb56d317dae4301250480c55e7d251fbe00
Author: William Hesse <whesse@chromium.org>
Date: Tue May 30 14:16:46 2017

Remove DartFactory and other unused code

There are no dependencies from factory/dart on other factory code
after this. There are still some utility functions in dart_factory.py
that are used by the masters, but they could be moved to any other
appropriate directory, if factory/dart should be deleted.

Bug:  618379 
Change-Id: I711237835f22056d72c7e5e34596f90b6a6b13b0
Reviewed-on: https://chromium-review.googlesource.com/518128
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>

[modify] https://crrev.com/10498fb56d317dae4301250480c55e7d251fbe00/scripts/slave/recipes/dart/packagebot.py
[delete] https://crrev.com/0f1cea68b64bca76d85bc4ff8c9293c2c7f0ef8d/scripts/master/factory/dart/dartino_factory.py
[modify] https://crrev.com/10498fb56d317dae4301250480c55e7d251fbe00/scripts/slave/recipes/dart/packagebot.expected/packages-linux-async.json
[modify] https://crrev.com/10498fb56d317dae4301250480c55e7d251fbe00/scripts/slave/recipes/dart/packagebot.expected/packages-windows-intl.json
[delete] https://crrev.com/0f1cea68b64bca76d85bc4ff8c9293c2c7f0ef8d/scripts/master/factory/dart/dart_commands.py
[modify] https://crrev.com/10498fb56d317dae4301250480c55e7d251fbe00/scripts/master/factory/dart/dart_factory.py
[modify] https://crrev.com/10498fb56d317dae4301250480c55e7d251fbe00/scripts/master/factory/dart/OWNERS

I believe this bug is fixed.  If the entire factory directory should be deleted, then we need to move the file factory/dart/dart_factory.py to a different place, since it contains utility functions (used by recipes, no non-recipe factories left).