New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 618377 link

Starred by 1 user
Status: Verified
Owner:
xiy...@chromium.org
Closed: Jun 2016
Cc:
█ mlight@chromium.org
█ sduraisamy@chromium.org
harpreet@chromium.org
█ jinzhang@chromium.org
█ asargent@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 574145



Sign in to add a comment

Enable "required_platform_version" manifest key on stable

Project Member Reported by xiy...@chromium.org, Jun 8 2016 
Following up work from  issue 577779 .

Launch bug: issue 574145

Comment 1 by xiy...@chromium.org, Jun 8 2016

Blocking: 574145
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1c093508327909789e7f4ef322a9c391fadf93a

commit f1c093508327909789e7f4ef322a9c391fadf93a
Author: xiyuan <xiyuan@chromium.org>
Date: Wed Jun 08 22:56:36 2016

kiosk: Enable required_platform_version key on stable

BUG= 618377 

Review-Url: https://codereview.chromium.org/2048433004
Cr-Commit-Position: refs/heads/master@{#398715}

[modify] https://crrev.com/f1c093508327909789e7f4ef322a9c391fadf93a/extensions/common/api/_manifest_features.json

Comment 3 by xiy...@chromium.org, Jun 8 2016

Labels: Merge-Request-52

Comment 4 by gkihumba@chromium.org, Jun 9 2016

Labels: Merge-Approved-52
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 9 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18d97d10a9e3ebd93ecc881d08800f51cb8d3ce4

commit 18d97d10a9e3ebd93ecc881d08800f51cb8d3ce4
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Thu Jun 09 17:36:56 2016

Merge "kiosk: Enable required_platform_version key on stable"

> BUG= 618377 
>
> Review-Url: https://codereview.chromium.org/2048433004
> Cr-Commit-Position: refs/heads/master@{#398715}
> (cherry picked from commit f1c093508327909789e7f4ef322a9c391fadf93a)

Review URL: https://codereview.chromium.org/2057673002 .

Cr-Commit-Position: refs/branch-heads/2743@{#294}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/18d97d10a9e3ebd93ecc881d08800f51cb8d3ce4/extensions/common/api/_manifest_features.json

Comment 6 by xiy...@chromium.org, Jun 9 2016

Status: Fixed (was: Assigned)

Comment 7 by tin...@google.com, Jun 10 2016

Labels: -Merge-Request-52 Merge-Review-52 Hotlist-Merge-Review
[Automated comment] There appears to be on-going work (i.e. bugroid changes), needs manual review.

Comment 8 by scunning...@chromium.org, Jun 12 2016

Cc: trapti@chromium.org
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18d97d10a9e3ebd93ecc881d08800f51cb8d3ce4

commit 18d97d10a9e3ebd93ecc881d08800f51cb8d3ce4
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Thu Jun 09 17:36:56 2016

Merge "kiosk: Enable required_platform_version key on stable"

> BUG= 618377 
>
> Review-Url: https://codereview.chromium.org/2048433004
> Cr-Commit-Position: refs/heads/master@{#398715}
> (cherry picked from commit f1c093508327909789e7f4ef322a9c391fadf93a)

Review URL: https://codereview.chromium.org/2057673002 .

Cr-Commit-Position: refs/branch-heads/2743@{#294}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/18d97d10a9e3ebd93ecc881d08800f51cb8d3ce4/extensions/common/api/_manifest_features.json

Comment 10 by scunning...@chromium.org, Jun 28 2016

Cc: -trapti@chromium.org harpreet@chromium.org mlight@chromium.org

Comment 11 by mlight@google.com, Aug 15 2016 

Verified in M52-Stable, build 8350.68.0, chromeos 52.0.2743.116

Comment 12 by mlight@google.com, Aug 15 2016

Status: Verified (was: Fixed)

Comment 13 by xiy...@chromium.org, Jun 29 2017

Labels: -Hotlist-Merge-Review -Merge-Review-52
►

Sign in to add a comment