New issue
Advanced search Search tips

Issue 618366 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature


Sign in to add a comment

Run external/wpt/ layout tests with wptserve enabled by default.

Project Member Reported by qyears...@chromium.org, Jun 8 2016

Issue description

This issue is about running run-webkit-tests with wptserve enabled on the waterfall by default.

We've talked about this in other bugs, but there didn't seem to be one issue focused on this before.

Proposal doc for discussion: https://docs.google.com/document/d/1JinZeWOA6vn--jLFjwDiAiTcFhYa3EMRhBzVOLh_3Rc/edit#
 
The first step in this process was to set up the FYI bots, which are now set up; so far, this has revealed to us that we need more work before Windows works with --enable-wptserve.

Current state of the FYI bots can be seen at:
https://build.chromium.org/p/chromium.fyi/waterfall?show=WebKit%20Linux%20-%20WPTServe&show=WebKit%20Mac%20-%20WPTServe&show=WebKit%20Win%20-%20WPTServe
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/489b7e668259f3e433af13eae79a018bc78beca1

commit 489b7e668259f3e433af13eae79a018bc78beca1
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Jun 29 23:40:11 2016

Rename functions in Port related to wptserve and add a helper function.

This is a refactoring CL which should cause no behavior changes.

In this CL:
 (1) Rename is_wpt_enabled -> is_wptserve_enabled
 (2) Rename is_wpt_test -> is_wptserve_test
 (3) Add should_use_wptserve (= is_wptserve enabled and is_wptserve_test).

The rational for (2) is that many (most) tests in imported/wpt behave the
same if they're run with wptserve and with file://; only a smallish number
of the tests behave differently. It may be faster to run the tests if we
only use wptserve for the tests that require it; so later we may want
to change is_wptserve_test to check some things, e.g. wptserve header
files in the directory; or ".http." or ".https."  in the file name.

BUG= 618366 

Review-Url: https://codereview.chromium.org/2110823002
Cr-Commit-Position: refs/heads/master@{#402997}

[modify] https://crrev.com/489b7e668259f3e433af13eae79a018bc78beca1/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
[modify] https://crrev.com/489b7e668259f3e433af13eae79a018bc78beca1/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
[modify] https://crrev.com/489b7e668259f3e433af13eae79a018bc78beca1/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
[modify] https://crrev.com/489b7e668259f3e433af13eae79a018bc78beca1/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py

Cc: -raikiri@google.com -dcampb@google.com

Comment 4 by tkent@chromium.org, Oct 13 2016

Blockedon: 627008

Comment 5 by tkent@chromium.org, Oct 13 2016

Blockedon: 623613

Comment 6 by tkent@chromium.org, Nov 7 2016

Owner: tkent@chromium.org
Status: Started (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed7b4330f51b10e91f8ab32e935ee2c07ad1cdc6

commit ed7b4330f51b10e91f8ab32e935ee2c07ad1cdc6
Author: tkent <tkent@chromium.org>
Date: Tue Nov 08 00:20:25 2016

wptserve: Don't use copies of testharnessreport.js and vendor-prefix.js.

wptserve has the alias feature, and we can map files in LayoutTests/resources/
to web-platform.test/{common,resources}/* without copying.

BUG= 618366 

Review-Url: https://codereview.chromium.org/2480143002
Cr-Commit-Position: refs/heads/master@{#430437}

[modify] https://crrev.com/ed7b4330f51b10e91f8ab32e935ee2c07ad1cdc6/third_party/WebKit/LayoutTests/PRESUBMIT.py
[modify] https://crrev.com/ed7b4330f51b10e91f8ab32e935ee2c07ad1cdc6/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt.config.json
[modify] https://crrev.com/ed7b4330f51b10e91f8ab32e935ee2c07ad1cdc6/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/311d6ccdab758c38b0394a06d054a4db15a5fa21

commit 311d6ccdab758c38b0394a06d054a4db15a5fa21
Author: tkent <tkent@chromium.org>
Date: Thu Nov 10 04:54:09 2016

wptserve: Enable WPTServe by default.

Feel free to revert this if you see stability issues of imported/wpt tests in
webkit_tests step.

BUG= 618366 

Review-Url: https://codereview.chromium.org/2482793002
Cr-Commit-Position: refs/heads/master@{#431186}

[modify] https://crrev.com/311d6ccdab758c38b0394a06d054a4db15a5fa21/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05bb9406c894324faea17e0b4cc78bcfffafcff4

commit 05bb9406c894324faea17e0b4cc78bcfffafcff4
Author: dpranke <dpranke@chromium.org>
Date: Thu Nov 10 17:54:32 2016

Revert of wptserve: Enable WPTServe by default. (patchset #1 id:1 of https://codereview.chromium.org/2482793002/ )

Reason for revert:

I'm reverting this because I think

imported/wpt/html/browsers/history/the-location-interface/reload_post_1.html

started failing with the switch on windows, see

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/8056

and I'm the sheriff today.

However, I'm also concerned that I think you missed my comments in #10. I don't think a 30% cycle time regression is okay,
at least not without an explanation and a plan for addressing it.

Original issue's description:
> wptserve: Enable WPTServe by default.
>
> Feel free to revert this if you see stability issues of imported/wpt tests in
> webkit_tests step.
>
> BUG= 618366 
>
> Committed: https://crrev.com/311d6ccdab758c38b0394a06d054a4db15a5fa21
> Cr-Commit-Position: refs/heads/master@{#431186}

TBR=qyearsley@chromium.org,jsbell@chromium.org,tkent@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 618366 

Review-Url: https://codereview.chromium.org/2495613002
Cr-Commit-Position: refs/heads/master@{#431285}

[modify] https://crrev.com/05bb9406c894324faea17e0b4cc78bcfffafcff4/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

Comment 10 by tkent@chromium.org, Nov 14 2016

Copied from https://codereview.chromium.org/2482793002/#msg30:

The following data shows webkit_tests time of five runs before/after enabling WTPServe.
Roughly speaking, +1 minute in release build, +3 minutes in debug build.  I think they are acceptable.


WebKit Win7
BEFORE: 22:58 22:41 23:12 22:44 23:03 median=22:58 avg=22:55
AFTER:  25:09 24:48 23:27 24:52 24:49 median=24:49 avg=24:37

WebKit Win7 (dbg)
BEFORE: 1:42:54 1:43:20 1:45:29 1:43:58 1:42:38 median=1:43:20 avg=1:43:40
AFTER:  1:49:43 1:47:31 1:46:21 1:40:52 1:43:18 median=1:46:21 avg=1:45:33

WebKit Mac10.11
BEFORE: 18:25 18:43 18:15 17:46 17:47 median=18:15 avg=18:11
AFTER:  17:45 18:56 19:40 19:21 19:22 median=18:56 avg=19:00

WebKit Mac 10.11 (dbg)
BEFORE: 1:04:34 1:04:34 1:04:02 1:02:44 1:04:49 median=1:04:34 avg=1:04:09
AFTER : 1:02:23 1:06:40 1:04:52 1:07:07 1:04:46 median=1:04:52 avg=1:05:10


WebKit Linux Precise
BEFORE: 17:13 16:53 17:03 16:54 17:14 median=17:03 avg=17:03
AFTER:  17:54 17:36 17:51 17:43 18:28 median=17:51 avg=17:54

WebKit Linux Precise (dbg)
BEFORE: 1:26:47 1:27:29 1:25:37 1:26:46 1:27:03 median=1:26:47 avg=1:26:44
AFTER:  1:29:07 1:30:58 1:27:03 1:30:07 1:29:41 median=1:29:41 avg=1:29:23

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/340ad8ad4eceb6603867b1fc3f9b3b295d76d79d

commit 340ad8ad4eceb6603867b1fc3f9b3b295d76d79d
Author: tkent <tkent@chromium.org>
Date: Mon Nov 14 03:17:44 2016

Reland of wptserve: Enable WPTServe by default. (patchset #1 id:1 of https://codereview.chromium.org/2495613002/ )

Reason for revert:
The issue was resolved.  Try to reland without any changes.

Original issue's description:
> Revert of wptserve: Enable WPTServe by default. (patchset #1 id:1 of https://codereview.chromium.org/2482793002/ )
>
> Reason for revert:
>
> I'm reverting this because I think
>
> imported/wpt/html/browsers/history/the-location-interface/reload_post_1.html
>
> started failing with the switch on windows, see
>
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/8056
>
> and I'm the sheriff today.
>
> However, I'm also concerned that I think you missed my comments in #10. I don't think a 30% cycle time regression is okay,
> at least not without an explanation and a plan for addressing it.
>
> Original issue's description:
> > wptserve: Enable WPTServe by default.
> >
> > Feel free to revert this if you see stability issues of imported/wpt tests in
> > webkit_tests step.
> >
> > BUG= 618366 
> >
> > Committed: https://crrev.com/311d6ccdab758c38b0394a06d054a4db15a5fa21
> > Cr-Commit-Position: refs/heads/master@{#431186}
>
> TBR=qyearsley@chromium.org,jsbell@chromium.org,tkent@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 618366 
>
> Committed: https://crrev.com/05bb9406c894324faea17e0b4cc78bcfffafcff4
> Cr-Commit-Position: refs/heads/master@{#431285}

TBR=jsbell@chromium.org,qyearsley@chromium.org,dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 618366 

Review-Url: https://codereview.chromium.org/2497193002
Cr-Commit-Position: refs/heads/master@{#431820}

[modify] https://crrev.com/340ad8ad4eceb6603867b1fc3f9b3b295d76d79d/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

Comment 12 by tkent@chromium.org, Nov 14 2016

Blocking: 664935

Comment 13 by tkent@chromium.org, Nov 16 2016

Looks enabling WPTServe didn't cause any issues except the slight performance degradation.  I'll start code cleanup.

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5ce7e0a17e32d6d145124938a90220e9f9990c5

commit b5ce7e0a17e32d6d145124938a90220e9f9990c5
Author: dpranke <dpranke@chromium.org>
Date: Wed Nov 30 03:33:20 2016

Revert of wptserve: Enable WPTServe by default. (patchset #1 id:1 of https://codereview.chromium.org/2497193002/ )

Reason for revert:
I suspect that the startup/shutdown logic in wptserve is not right, and we're seeing intermittent failures where we're hanging trying to start wptserve.

See crbug.com/669194 and https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/builds/13447/steps/webkit_tests/logs/stdio for an example.

I'm speculatively reverting this for now, to see if things become happier.

Original issue's description:
> Reland of wptserve: Enable WPTServe by default.

TBR=qyearsley@chromium.org,jsbell@chromium.org,tkent@chromium.org
NOTRY=true
NOPRESUBMIT=true
BUG= 618366 

Review-Url: https://codereview.chromium.org/2537413002
Cr-Commit-Position: refs/heads/master@{#435129}

[modify] https://crrev.com/b5ce7e0a17e32d6d145124938a90220e9f9990c5/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

Blocking: 653514
Components: Blink>Infra>Predictability
Components: -Blink>Infra
Blocking: 678847
Alright, I think the next step is to try relanding the enabling of wptserve by default again, right? Some test expectations will have to be updated, but maybe the easiest way to handle that is to make the reland CL, try layout tests, and then modify TestExpectations (and possibly download some new baselines?) in that same CL.

tkent@, does that sound like the right way?
Project Member

Comment 20 by bugdroid1@chromium.org, Jan 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f42814819c6318c4b6f9148f3fb9aa245f08257

commit 3f42814819c6318c4b6f9148f3fb9aa245f08257
Author: tkent <tkent@chromium.org>
Date: Mon Jan 16 02:22:30 2017

Update WPTServeExpectations to prepare enabling WPTServe by default.

TBR=qyearsley@chromium.org
NOTRY=true
BUG= 618366 

Review-Url: https://codereview.chromium.org/2632123002
Cr-Commit-Position: refs/heads/master@{#443831}

[modify] https://crrev.com/3f42814819c6318c4b6f9148f3fb9aa245f08257/third_party/WebKit/LayoutTests/WPTServeExpectations

Project Member

Comment 21 by bugdroid1@chromium.org, Jan 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01c97b5106a69c02931e5aee55e460e1e7eb398a

commit 01c97b5106a69c02931e5aee55e460e1e7eb398a
Author: tkent <tkent@chromium.org>
Date: Mon Jan 16 22:26:44 2017

Reland of wptserve: Enable WPTServe by default. (patchset #1 id:1 of https://codereview.chromium.org/2537413002/ )

Reason for revert:
The problem was resolved.

Original issue's description:
> Revert of wptserve: Enable WPTServe by default. (patchset #1 id:1 of https://codereview.chromium.org/2497193002/ )
>
> Reason for revert:
> I suspect that the startup/shutdown logic in wptserve is not right, and we're seeing intermittent failures where we're hanging trying to start wptserve.
>
> See crbug.com/669194 and https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/builds/13447/steps/webkit_tests/logs/stdio for an example.
>
> I'm speculatively reverting this for now, to see if things become happier.
>
> Original issue's description:
> > Reland of wptserve: Enable WPTServe by default.
>
> TBR=qyearsley@chromium.org,jsbell@chromium.org,tkent@chromium.org
> NOTRY=true
> NOPRESUBMIT=true
> BUG= 618366 
>
> Committed: https://crrev.com/b5ce7e0a17e32d6d145124938a90220e9f9990c5
> Cr-Commit-Position: refs/heads/master@{#435129}

TBR=qyearsley@chromium.org,jsbell@chromium.org,dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 618366 

Review-Url: https://codereview.chromium.org/2633083002
Cr-Commit-Position: refs/heads/master@{#443953}

[modify] https://crrev.com/01c97b5106a69c02931e5aee55e460e1e7eb398a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

Project Member

Comment 22 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0524c631c52912ac91c931e720cac0c6330c850e

commit 0524c631c52912ac91c931e720cac0c6330c850e
Author: tkent <tkent@chromium.org>
Date: Thu Jan 19 04:22:40 2017

Remove Failure entries for tests which pass with WPTServe.

BUG= 618366 

Review-Url: https://codereview.chromium.org/2643633002
Cr-Commit-Position: refs/heads/master@{#444640}

[modify] https://crrev.com/0524c631c52912ac91c931e720cac0c6330c850e/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 23 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd1f56eef55c9a57303453e7a4c9e1c09b241971

commit bd1f56eef55c9a57303453e7a4c9e1c09b241971
Author: tkent <tkent@chromium.org>
Date: Thu Jan 19 06:07:25 2017

Rebaseline of tests which changed their behavior during disabling WPTServe

BUG= 618366 

Review-Url: https://codereview.chromium.org/2648473002
Cr-Commit-Position: refs/heads/master@{#444660}

[modify] https://crrev.com/bd1f56eef55c9a57303453e7a4c9e1c09b241971/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/bd1f56eef55c9a57303453e7a4c9e1c09b241971/third_party/WebKit/LayoutTests/WPTServeExpectations
[modify] https://crrev.com/bd1f56eef55c9a57303453e7a4c9e1c09b241971/third_party/WebKit/LayoutTests/external/wpt/domparsing/DOMParser-parseFromString-html-expected.txt
[modify] https://crrev.com/bd1f56eef55c9a57303453e7a4c9e1c09b241971/third_party/WebKit/LayoutTests/external/wpt/domparsing/DOMParser-parseFromString-xml-expected.txt
[modify] https://crrev.com/bd1f56eef55c9a57303453e7a4c9e1c09b241971/third_party/WebKit/LayoutTests/external/wpt/html/dom/reflection-obsolete-expected.txt
[add] https://crrev.com/bd1f56eef55c9a57303453e7a4c9e1c09b241971/third_party/WebKit/LayoutTests/external/wpt/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/dynamic-append-expected.txt
[add] https://crrev.com/bd1f56eef55c9a57303453e7a4c9e1c09b241971/third_party/WebKit/LayoutTests/external/wpt/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/not-in-shadow-tree-expected.txt
[modify] https://crrev.com/bd1f56eef55c9a57303453e7a4c9e1c09b241971/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/scripting/events/messageevent-constructor.https-expected.txt
[modify] https://crrev.com/bd1f56eef55c9a57303453e7a4c9e1c09b241971/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/scripting/processing-model-2/compile-error-same-origin-with-hash-expected.txt
[modify] https://crrev.com/bd1f56eef55c9a57303453e7a4c9e1c09b241971/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/scripting/processing-model-2/runtime-error-same-origin-with-hash-expected.txt
[modify] https://crrev.com/bd1f56eef55c9a57303453e7a4c9e1c09b241971/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/serviceworker/cache-add.https-expected.txt
[modify] https://crrev.com/bd1f56eef55c9a57303453e7a4c9e1c09b241971/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/serviceworker/cache-matchAll.https-expected.txt
[add] https://crrev.com/bd1f56eef55c9a57303453e7a4c9e1c09b241971/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/serviceworker/cache-put.https-expected.txt
[modify] https://crrev.com/bd1f56eef55c9a57303453e7a4c9e1c09b241971/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/window/cache-add.https-expected.txt
[add] https://crrev.com/bd1f56eef55c9a57303453e7a4c9e1c09b241971/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/window/cache-put.https-expected.txt
[modify] https://crrev.com/bd1f56eef55c9a57303453e7a4c9e1c09b241971/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/worker/cache-add.https-expected.txt
[add] https://crrev.com/bd1f56eef55c9a57303453e7a4c9e1c09b241971/third_party/WebKit/LayoutTests/external/wpt/service-workers/cache-storage/worker/cache-put.https-expected.txt
[add] https://crrev.com/bd1f56eef55c9a57303453e7a4c9e1c09b241971/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/extendable-event-async-waituntil.https-expected.txt
[modify] https://crrev.com/bd1f56eef55c9a57303453e7a4c9e1c09b241971/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-event.https-expected.txt
[modify] https://crrev.com/bd1f56eef55c9a57303453e7a4c9e1c09b241971/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-request-fallback.https-expected.txt
[modify] https://crrev.com/bd1f56eef55c9a57303453e7a4c9e1c09b241971/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-request-redirect.https-expected.txt
[modify] https://crrev.com/bd1f56eef55c9a57303453e7a4c9e1c09b241971/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/fetch-request-resources.https-expected.txt
[modify] https://crrev.com/bd1f56eef55c9a57303453e7a4c9e1c09b241971/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigate-window.https-expected.txt
[modify] https://crrev.com/bd1f56eef55c9a57303453e7a4c9e1c09b241971/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https-expected.txt
[add] https://crrev.com/bd1f56eef55c9a57303453e7a4c9e1c09b241971/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/oninstall-script-error.https-expected.txt
[modify] https://crrev.com/bd1f56eef55c9a57303453e7a4c9e1c09b241971/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/performance-timeline.https-expected.txt
[delete] https://crrev.com/54b10b19549cfa93ff6c9b6743d28324d35f5ef4/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/postmessage-to-client.https-expected.txt
[delete] https://crrev.com/54b10b19549cfa93ff6c9b6743d28324d35f5ef4/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/service-worker-csp-connect.https-expected.txt
[delete] https://crrev.com/54b10b19549cfa93ff6c9b6743d28324d35f5ef4/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/serviceworker-message-event-historical.https-expected.txt
[modify] https://crrev.com/bd1f56eef55c9a57303453e7a4c9e1c09b241971/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/websocket.https-expected.txt
[modify] https://crrev.com/bd1f56eef55c9a57303453e7a4c9e1c09b241971/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/worker-interception.https-expected.txt
[delete] https://crrev.com/54b10b19549cfa93ff6c9b6743d28324d35f5ef4/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/xhr.https-expected.txt
[modify] https://crrev.com/bd1f56eef55c9a57303453e7a4c9e1c09b241971/third_party/WebKit/LayoutTests/external/wpt/webrtc/simplecall-expected.txt

Project Member

Comment 24 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b39b2b6850398acf84f8bb86038dce754bf778d8

commit b39b2b6850398acf84f8bb86038dce754bf778d8
Author: tkent <tkent@chromium.org>
Date: Fri Jan 20 07:57:54 2017

Cleanup after enabling WPTServe.

* webkitpy/layout_tests and LayoutTests/WPTServeExpectations
  Remove --enable_wptserve flag and related code.

* webkitpy/w3c and other files
  Stop copying testharnessreport.js, WebIDLParser.js, and vendor-prefix.js.
  We map LayoutTests/resources/{testharnessreport.js,vendor-prefix.js} into
  external/wpt by 'alias' feature of WPTServe. So we don't need to copy these
  files any longer.
  As for WebIDLParser.js, WPTServe maps /resources/WebIDLParser.js to
  /resources/webidl2/lib/webidl2.js by default [1]
  csswg-test doesn't use WPTServe, and we need to update blink_test_runner.cc
  so that /resoruces/testharness*.js point files in LayoutTests/resources.

[1] https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/serve/serve.py?type=cs&l=100

BUG= 618366 

Review-Url: https://codereview.chromium.org/2511333002
Cr-Commit-Position: refs/heads/master@{#445012}

[modify] https://crrev.com/b39b2b6850398acf84f8bb86038dce754bf778d8/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/b39b2b6850398acf84f8bb86038dce754bf778d8/third_party/WebKit/LayoutTests/PRESUBMIT.py
[modify] https://crrev.com/b39b2b6850398acf84f8bb86038dce754bf778d8/third_party/WebKit/LayoutTests/W3CImportExpectations
[delete] https://crrev.com/6c59727f79b04675fdc9dc663fa36d16b23535b4/third_party/WebKit/LayoutTests/WPTServeExpectations
[delete] https://crrev.com/6c59727f79b04675fdc9dc663fa36d16b23535b4/third_party/WebKit/LayoutTests/external/wpt/common/vendor-prefix.js
[delete] https://crrev.com/6c59727f79b04675fdc9dc663fa36d16b23535b4/third_party/WebKit/LayoutTests/external/wpt/resources/WebIDLParser.js
[delete] https://crrev.com/6c59727f79b04675fdc9dc663fa36d16b23535b4/third_party/WebKit/LayoutTests/external/wpt/resources/testharnessreport.js
[modify] https://crrev.com/b39b2b6850398acf84f8bb86038dce754bf778d8/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
[modify] https://crrev.com/b39b2b6850398acf84f8bb86038dce754bf778d8/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
[modify] https://crrev.com/b39b2b6850398acf84f8bb86038dce754bf778d8/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py
[modify] https://crrev.com/b39b2b6850398acf84f8bb86038dce754bf778d8/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
[modify] https://crrev.com/b39b2b6850398acf84f8bb86038dce754bf778d8/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/apache_http.py
[modify] https://crrev.com/b39b2b6850398acf84f8bb86038dce754bf778d8/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py

Comment 25 by tkent@chromium.org, Jan 20 2017

Status: Fixed (was: Started)
I think there are no remaining tasks for this.

Amazing! Thanks tkent.
Summary: Run external/wpt/ layout tests with wptserve enabled by default. (was: Run layout tests with wptserve enabled by default.)
Just confirmed with tkent: only external/wpt is running wptserve by default now. I'll change the summary to reflect that. I think the remaining work for all LayoutTests is tracked at issue 347864.
Components: Blink>Infra>Ecosystem
Components: -Blink>Infra>Predictability
Blocking: -347864

Sign in to add a comment