Issue 618356 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	se...@chromium.org
Closed:	Jun 2016
Components:	UI>Browser>Autofill
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	1
Type:	Bug

Dedupe similar autofill profiles on insertion.

Project Member Reported by se...@chromium.org, Jun 8 2016

Issue description

While less and less duplicate profiles are being created due to our efforts in the past months, duplicate profiles that were saved before that are still present.

As a first step to dedupe existing profiles, we should expend the current logic of finding and merging the inserted profile with the first matching existing profile to all matching existing profiles.

As a result, using a profile will effectively merge it with all similar profiles and delete all but the resulting profile.

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7fc72c36d74dd40a71d076c45558daabc7c825c

commit c7fc72c36d74dd40a71d076c45558daabc7c825c
Author: sebsg <sebsg@chromium.org>
Date: Mon Jun 13 18:52:44 2016

On profile insertion, goes through all the user's profiles and try to merge. Delete all original profiles that were used in the merge, keeping only the result of the merge(s).

BUG= 618356 
TEST=PersonalDataManagerTest

Review-Url: https://codereview.chromium.org/1989173005
Cr-Commit-Position: refs/heads/master@{#399495}

[modify] https://crrev.com/c7fc72c36d74dd40a71d076c45558daabc7c825c/components/autofill/core/browser/autofill_profile.cc
[modify] https://crrev.com/c7fc72c36d74dd40a71d076c45558daabc7c825c/components/autofill/core/browser/autofill_profile.h
[modify] https://crrev.com/c7fc72c36d74dd40a71d076c45558daabc7c825c/components/autofill/core/browser/autofill_profile_unittest.cc
[modify] https://crrev.com/c7fc72c36d74dd40a71d076c45558daabc7c825c/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/c7fc72c36d74dd40a71d076c45558daabc7c825c/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/c7fc72c36d74dd40a71d076c45558daabc7c825c/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/c7fc72c36d74dd40a71d076c45558daabc7c825c/components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc

Comment 2 by se...@chromium.org, Jun 13 2016

Status: Fixed (was: Started)

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7fc72c36d74dd40a71d076c45558daabc7c825c

commit c7fc72c36d74dd40a71d076c45558daabc7c825c
Author: sebsg <sebsg@chromium.org>
Date: Mon Jun 13 18:52:44 2016

On profile insertion, goes through all the user's profiles and try to merge. Delete all original profiles that were used in the merge, keeping only the result of the merge(s).

BUG= 618356 
TEST=PersonalDataManagerTest

Review-Url: https://codereview.chromium.org/1989173005
Cr-Commit-Position: refs/heads/master@{#399495}

[modify] https://crrev.com/c7fc72c36d74dd40a71d076c45558daabc7c825c/components/autofill/core/browser/autofill_profile.cc
[modify] https://crrev.com/c7fc72c36d74dd40a71d076c45558daabc7c825c/components/autofill/core/browser/autofill_profile.h
[modify] https://crrev.com/c7fc72c36d74dd40a71d076c45558daabc7c825c/components/autofill/core/browser/autofill_profile_unittest.cc
[modify] https://crrev.com/c7fc72c36d74dd40a71d076c45558daabc7c825c/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/c7fc72c36d74dd40a71d076c45558daabc7c825c/components/autofill/core/browser/personal_data_manager.h
[modify] https://crrev.com/c7fc72c36d74dd40a71d076c45558daabc7c825c/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/c7fc72c36d74dd40a71d076c45558daabc7c825c/components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1d083425059e8195e11e0b5d57fff2f5a1fa8d5

commit c1d083425059e8195e11e0b5d57fff2f5a1fa8d5
Author: mathp <mathp@chromium.org>
Date: Wed Jun 15 16:05:31 2016

[Autofill] Put Autofill Profile Cleanup behing a feature flag.

BUG= 618356 
TEST=PersonalDataManagerTest

Review-Url: https://codereview.chromium.org/2060223004
Cr-Commit-Position: refs/heads/master@{#399911}

[modify] https://crrev.com/c1d083425059e8195e11e0b5d57fff2f5a1fa8d5/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/c1d083425059e8195e11e0b5d57fff2f5a1fa8d5/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/c1d083425059e8195e11e0b5d57fff2f5a1fa8d5/components/autofill/core/browser/autofill_merge_unittest.cc
[modify] https://crrev.com/c1d083425059e8195e11e0b5d57fff2f5a1fa8d5/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/c1d083425059e8195e11e0b5d57fff2f5a1fa8d5/components/autofill/core/browser/personal_data_manager_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f31a7d478991d03138956eb6665424d53b0039da

commit f31a7d478991d03138956eb6665424d53b0039da
Author: mathp <mathp@chromium.org>
Date: Wed Jun 15 19:41:57 2016

[Autofill] Log the number of profiles considered/removed during dedupe.

BUG= 618356 
TEST=PersonalDataManagerTest

Review-Url: https://codereview.chromium.org/2061303002
Cr-Commit-Position: refs/heads/master@{#399991}

[modify] https://crrev.com/f31a7d478991d03138956eb6665424d53b0039da/components/autofill/core/browser/autofill_metrics.cc
[modify] https://crrev.com/f31a7d478991d03138956eb6665424d53b0039da/components/autofill/core/browser/autofill_metrics.h
[modify] https://crrev.com/f31a7d478991d03138956eb6665424d53b0039da/components/autofill/core/browser/personal_data_manager.cc
[modify] https://crrev.com/f31a7d478991d03138956eb6665424d53b0039da/components/autofill/core/browser/personal_data_manager_unittest.cc
[modify] https://crrev.com/f31a7d478991d03138956eb6665424d53b0039da/tools/metrics/histograms/histograms.xml

►

Issue 618356 link

Issue metadata

Dedupe similar autofill profiles on insertion.

Issue description

Comment 1 by bugdroid1@chromium.org, Jun 13 2016

Comment 1 Deleted

Comment 2 by se...@chromium.org, Jun 13 2016

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Jun 15 2016

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Jun 15 2016

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Jun 15 2016

Comment 5 Deleted

Sign in to add a comment