New issue
Advanced search Search tips

Issue 618305 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 764633



Sign in to add a comment

Blink should expose cross-origin attributes via an interceptor instead of all-can-read properties

Project Member Reported by jochen@chromium.org, Jun 8 2016

Issue description

this will allow for context-less contexts for OOPIF
 
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/c34cc7a6ff20d7fb5a6ae1e7327278d3eb12e688

commit c34cc7a6ff20d7fb5a6ae1e7327278d3eb12e688
Author: jochen <jochen@chromium.org>
Date: Mon Jun 27 11:48:04 2016

Optionally invoke an interceptor on failed access checks

This superseeds all-can-read/all-can-write properties

BUG= chromium:618305 
R=verwaest@chromium.org

Review-Url: https://codereview.chromium.org/2087823002
Cr-Commit-Position: refs/heads/master@{#37286}

[modify] https://crrev.com/c34cc7a6ff20d7fb5a6ae1e7327278d3eb12e688/include/v8.h
[modify] https://crrev.com/c34cc7a6ff20d7fb5a6ae1e7327278d3eb12e688/src/api.cc
[modify] https://crrev.com/c34cc7a6ff20d7fb5a6ae1e7327278d3eb12e688/src/isolate.cc
[modify] https://crrev.com/c34cc7a6ff20d7fb5a6ae1e7327278d3eb12e688/src/keys.cc
[modify] https://crrev.com/c34cc7a6ff20d7fb5a6ae1e7327278d3eb12e688/src/keys.h
[modify] https://crrev.com/c34cc7a6ff20d7fb5a6ae1e7327278d3eb12e688/src/lookup.cc
[modify] https://crrev.com/c34cc7a6ff20d7fb5a6ae1e7327278d3eb12e688/src/lookup.h
[modify] https://crrev.com/c34cc7a6ff20d7fb5a6ae1e7327278d3eb12e688/src/objects-debug.cc
[modify] https://crrev.com/c34cc7a6ff20d7fb5a6ae1e7327278d3eb12e688/src/objects-inl.h
[modify] https://crrev.com/c34cc7a6ff20d7fb5a6ae1e7327278d3eb12e688/src/objects-printer.cc
[modify] https://crrev.com/c34cc7a6ff20d7fb5a6ae1e7327278d3eb12e688/src/objects.cc
[modify] https://crrev.com/c34cc7a6ff20d7fb5a6ae1e7327278d3eb12e688/src/objects.h
[modify] https://crrev.com/c34cc7a6ff20d7fb5a6ae1e7327278d3eb12e688/test/cctest/BUILD.gn
[modify] https://crrev.com/c34cc7a6ff20d7fb5a6ae1e7327278d3eb12e688/test/cctest/cctest.gyp
[add] https://crrev.com/c34cc7a6ff20d7fb5a6ae1e7327278d3eb12e688/test/cctest/test-access-checks.cc

Comment 3 by creis@chromium.org, Jul 6 2016

Cc: creis@chromium.org
Components: Internals>Sandbox>SiteIsolation

Comment 5 by jochen@chromium.org, Jul 19 2016

Cc: jochen@chromium.org
Owner: dcheng@chromium.org
Daniel, your turn :)
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3387c1777b355f2da7a02ad1fc833745f0589915

commit 3387c1777b355f2da7a02ad1fc833745f0589915
Author: Daniel Cheng <dcheng@chromium.org>
Date: Fri Dec 09 16:17:49 2016

Implement cross-origin attributes using access check interceptors.

BUG= 618305 
R=haraken@chromium.org, jochen@chromium.org, yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2439013002 .
Cr-Commit-Position: refs/heads/master@{#437554}

[modify] https://crrev.com/3387c1777b355f2da7a02ad1fc833745f0589915/third_party/WebKit/LayoutTests/http/tests/security/cross-frame-access-enumeration-expected.txt
[modify] https://crrev.com/3387c1777b355f2da7a02ad1fc833745f0589915/third_party/WebKit/LayoutTests/http/tests/security/cross-frame-access-put-expected.txt
[modify] https://crrev.com/3387c1777b355f2da7a02ad1fc833745f0589915/third_party/WebKit/LayoutTests/http/tests/security/cross-frame-access-set-window-properties-expected.txt
[modify] https://crrev.com/3387c1777b355f2da7a02ad1fc833745f0589915/third_party/WebKit/LayoutTests/http/tests/security/cross-origin-window-open-exception-expected.txt
[modify] https://crrev.com/3387c1777b355f2da7a02ad1fc833745f0589915/third_party/WebKit/LayoutTests/http/tests/security/w3c/cross-origin-objects-expected.txt
[modify] https://crrev.com/3387c1777b355f2da7a02ad1fc833745f0589915/third_party/WebKit/Source/bindings/IDLExtendedAttributes.md
[modify] https://crrev.com/3387c1777b355f2da7a02ad1fc833745f0589915/third_party/WebKit/Source/bindings/IDLExtendedAttributes.txt
[modify] https://crrev.com/3387c1777b355f2da7a02ad1fc833745f0589915/third_party/WebKit/Source/bindings/bindings.gni
[modify] https://crrev.com/3387c1777b355f2da7a02ad1fc833745f0589915/third_party/WebKit/Source/bindings/core/v8/BindingSecurity.cpp
[modify] https://crrev.com/3387c1777b355f2da7a02ad1fc833745f0589915/third_party/WebKit/Source/bindings/core/v8/BindingSecurity.h
[add] https://crrev.com/3387c1777b355f2da7a02ad1fc833745f0589915/third_party/WebKit/Source/bindings/core/v8/V8CrossOriginSetterInfo.h
[modify] https://crrev.com/3387c1777b355f2da7a02ad1fc833745f0589915/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
[modify] https://crrev.com/3387c1777b355f2da7a02ad1fc833745f0589915/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
[modify] https://crrev.com/3387c1777b355f2da7a02ad1fc833745f0589915/third_party/WebKit/Source/bindings/scripts/v8_attributes.py
[modify] https://crrev.com/3387c1777b355f2da7a02ad1fc833745f0589915/third_party/WebKit/Source/bindings/scripts/v8_interface.py
[modify] https://crrev.com/3387c1777b355f2da7a02ad1fc833745f0589915/third_party/WebKit/Source/bindings/scripts/v8_methods.py
[modify] https://crrev.com/3387c1777b355f2da7a02ad1fc833745f0589915/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl
[modify] https://crrev.com/3387c1777b355f2da7a02ad1fc833745f0589915/third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl
[modify] https://crrev.com/3387c1777b355f2da7a02ad1fc833745f0589915/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
[modify] https://crrev.com/3387c1777b355f2da7a02ad1fc833745f0589915/third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl
[modify] https://crrev.com/3387c1777b355f2da7a02ad1fc833745f0589915/third_party/WebKit/Source/bindings/tests/idls/core/TestInterface.idl
[modify] https://crrev.com/3387c1777b355f2da7a02ad1fc833745f0589915/third_party/WebKit/Source/bindings/tests/idls/core/TestInterfaceCheckSecurity.idl
[modify] https://crrev.com/3387c1777b355f2da7a02ad1fc833745f0589915/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp
[modify] https://crrev.com/3387c1777b355f2da7a02ad1fc833745f0589915/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp
[modify] https://crrev.com/3387c1777b355f2da7a02ad1fc833745f0589915/third_party/WebKit/Source/core/frame/DOMWindow.h
[modify] https://crrev.com/3387c1777b355f2da7a02ad1fc833745f0589915/third_party/WebKit/Source/core/frame/Location.idl
[modify] https://crrev.com/3387c1777b355f2da7a02ad1fc833745f0589915/third_party/WebKit/Source/core/frame/Window.idl

Blockedon: 764633
Status: Fixed (was: Assigned)

Sign in to add a comment