New issue
Advanced search Search tips

Issue 618301 link

Starred by 1 user
Status: Fixed
Owner:
mlamouri@chromium.org
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Start autoplay muted videos when visible if autoplay is set via attribute

Project Member Reported by mlamouri@chromium.org, Jun 8 2016 
In other words:
`<video autoplay muted>` should only start playing when in the viewport.

play() calls should start playback regardless of visibility.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c33d8c3ae4c8f1fc2d58574c128725389864d95

commit 0c33d8c3ae4c8f1fc2d58574c128725389864d95
Author: mlamouri <mlamouri@chromium.org>
Date: Wed Jun 22 09:56:37 2016

Start autoplay muted videos with autoplay attribute when they are visible.

The behaviour is linked to the autoplay-muted-videos flag.

This is introducing a ElementVisibilityObserver helper that is behind the
scene using the IntersectionObserver.

BUG= 618301 

Review-Url: https://codereview.chromium.org/2051253002
Cr-Commit-Position: refs/heads/master@{#401242}

[modify] https://crrev.com/0c33d8c3ae4c8f1fc2d58574c128725389864d95/third_party/WebKit/LayoutTests/media/autoplay-muted.html
[add] https://crrev.com/0c33d8c3ae4c8f1fc2d58574c128725389864d95/third_party/WebKit/LayoutTests/media/autoplay-when-visible.html
[modify] https://crrev.com/0c33d8c3ae4c8f1fc2d58574c128725389864d95/third_party/WebKit/Source/core/core.gypi
[add] https://crrev.com/0c33d8c3ae4c8f1fc2d58574c128725389864d95/third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp
[add] https://crrev.com/0c33d8c3ae4c8f1fc2d58574c128725389864d95/third_party/WebKit/Source/core/dom/ElementVisibilityObserver.h
[modify] https://crrev.com/0c33d8c3ae4c8f1fc2d58574c128725389864d95/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp
[modify] https://crrev.com/0c33d8c3ae4c8f1fc2d58574c128725389864d95/third_party/WebKit/Source/core/dom/IntersectionObserver.h
[modify] https://crrev.com/0c33d8c3ae4c8f1fc2d58574c128725389864d95/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/0c33d8c3ae4c8f1fc2d58574c128725389864d95/third_party/WebKit/Source/core/html/HTMLMediaElement.h

Comment 2 by mlamouri@chromium.org, Jun 22 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment