New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 618287 link

Starred by 7 users

Regression: Seek-bar flickers initially while the is video playing at 'www.google.com/doodles'.

Reported by jshan...@etouch.net, Jun 8 2016

Issue description

Chrome Version: 52.0.2743.33 (Official Build) 381c5e933974600cf004f795100242670cb0764b-refs/branch-heads/2743@{#271} (32/64-bit)
OS: Mac (10.11.4)

URL: https://www.google.com/doodles/lotte-reinigers-117th-birthday

Steps:
1. Launch Chrome and navigate to above URL.
2. Observe the seek bar of video.

Actual: Seek-bar of video flickers initially on playing it, also media control is not seen properly on hovering mouse on it.

Expected: Seek-bar of video should not flicker initially on playing it.

This is a regression issue broken in M-52, below is bisect info.

Good build: 52.0.2740.0
Bad build: 52.0.2741.0

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/e0dd953ea202a41ab87c13e1f4d3974d7a2501aa..ac95109db90a079c1d56bc61b5a2b27b2b2fae63?pretty=fuller&n=100

Suspecting: r394338 ?

Please help to re-assign if your change is not the cause for this issue.

Note: This issue is not seen on Windows, Linux, Retina and Mac (10.10.5)


 
Actual_screencast.mov
3.5 MB Download
Expected_screencast.mov
3.1 MB Download
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 8 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: ReleaseBlock-Stable
Adding RB label as this is a recent regression.
Not observing this on Canary (53.0.2761.2) or Beta (52.0.2743.24) on retina Macbook Pro. Trying a non-retina machine.
Able to reproduce this issue on MacBook Air 10.11.5 using chrome version 53.0.2768.0.

Able to reproduce on Macbook Air locally.
Still able to reproduce the issue on 0.11.5 using chrome version 53.0.2774.2

ccameron@ Could you please look into this issue.

Thanks,
Still able to reproduce the issue on Mac 10.11.5 using 53.0.2780.0.

ccameron@ Any update on this issue.

Cc: ssamanoori@chromium.org rnimmagadda@chromium.org
Labels: Needs-Feedback
Unable to repro this issue on MAC (10.11.5) for Google Chrome Canary Version - 53.0.2784.1

Screen-recording is attached.

@jshanbal: Could you please confirm the same.

Thank you.
618287.mov
3.8 MB Download
Labels: -Needs-Feedback
With response to comment #8, above issue is reproducible on latest canary version 54.0.2787.0 on Mac 10.11.4.
Please refer the attached screencast.
Actual_video.mov
3.9 MB Download
Components: -Blink>Media>Video Internals>Compositing
This seems specific to Macbook Air -- it might be specific to a particular GPU
Able to reproduce the issue on MacBook Air 10.11.5(non-touch & Non-retina) using latest canary 54.0.2795.0. Issue is seen only at the beginning and once its started played for  4-5 secs and then hovered the seek-bar and the media icons are looking fine.
@ccameron: Hey, would you mind providing an update on the above issue?

I really appreciate your help.

Thank you!
@ccameron: Gentle Ping.
Mergedinto: 627666
Status: Duplicate (was: Assigned)
Oh dear ... here I thought this was an Apple issue, and it's my own dumb fault.

Fix is easy, fortunately.
Project Member

Comment 17 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4eff049bf6baef15d02a9c2d019a38e4a50c9731

commit 4eff049bf6baef15d02a9c2d019a38e4a50c9731
Author: ccameron <ccameron@chromium.org>
Date: Mon Jul 25 20:22:20 2016

Mac: Correct CALayer reuse logic

This is a bug in how we construct the CALayer tree. The code
originally assumed that we would always re-use the old CALayer
if it existed. This is no longer the case now that we sometimes
use AVSampleBufferDisplayLayers.

With this patch, we ensure that we always put the new CALayer
in the position of the old CALayer.

A unit test for this is coming in another patch, but this one is
being merged back to M52, and the unit test files have changed
dramatically.

BUG= 618287 

Review-Url: https://codereview.chromium.org/2181713004
Cr-Commit-Position: refs/heads/master@{#407561}

[modify] https://crrev.com/4eff049bf6baef15d02a9c2d019a38e4a50c9731/ui/accelerated_widget_mac/ca_renderer_layer_tree.mm

Labels: -M-53 -MovedFrom-52 Merge-Request-52 M-52
Status: Assigned (was: Duplicate)
Adding merge request for M52
Labels: Merge-Request-53
And M53

Before we approve merge to M53, Could you please confirm whether this change is baked/verified in Canary or ToT and safe to merge?
The change is very simple and small. I've verified that it fixes the issue in local Chromium builds without any regressions.

I understand that the M52 bar is very high at this point, but I believe this issue should be merged at this point.
Labels: -Merge-Request-53 Merge-Approved-53
Approving merge to M53 branch 2785 based on comment #21. Please merge ASAP so we can take it for tomorrow's M53 last Dev release. Thank you.
Labels: -Merge-Request-52 Merge-Approved-52 OS-iOS
Also approving merge to M52 branch 2743. Please make sure to test/verify the fix in tonight's canary and revert the change from M52/53 branches if things are NOT looking good in canary.
Labels: -OS-iOS
#23 SGTM
Thank you very much ccameron@. Please update the bug with Canary test result tomorrow morning. Truly appreciate you time and help.
Project Member

Comment 27 by bugdroid1@chromium.org, Jul 25 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e71bcfb49d00bd77ed4bd22aa059f6233f56a789

commit e71bcfb49d00bd77ed4bd22aa059f6233f56a789
Author: Christopher Cameron <ccameron@chromium.org>
Date: Mon Jul 25 21:39:59 2016

Mac: Correct CALayer reuse logic

This is a bug in how we construct the CALayer tree. The code
originally assumed that we would always re-use the old CALayer
if it existed. This is no longer the case now that we sometimes
use AVSampleBufferDisplayLayers.

With this patch, we ensure that we always put the new CALayer
in the position of the old CALayer.

A unit test for this is coming in another patch, but this one is
being merged back to M52, and the unit test files have changed
dramatically.

BUG= 618287 

Review-Url: https://codereview.chromium.org/2181713004
Cr-Commit-Position: refs/heads/master@{#407561}
(cherry picked from commit 4eff049bf6baef15d02a9c2d019a38e4a50c9731)

Review URL: https://codereview.chromium.org/2184463002 .

Cr-Commit-Position: refs/branch-heads/2785@{#345}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/e71bcfb49d00bd77ed4bd22aa059f6233f56a789/ui/accelerated_widget_mac/ca_renderer_layer_tree.mm

Project Member

Comment 28 by bugdroid1@chromium.org, Jul 25 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09bcd556fc055ba67b6ea65d708d7c1ac3091ae1

commit 09bcd556fc055ba67b6ea65d708d7c1ac3091ae1
Author: Christopher Cameron <ccameron@chromium.org>
Date: Mon Jul 25 21:47:28 2016

Mac: Correct CALayer reuse logic

This is a bug in how we construct the CALayer tree. The code
originally assumed that we would always re-use the old CALayer
if it existed. This is no longer the case now that we sometimes
use AVSampleBufferDisplayLayers.

With this patch, we ensure that we always put the new CALayer
in the position of the old CALayer.

A unit test for this is coming in another patch, but this one is
being merged back to M52, and the unit test files have changed
dramatically.

BUG= 618287 

Review-Url: https://codereview.chromium.org/2181713004
Cr-Commit-Position: refs/heads/master@{#407561}
(cherry picked from commit 4eff049bf6baef15d02a9c2d019a38e4a50c9731)

Review URL: https://codereview.chromium.org/2176113003 .

Cr-Commit-Position: refs/branch-heads/2743@{#699}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/09bcd556fc055ba67b6ea65d708d7c1ac3091ae1/ui/accelerated_widget_mac/ca_renderer_layer_tree.mm

Status: Fixed (was: Assigned)
Marking as fixed. I will verify with Canary tomorrow morning.
Thank you very much ccameron@.
Labels: TE-Verified-M54 TE-Verified-54.0.2808.0
Verified the issue on Latest Dev# 53.0.2785.21 and Latest Canary# 54.0.2808.0 on Mac OS X 10.11.5, the issue has been fixed and is working as intended.
Hence adding TE-Verified Labels.
Thank You.
Labels: TE-Verified-M53 TE-Verified-53.0.2785.30
Also to add, verified the issue on Dev# 53.0.2785.30 and Stable# 52.0.2743.91 and is also working as intended without any issue.
Also adding a screen cast for reference.
Thank You.
618287.mov
7.1 MB Download
Also verified in Canary.
Labels: TE-Verified-M52 TE-Verified-52.0.2743.91
Verified the issue on Stable Version# 52.0.2743.91 on Mac OS X 10.11.5 and the issue has been fixed and is working as intended. Hence adding TE-Verified Labels.
Thank You everyone.
Cc: dtapu...@chromium.org ranjitkan@chromium.org sunxd@chromium.org pbomm...@chromium.org mustaq@chromium.org ccameron@chromium.org ligim...@chromium.org erikc...@chromium.org
 Issue 627666  has been merged into this issue.

Sign in to add a comment