Issue metadata
Sign in to add a comment
|
Regression: Seek-bar flickers initially while the is video playing at 'www.google.com/doodles'.
Reported by
jshan...@etouch.net,
Jun 8 2016
|
||||||||||||||||||||||||
Issue descriptionChrome Version: 52.0.2743.33 (Official Build) 381c5e933974600cf004f795100242670cb0764b-refs/branch-heads/2743@{#271} (32/64-bit) OS: Mac (10.11.4) URL: https://www.google.com/doodles/lotte-reinigers-117th-birthday Steps: 1. Launch Chrome and navigate to above URL. 2. Observe the seek bar of video. Actual: Seek-bar of video flickers initially on playing it, also media control is not seen properly on hovering mouse on it. Expected: Seek-bar of video should not flicker initially on playing it. This is a regression issue broken in M-52, below is bisect info. Good build: 52.0.2740.0 Bad build: 52.0.2741.0 Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/e0dd953ea202a41ab87c13e1f4d3974d7a2501aa..ac95109db90a079c1d56bc61b5a2b27b2b2fae63?pretty=fuller&n=100 Suspecting: r394338 ? Please help to re-assign if your change is not the cause for this issue. Note: This issue is not seen on Windows, Linux, Retina and Mac (10.10.5)
,
Jun 8 2016
Adding RB label as this is a recent regression.
,
Jun 8 2016
Not observing this on Canary (53.0.2761.2) or Beta (52.0.2743.24) on retina Macbook Pro. Trying a non-retina machine.
,
Jun 15 2016
Able to reproduce this issue on MacBook Air 10.11.5 using chrome version 53.0.2768.0.
,
Jun 16 2016
Able to reproduce on Macbook Air locally.
,
Jun 21 2016
Still able to reproduce the issue on 0.11.5 using chrome version 53.0.2774.2 ccameron@ Could you please look into this issue. Thanks,
,
Jun 27 2016
Still able to reproduce the issue on Mac 10.11.5 using 53.0.2780.0. ccameron@ Any update on this issue.
,
Jul 1 2016
Unable to repro this issue on MAC (10.11.5) for Google Chrome Canary Version - 53.0.2784.1 Screen-recording is attached. @jshanbal: Could you please confirm the same. Thank you.
,
Jul 5 2016
With response to comment #8, above issue is reproducible on latest canary version 54.0.2787.0 on Mac 10.11.4. Please refer the attached screencast.
,
Jul 5 2016
,
Jul 7 2016
This seems specific to Macbook Air -- it might be specific to a particular GPU
,
Jul 14 2016
Able to reproduce the issue on MacBook Air 10.11.5(non-touch & Non-retina) using latest canary 54.0.2795.0. Issue is seen only at the beginning and once its started played for 4-5 secs and then hovered the seek-bar and the media icons are looking fine.
,
Jul 18 2016
@ccameron: Hey, would you mind providing an update on the above issue? I really appreciate your help. Thank you!
,
Jul 22 2016
@ccameron: Gentle Ping.
,
Jul 25 2016
,
Jul 25 2016
Oh dear ... here I thought this was an Apple issue, and it's my own dumb fault. Fix is easy, fortunately.
,
Jul 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4eff049bf6baef15d02a9c2d019a38e4a50c9731 commit 4eff049bf6baef15d02a9c2d019a38e4a50c9731 Author: ccameron <ccameron@chromium.org> Date: Mon Jul 25 20:22:20 2016 Mac: Correct CALayer reuse logic This is a bug in how we construct the CALayer tree. The code originally assumed that we would always re-use the old CALayer if it existed. This is no longer the case now that we sometimes use AVSampleBufferDisplayLayers. With this patch, we ensure that we always put the new CALayer in the position of the old CALayer. A unit test for this is coming in another patch, but this one is being merged back to M52, and the unit test files have changed dramatically. BUG= 618287 Review-Url: https://codereview.chromium.org/2181713004 Cr-Commit-Position: refs/heads/master@{#407561} [modify] https://crrev.com/4eff049bf6baef15d02a9c2d019a38e4a50c9731/ui/accelerated_widget_mac/ca_renderer_layer_tree.mm
,
Jul 25 2016
Adding merge request for M52
,
Jul 25 2016
And M53
,
Jul 25 2016
Before we approve merge to M53, Could you please confirm whether this change is baked/verified in Canary or ToT and safe to merge?
,
Jul 25 2016
The change is very simple and small. I've verified that it fixes the issue in local Chromium builds without any regressions. I understand that the M52 bar is very high at this point, but I believe this issue should be merged at this point.
,
Jul 25 2016
Approving merge to M53 branch 2785 based on comment #21. Please merge ASAP so we can take it for tomorrow's M53 last Dev release. Thank you.
,
Jul 25 2016
Also approving merge to M52 branch 2743. Please make sure to test/verify the fix in tonight's canary and revert the change from M52/53 branches if things are NOT looking good in canary.
,
Jul 25 2016
,
Jul 25 2016
#23 SGTM
,
Jul 25 2016
Thank you very much ccameron@. Please update the bug with Canary test result tomorrow morning. Truly appreciate you time and help.
,
Jul 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e71bcfb49d00bd77ed4bd22aa059f6233f56a789 commit e71bcfb49d00bd77ed4bd22aa059f6233f56a789 Author: Christopher Cameron <ccameron@chromium.org> Date: Mon Jul 25 21:39:59 2016 Mac: Correct CALayer reuse logic This is a bug in how we construct the CALayer tree. The code originally assumed that we would always re-use the old CALayer if it existed. This is no longer the case now that we sometimes use AVSampleBufferDisplayLayers. With this patch, we ensure that we always put the new CALayer in the position of the old CALayer. A unit test for this is coming in another patch, but this one is being merged back to M52, and the unit test files have changed dramatically. BUG= 618287 Review-Url: https://codereview.chromium.org/2181713004 Cr-Commit-Position: refs/heads/master@{#407561} (cherry picked from commit 4eff049bf6baef15d02a9c2d019a38e4a50c9731) Review URL: https://codereview.chromium.org/2184463002 . Cr-Commit-Position: refs/branch-heads/2785@{#345} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/e71bcfb49d00bd77ed4bd22aa059f6233f56a789/ui/accelerated_widget_mac/ca_renderer_layer_tree.mm
,
Jul 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09bcd556fc055ba67b6ea65d708d7c1ac3091ae1 commit 09bcd556fc055ba67b6ea65d708d7c1ac3091ae1 Author: Christopher Cameron <ccameron@chromium.org> Date: Mon Jul 25 21:47:28 2016 Mac: Correct CALayer reuse logic This is a bug in how we construct the CALayer tree. The code originally assumed that we would always re-use the old CALayer if it existed. This is no longer the case now that we sometimes use AVSampleBufferDisplayLayers. With this patch, we ensure that we always put the new CALayer in the position of the old CALayer. A unit test for this is coming in another patch, but this one is being merged back to M52, and the unit test files have changed dramatically. BUG= 618287 Review-Url: https://codereview.chromium.org/2181713004 Cr-Commit-Position: refs/heads/master@{#407561} (cherry picked from commit 4eff049bf6baef15d02a9c2d019a38e4a50c9731) Review URL: https://codereview.chromium.org/2176113003 . Cr-Commit-Position: refs/branch-heads/2743@{#699} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/09bcd556fc055ba67b6ea65d708d7c1ac3091ae1/ui/accelerated_widget_mac/ca_renderer_layer_tree.mm
,
Jul 25 2016
Marking as fixed. I will verify with Canary tomorrow morning.
,
Jul 25 2016
Thank you very much ccameron@.
,
Jul 26 2016
Verified the issue on Latest Dev# 53.0.2785.21 and Latest Canary# 54.0.2808.0 on Mac OS X 10.11.5, the issue has been fixed and is working as intended. Hence adding TE-Verified Labels. Thank You.
,
Jul 26 2016
Also to add, verified the issue on Dev# 53.0.2785.30 and Stable# 52.0.2743.91 and is also working as intended without any issue. Also adding a screen cast for reference. Thank You.
,
Jul 26 2016
Also verified in Canary.
,
Jul 27 2016
Verified the issue on Stable Version# 52.0.2743.91 on Mac OS X 10.11.5 and the issue has been fixed and is working as intended. Hence adding TE-Verified Labels. Thank You everyone.
,
Aug 10 2016
Issue 627666 has been merged into this issue. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by sheriffbot@chromium.org
, Jun 8 2016