Issue metadata
Sign in to add a comment
|
Regression : Weird Font is seen for URL at the bottom of the page on installing light themes |
||||||||||||||||||||||
Issue descriptionVersion: 53.0.2762.0 OS: Ubuntu 14.04,Windows URL:1)https://chrome.google.com/webstore/detail/beach-zastavkifreeru/pldjedicbnjmccbpbgbiddfbgilpgmgm?utm_source=chrome-ntp-icon 2)https://chrome.google.com/webstore/detail/coastalair-20/pfncmbjabnpldlfbnmhnhblapoibfbei?utm_source=chrome-ntp-icon What steps will reproduce the problem? (1)Launch Chrome -> Go to any of the above URLs to add Theme (2)After the theme gets loaded open NTP -> Now hover the Mouse on any thumbnails and observe URL at the bottom of the Page (Please refer Video and Screenshot) Note: Same issue is Reproducible in Apps Page i.e. Go to Chrome://apps -> Now hover the mouse on Web store at the Bottom and observe URL Expected: Font of the URL should be seen clearly at the bottom of the page on installing light themes Actual: Instead Weird Font is seen for URL at the bottom of the page This is Regression Issue broken in M-53 Manual good and Bad Builds: Good Build: 53.0.2754.0 Bad Build: 53.0.2756.0 Below is the Bisect info: CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/fb0fd2cfd895efb50f6645f2177d9bf0639451d6..8a208672ab14fa87cd1dd5ad6043a11c22e4d71e Suspecting https://codereview.chromium.org/2026033002 from above changelog @sunxd : Please feel free to re-assign if its not related to your change
,
Jun 8 2016
Can confirm it's my lcd_text CL that causes the bug, am looking at it.
,
Jun 9 2016
The problem is resulted by the theme's transparent toolbar_color and subpixel rendering of the url text. Working on a fix that forces NO_SUBPIXEL_RENDERING when painting text for StatusBubble with a transparent toolbar_color.
,
Jun 15 2016
Just to update, still able to reproduce the issue on windows 7 using chrome version 53.0.2768.0.
,
Jun 20 2016
sunxd@ gentle ping..
,
Jun 20 2016
Waiting for code review. Was out for BlinkOn last week, trying to contact with the reviewers.
,
Jun 21 2016
OK, so as a result of discussion with pkasting@ in the code review, we are going to disable the alpha value of the background color of status bubble. So the toolbar_color will be opaque.
,
Jun 22 2016
An update: we are going to make the toolbar color completely opaque in browser theme.
,
Jul 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32c538f0e6cd40ebd53f336f1f3fae7eb404070b commit 32c538f0e6cd40ebd53f336f1f3fae7eb404070b Author: sunxd <sunxd@chromium.org> Date: Sat Jul 02 02:24:54 2016 Make toolbar color opaque in browser theme In the bug, the ui assumes using lcd_text by default, but the theme has transparent toolbar_color, rendering subpixel makes the text seem weird. This CL forces the color to be opaque (alpha value = 0xff). It worked before because the can_use_lcd_text property of status bubble is set before we compute layer draw properties, and the property is disabled all the time. But now we compute layer draw properties on demand, the can_use_lcd_text property becomes true as the whole layer tree is set to be able to use lcd text. BUG= 618278 Review-Url: https://codereview.chromium.org/2044223006 Cr-Commit-Position: refs/heads/master@{#403593} [modify] https://crrev.com/32c538f0e6cd40ebd53f336f1f3fae7eb404070b/chrome/browser/themes/browser_theme_pack.cc [modify] https://crrev.com/32c538f0e6cd40ebd53f336f1f3fae7eb404070b/chrome/browser/themes/browser_theme_pack_unittest.cc
,
Jul 4 2016
,
Jul 4 2016
Sure, request to merge to M-53.
,
Jul 4 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ee6dcc8331fe45ae305c79bda5320a96a92f204 commit 4ee6dcc8331fe45ae305c79bda5320a96a92f204 Author: sunxd <sunxd@chromium.org> Date: Mon Jul 04 14:54:11 2016 Make toolbar color opaque in browser theme In the bug, the ui assumes using lcd_text by default, but the theme has transparent toolbar_color, rendering subpixel makes the text seem weird. This CL forces the color to be opaque (alpha value = 0xff). It worked before because the can_use_lcd_text property of status bubble is set before we compute layer draw properties, and the property is disabled all the time. But now we compute layer draw properties on demand, the can_use_lcd_text property becomes true as the whole layer tree is set to be able to use lcd text. BUG= 618278 Review-Url: https://codereview.chromium.org/2044223006 Cr-Commit-Position: refs/heads/master@{#403593} (cherry picked from commit 32c538f0e6cd40ebd53f336f1f3fae7eb404070b) Review URL: https://codereview.chromium.org/2120303002 . Cr-Commit-Position: refs/branch-heads/2785@{#13} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/4ee6dcc8331fe45ae305c79bda5320a96a92f204/chrome/browser/themes/browser_theme_pack.cc [modify] https://crrev.com/4ee6dcc8331fe45ae305c79bda5320a96a92f204/chrome/browser/themes/browser_theme_pack_unittest.cc
,
Jul 4 2016
,
Jul 7 2016
Adding TE-Verified labels as per # 15 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kavvaru@chromium.org
, Jun 8 2016Labels: ReleaseBlock-Stable