Toolbar does not vanish after selecting 'More from this site' option in chrome://history.
Reported by
yfulgaon...@etouch.net,
Jun 8 2016
|
|||
Issue descriptionChrome version : 53.0.2762.0 (Official Build) 42947e24de37b28e80c8456fdf36460c5296db63-refs/heads/master@{#398431} 32/64 bit OS : Windows (7,8,8.1,10), Linux(14.04 LTS), Mac(10.10.5, 10.11.4) Pre-condition:Enable 'Material Design history' from chrome://flags What steps will reproduce the problem? 1. Launch Chrome and go to chrome://history. 2. Select the first record using checkbox and click on 'More menu' icon (three dots). 3. Select 'More from this site' option and observe the toolbar. Actual : Toolbar does not vanish after selecting 'More from this site' option in chrome://history. Expected : Toolbar should vanish after selecting 'More from this site' option in chrome://history. This is a non-regression issue, seen from M-51 (Build 51.0.2695.0 ) Note : After step 3, unnecessarily selection count is seen on toolbar even when no records are selected.
,
Jun 8 2016
Correction : Chrome version : 52.0.2743.33 (Official Build) 381c5e933974600cf004f795100242670cb0764b-refs/branch-heads/2743@{#271} 32/64 bit
,
Jun 9 2016
,
Jun 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18b60480e246ba70731c85f1ad4d55b1cd71911e commit 18b60480e246ba70731c85f1ad4d55b1cd71911e Author: tsergeant <tsergeant@chromium.org> Date: Fri Jun 10 07:38:10 2016 MD History: Deselect items when clicking 'More from this site' Previously, it was possible to select an item and perform a domain search. This would still show '1 selected' in the toolbar, even though none of the new search results were selected. BUG= 618244 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2053553002 Cr-Commit-Position: refs/heads/master@{#399133} [modify] https://crrev.com/18b60480e246ba70731c85f1ad4d55b1cd71911e/chrome/browser/resources/md_history/history_list.js [modify] https://crrev.com/18b60480e246ba70731c85f1ad4d55b1cd71911e/chrome/test/data/webui/md_history/history_list_test.js [modify] https://crrev.com/18b60480e246ba70731c85f1ad4d55b1cd71911e/chrome/test/data/webui/md_history/history_toolbar_test.js
,
Jun 14 2016
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18b60480e246ba70731c85f1ad4d55b1cd71911e commit 18b60480e246ba70731c85f1ad4d55b1cd71911e Author: tsergeant <tsergeant@chromium.org> Date: Fri Jun 10 07:38:10 2016 MD History: Deselect items when clicking 'More from this site' Previously, it was possible to select an item and perform a domain search. This would still show '1 selected' in the toolbar, even though none of the new search results were selected. BUG= 618244 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2053553002 Cr-Commit-Position: refs/heads/master@{#399133} [modify] https://crrev.com/18b60480e246ba70731c85f1ad4d55b1cd71911e/chrome/browser/resources/md_history/history_list.js [modify] https://crrev.com/18b60480e246ba70731c85f1ad4d55b1cd71911e/chrome/test/data/webui/md_history/history_list_test.js [modify] https://crrev.com/18b60480e246ba70731c85f1ad4d55b1cd71911e/chrome/test/data/webui/md_history/history_toolbar_test.js |
|||
►
Sign in to add a comment |
|||
Comment 1 by tkonch...@chromium.org
, Jun 8 2016