Issue metadata
Sign in to add a comment
|
after formatting jshint complains with Bad line breaking before ','.
Reported by
chrissow...@gmail.com,
Jun 8 2016
|
||||||||||||||||||||
Issue description
UserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.102 Safari/537.36
Steps to reproduce the problem:
1. open a js file in the sources tab and define many vars on one line. e.g like this:
var window_height = window.innerHeight,
footer_elem = $("footer[data-role='contentinfo']"),
margin_push = 0;
2. use the format bottom that looks like this: {}
3. This will format the js into something that looks like this:
var window_height = window.innerHeight
,
footer_elem = $("footer[data-role='contentinfo']")
,
margin_push = 0;
This will cause jshint to warn with:
Comma warnings can be turned off with 'laxcomma'.
Bad line breaking before ','.
This just makes it hart to keep your code nice while your using workspaces as your IDE.
What is the expected behavior?
it should not put the comma on another line and should not indent it.
What went wrong?
I guess the start of the comma is seen as a new line making it go onto a new line.
Did this work before? N/A
Chrome version: 50.0.2661.102 Channel: stable
OS Version: 10.0
Flash Version: Shockwave Flash 21.0 r0
i like cheese.
,
Jun 8 2016
also it messes with function semicolons:
this:
var click_actions = function() {
// stuff
};
to this:
var click_actions = function() {
// stuff
}
;
,
Jun 8 2016
Putting the samples into a snippet and prettifying it reveals the issue. Confirmed in version 53.0.2756.0. As this is a regression marking it as a P1 issue.
Example input:
var window_height = window.innerHeight,
footer_elem = $("footer[data-role='contentinfo']"),
margin_push = 0;
var click_actions = function() {
// stuff
};
Example output:
var window_height = window.innerHeight
, footer_elem = $("footer[data-role='contentinfo']")
, margin_push = 0;
var click_actions = function() {// stuff
}
;
,
Jul 1 2016
#1: this is fixed in Chrome 51. #2: indeed, the semicolon is handled a little bit weird #3: the behavior is expected, this is not a regression.
,
Jul 1 2016
,
Jul 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8cb8ae83c17c3d841794df0e9a23a996066c2106 commit 8cb8ae83c17c3d841794df0e9a23a996066c2106 Author: lushnikov <lushnikov@chromium.org> Date: Tue Jul 05 18:54:05 2016 DevTools: fix javascript pretty-printing of semicolon in some cases BUG= 618235 R=dgozman Review-Url: https://codereview.chromium.org/2103323006 Cr-Commit-Position: refs/heads/master@{#403813} [add] https://crrev.com/8cb8ae83c17c3d841794df0e9a23a996066c2106/third_party/WebKit/LayoutTests/inspector/sources/pretty-print-javascript-7-expected.txt [add] https://crrev.com/8cb8ae83c17c3d841794df0e9a23a996066c2106/third_party/WebKit/LayoutTests/inspector/sources/pretty-print-javascript-7.html [modify] https://crrev.com/8cb8ae83c17c3d841794df0e9a23a996066c2106/third_party/WebKit/Source/devtools/front_end/formatter_worker/JavaScriptFormatter.js
,
Jul 6 2016
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by chrissow...@gmail.com
, Jun 8 2016Just noticed that every time i hit the format button {} it will add another line e.g: var window_height = window.innerHeight , footer_elem = $("footer[data-role='contentinfo']") , margin_push = 0; If i use the format button again: var window_height = window.innerHeight , footer_elem = $("footer[data-role='contentinfo']") , margin_push = 0; and it keeps adding more lines for each time i use the format button.