Issue metadata
Sign in to add a comment
|
Regression: Button text is misaligned when Font size is Very large. |
||||||||||||||||||||||
Issue descriptionVersion: 53.0.2760.0/8426.0.0 (Official Build) dev-channel peach_pit,gnawty,wolf OS: Chrome OS What steps will reproduce the problem? (1) Change Font size to very large in chrome://settings >> Open files app/gallery and try deleting any folder/image >> Observe Delete and cancel buttons Expected: Even on changing font size button font should be center aligned. Actual: Instead button text is misaligned after changing font size. This is a regression issue as it is working fine in 44.0.2403.125/7077.111.0 (Official Build) stable-channel daisy. Issue is also seen in M50 stable. @fukino: Please confirm the behavior.
,
Jun 8 2016
Comfirmed. Thanks!
,
Jul 6 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 13 2016
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0bf9254e08db3e93c5a619da6d93743f147366ee commit 0bf9254e08db3e93c5a619da6d93743f147366ee Author: yamaguchi <yamaguchi@chromium.org> Date: Wed Jul 13 08:03:00 2016 Allow resizing dialog button to prevent a label get out of it. BUG= 618232 TEST=manuall confirmed that the view renders as intended Review-Url: https://codereview.chromium.org/2143873002 Cr-Commit-Position: refs/heads/master@{#405074} [modify] https://crrev.com/0bf9254e08db3e93c5a619da6d93743f147366ee/ui/file_manager/file_manager/foreground/css/common.css
,
Jul 13 2016
What had happened was that the button text size was changed but the size of the button was fixed (32px). The change above allows resizing the button box when the font is too large, so as to have enough size to align the text to its center. The setting menu item affecting this issue is entitled "[Web content] - [Font size]". So I am not sure if we should resize the dialog box text and all the labels inside the Files.app view (like filename string beside file icons). In other words, should the dialog box buttons be considered "web contents"?
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0bf9254e08db3e93c5a619da6d93743f147366ee commit 0bf9254e08db3e93c5a619da6d93743f147366ee Author: yamaguchi <yamaguchi@chromium.org> Date: Wed Jul 13 08:03:00 2016 Allow resizing dialog button to prevent a label get out of it. BUG= 618232 TEST=manuall confirmed that the view renders as intended Review-Url: https://codereview.chromium.org/2143873002 Cr-Commit-Position: refs/heads/master@{#405074} [modify] https://crrev.com/0bf9254e08db3e93c5a619da6d93743f147366ee/ui/file_manager/file_manager/foreground/css/common.css
,
Aug 12 2016
Chrome OS version 54.0.2824.0/8696.0 samus |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kavvaru@chromium.org
, Jun 8 2016