Issue metadata
Sign in to add a comment
|
72.7%-479.2% regression in webrtc_perf_tests at 13037:13037 |
||||||||||||||||||||
Issue descriptionThis comes with https://chromium.googlesource.com/external/webrtc/+/46b89b9a3f3f92acea250ab9e34a479040101145, which changes how a number of tests report their results.
,
Jun 8 2016
Danil, please, take a look and consider whether these deviations are expected from your change or not (https://chromium.googlesource.com/external/webrtc/+/46b89b9a3f3f92acea250ab9e34a479040101145).
,
Jun 8 2016
The deviations are caused by my change. I had wrong assumption about old behavior: (before cl) when some stat is reported 100 times, the _last_ value is shown on the graph. (after cl) When same stat is reported as a list if 100 values, the _average_ value is shown on the graph. I'll now investigate which behavior is intended for each of mentioned stats.
,
Jun 8 2016
If we're tracking the average I think we should compute the average based on samples after the synchronizer has converged, and not include the initial samples.
,
Jun 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/371b43b86a6a1bf0fb8a9059309a67a6e16a9542 commit 371b43b86a6a1bf0fb8a9059309a67a6e16a9542 Author: Danil Chapovalov <danilchap@webrtc.org> Date: Thu Jun 16 07:58:44 2016 Changes synchronization offset perfomance tracking to be logged after converge only. BUG= webrtc:5032 , chromium:618226 R=pbos@webrtc.org Review URL: https://codereview.webrtc.org/2046943004 . Cr-Commit-Position: refs/heads/master@{#13160} [modify] https://crrev.com/371b43b86a6a1bf0fb8a9059309a67a6e16a9542/webrtc/call/call_perf_tests.cc
,
Jun 16 2016
synchronization and bitrate_kbps metrics are now back to pre-aggregate values. RampUp metrics (UpDownUpThreeStreamsRtx and second_rampup) are not related to this bug. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by hlundin@chromium.org
, Jun 8 2016