Fake audio doesn't loop
Reported by
tsa...@testrtc.com,
Jun 8 2016
|
|||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.79 Safari/537.36 Example URL: Any WebRTC service (try appr.tc) Steps to reproduce the problem: 1. Run Chrome from CLI with --use-fake-ui-for-media-stream --use-file-for-fake-audio-capture --use-fake-device-for-media-stream (make sure to give a .wav file for the audio capture) 2. Go to appr.tc and open a session 3. Join the appr.tc session from another browser 4. Wait until the fake audio runs out - it won't loop What is the expected behavior? Audio should loop. If it doesn't loop, it is hard to do WebRTC tests that are longer than a couple of minutes since the files become too big and messy to handle in test automation. BTW - the fake video loops nicely in the same scenario What went wrong? Audio didn't loop Did this work before? No Is it a problem with Flash or HTML5? HTML5 Does this work in other browsers? N/A Chrome version: 51.0.2704.79 Channel: stable OS Version: Flash Version: Shockwave Flash 21.0 r0
,
Jun 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d099160b7f26caae6b96a71b057db75e4d6a1af commit 4d099160b7f26caae6b96a71b057db75e4d6a1af Author: phoglund <phoglund@chromium.org> Date: Mon Jun 13 15:47:08 2016 Make fake audio file playback loop by default. Some do long-running tests with --use-file-for-fake-audio-capture, and since the flag doesn't loop the audio file by default, you'd need a huge file to play audio during a long-running test. Instead of specifying <path> you can now specify <path>%noloop for the flag arg, e.g. --use-file-for-fake-audio-capture=/my/audio.wav%noloop to get the old behavior. To get the new behavior, just pass a wav file path to the flag. The current WebRTC audio quality tests currently need the file to stop after the first playout. Another option could be to pad the audio file with lots of silence at the end. BUG= 618215 Review-Url: https://codereview.chromium.org/2043353002 Cr-Commit-Position: refs/heads/master@{#399458} [modify] https://crrev.com/4d099160b7f26caae6b96a71b057db75e4d6a1af/chrome/browser/media/webrtc_audio_quality_browsertest.cc [modify] https://crrev.com/4d099160b7f26caae6b96a71b057db75e4d6a1af/media/audio/fake_audio_input_stream.cc [modify] https://crrev.com/4d099160b7f26caae6b96a71b057db75e4d6a1af/media/audio/simple_sources.cc [modify] https://crrev.com/4d099160b7f26caae6b96a71b057db75e4d6a1af/media/audio/simple_sources.h [modify] https://crrev.com/4d099160b7f26caae6b96a71b057db75e4d6a1af/media/audio/simple_sources_unittest.cc [modify] https://crrev.com/4d099160b7f26caae6b96a71b057db75e4d6a1af/media/base/media_switches.cc
,
Jun 14 2016
There we go. Tsahi, this should roll into today's or tomorrow's canary. Please try it out, audio should now be looping by default.
,
Jun 14 2016
Thanks for the quick turn around on this one!
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d099160b7f26caae6b96a71b057db75e4d6a1af commit 4d099160b7f26caae6b96a71b057db75e4d6a1af Author: phoglund <phoglund@chromium.org> Date: Mon Jun 13 15:47:08 2016 Make fake audio file playback loop by default. Some do long-running tests with --use-file-for-fake-audio-capture, and since the flag doesn't loop the audio file by default, you'd need a huge file to play audio during a long-running test. Instead of specifying <path> you can now specify <path>%noloop for the flag arg, e.g. --use-file-for-fake-audio-capture=/my/audio.wav%noloop to get the old behavior. To get the new behavior, just pass a wav file path to the flag. The current WebRTC audio quality tests currently need the file to stop after the first playout. Another option could be to pad the audio file with lots of silence at the end. BUG= 618215 Review-Url: https://codereview.chromium.org/2043353002 Cr-Commit-Position: refs/heads/master@{#399458} [modify] https://crrev.com/4d099160b7f26caae6b96a71b057db75e4d6a1af/chrome/browser/media/webrtc_audio_quality_browsertest.cc [modify] https://crrev.com/4d099160b7f26caae6b96a71b057db75e4d6a1af/media/audio/fake_audio_input_stream.cc [modify] https://crrev.com/4d099160b7f26caae6b96a71b057db75e4d6a1af/media/audio/simple_sources.cc [modify] https://crrev.com/4d099160b7f26caae6b96a71b057db75e4d6a1af/media/audio/simple_sources.h [modify] https://crrev.com/4d099160b7f26caae6b96a71b057db75e4d6a1af/media/audio/simple_sources_unittest.cc [modify] https://crrev.com/4d099160b7f26caae6b96a71b057db75e4d6a1af/media/base/media_switches.cc
,
Jul 21 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by phoglund@chromium.org
, Jun 8 2016Status: Assigned (was: Unconfirmed)