New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 618210 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Dec 17
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-12-13
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

Implement attribution of script running to v8::Context

Project Member Reported by xiaoche...@chromium.org, Jun 8 2016

Issue description

We need a new subclass of BlameContext for v8::context, such that script running can be attributed correctly. We also need to design the relationship between this new subclass and the existing BlameContext subclasses.
 
Currently, scripts are attributed to FrameBlameContexts in V8ScriptRunner::callFunction. This has at least two defects:

1. Microtasks are attributed incorrectly (found by yhirano@). v8::internal::Isolate::runMicrotasks runs all microtasks accumulated in the same v8::Isolate, each of which may have a different v8::Context. The task queue or call site of runMicrotasks cannot provide enough information for correct attribution of all microtasks.

2. Script run on non-main threads (e.g. ServiceWorker) cannot be attributed.

ps. Please help me add some components and labels because I don't know what should be applied here...

Comment 2 by l...@chromium.org, Jun 15 2016

Cc: l...@chromium.org
Components: Blink>JavaScript
Cc: xiaoche...@chromium.org
Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 5 by sheriffbot@chromium.org, Dec 11 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Type-Bug Type-Feature
NextAction: 2017-12-13
Status: Available (was: Untriaged)
Is this valid? if not, please close this issue.
Components: -Blink>JavaScript Blink>JavaScript>API
The NextAction date has arrived: 2017-12-13
Project Member

Comment 9 by sheriffbot@chromium.org, Dec 12

Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: WontFix (was: Untriaged)

Sign in to add a comment