New issue
Advanced search Search tips

Issue 618205 link

Starred by 1 user
Status: Fixed
Owner:
sebmarchand@chromium.org
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ScopedHandleTest.* fail, reverted CL

Project Member Reported by battre@chromium.org, Jun 8 2016 
https://codereview.chromium.org/1977833003 is suspected to cause a failure.

https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(dbg)(1)/builds/49451/steps/base_unittests%20on%20Windows-7-SP1

Will revert to see whether that fixes the problem.

ScopedHandleTest.ActiveVerifierDoubleTracking (run #1):
[ RUN      ] ScopedHandleTest.ActiveVerifierDoubleTracking
c:uild\slave\win_builder__dbg_uild\srcase\win\scoped_handle_unittest.cc(74): error: Death test: { base::win::ScopedHandle handle_holder2(handle); }
    Result: failed to die.
 Error msg:
[  DEATH   ] [5396:3224:0607/231233:18621043:WARNING:test_suite.cc(195)] Test launcher output path C:\Users\CHROME~2\AppData\Local\TempK2_29056	est_results.xml exists. Not adding test launcher result printer.
[  DEATH   ]
[  FAILED  ] ScopedHandleTest.ActiveVerifierDoubleTracking (140 ms)

ScopedHandleTest.ActiveVerifierDoubleTracking (run #2):
[ RUN      ] ScopedHandleTest.ActiveVerifierDoubleTracking
c:uild\slave\win_builder__dbg_uild\srcase\win\scoped_handle_unittest.cc(74): error: Death test: { base::win::ScopedHandle handle_holder2(handle); }
    Result: failed to die.
 Error msg:
[  DEATH   ] [328:4444:0607/231241:18629030:WARNING:test_suite.cc(195)] Test launcher output path C:\Users\CHROME~2\AppData\Local\TempK2_12446	est_results.xml exists. Not adding test launcher result printer.
[  DEATH   ]
[  FAILED  ] ScopedHandleTest.ActiveVerifierDoubleTracking (141 ms)

ScopedHandleTest.ActiveVerifierDoubleTracking (run #3):
[ RUN      ] ScopedHandleTest.ActiveVerifierDoubleTracking
c:uild\slave\win_builder__dbg_uild\srcase\win\scoped_handle_unittest.cc(74): error: Death test: { base::win::ScopedHandle handle_holder2(handle); }
    Result: failed to die.
 Error msg:
[  DEATH   ] [3584:2092:0607/231242:18630606:WARNING:test_suite.cc(195)] Test launcher output path C:\Users\CHROME~2\AppData\Local\TempK2_18644	est_results.xml exists. Not adding test launcher result printer.
[  DEATH   ]
[  FAILED  ] ScopedHandleTest.ActiveVerifierDoubleTracking (187 ms)

ScopedHandleTest.ActiveVerifierDoubleTracking (run #4):
[ RUN      ] ScopedHandleTest.ActiveVerifierDoubleTracking
c:uild\slave\win_builder__dbg_uild\srcase\win\scoped_handle_unittest.cc(74): error: Death test: { base::win::ScopedHandle handle_holder2(handle); }
    Result: failed to die.
 Error msg:
[  DEATH   ] [4324:5172:0607/231244:18632135:WARNING:test_suite.cc(195)] Test launcher output path C:\Users\CHROME~2\AppData\Local\TempK2_6961	est_results.xml exists. Not adding test launcher result printer.
[  DEATH   ]
[  FAILED  ] ScopedHandleTest.ActiveVerifierDoubleTracking (140 ms)
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71f86049e34c437a0a7498b231bb19353486f81f

commit 71f86049e34c437a0a7498b231bb19353486f81f
Author: battre <battre@chromium.org>
Date: Wed Jun 08 06:54:38 2016

Revert of Add a buildflag to use the handle verifier in a per module mode. (patchset #9 id:180001 of https://codereview.chromium.org/1977833003/ )

Reason for revert:
ScopedHandleTest.* tests fail to die on try bots.

BUG= 618205 

Original issue's description:
> Add a buildflag to use the handle verifier in a per module mode.
>
> The HandleVerifier prevent you from using any ScopedHandle during a module initialization (i.e. if a DLL use one in DllMain this will call back into its host executable that hasn't been initialized yet and things will derail). In this CL I'm adding a build flag to make it possible to use it in a single module mode..
>
> Committed: https://crrev.com/a89708a5c1bfe778ed1615f0bc92f0e9ae2e2192
> Cr-Commit-Position: refs/heads/master@{#398361}

TBR=wfh@chromium.org,chrisha@chromium.org,thakis@chromium.org,sebmarchand@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2047013003
Cr-Commit-Position: refs/heads/master@{#398496}

[modify] https://crrev.com/71f86049e34c437a0a7498b231bb19353486f81f/base/BUILD.gn
[modify] https://crrev.com/71f86049e34c437a0a7498b231bb19353486f81f/base/base.gyp
[delete] https://crrev.com/7bfed77ba6b443d9221159bb40e2c548fde86e15/base/win/BUILD.gn
[modify] https://crrev.com/71f86049e34c437a0a7498b231bb19353486f81f/base/win/scoped_handle.cc
[modify] https://crrev.com/71f86049e34c437a0a7498b231bb19353486f81f/base/win/scoped_handle_test_dll.cc
[modify] https://crrev.com/71f86049e34c437a0a7498b231bb19353486f81f/build/common.gypi

Comment 2 by sebmarchand@chromium.org, Jun 8 2016 

Thanks, I can repro this locally now. I'm working on a fix and I'll reland my CL.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82ef0204161f34381ab832a576c4789e1063e0ee

commit 82ef0204161f34381ab832a576c4789e1063e0ee
Author: sebmarchand <sebmarchand@chromium.org>
Date: Wed Jun 08 15:56:32 2016

Add a buildflag to use the handle verifier in a per module mode.

The HandleVerifier prevent you from using any ScopedHandle during a module initialization (i.e. if a DLL use one in DllMain this will call back into its host executable that hasn't been initialized yet and things will derail). In this CL I'm adding a build flag to make it possible to use it in a single module mode..

Committed: https://crrev.com/a89708a5c1bfe778ed1615f0bc92f0e9ae2e2192
Cr-Commit-Position: refs/heads/master@{#398361}

BUG= 618205 

Review-Url: https://codereview.chromium.org/1977833003
Cr-Commit-Position: refs/heads/master@{#398575}

[modify] https://crrev.com/82ef0204161f34381ab832a576c4789e1063e0ee/base/BUILD.gn
[modify] https://crrev.com/82ef0204161f34381ab832a576c4789e1063e0ee/base/base.gyp
[add] https://crrev.com/82ef0204161f34381ab832a576c4789e1063e0ee/base/win/BUILD.gn
[modify] https://crrev.com/82ef0204161f34381ab832a576c4789e1063e0ee/base/win/scoped_handle.cc
[modify] https://crrev.com/82ef0204161f34381ab832a576c4789e1063e0ee/base/win/scoped_handle_test_dll.cc
[modify] https://crrev.com/82ef0204161f34381ab832a576c4789e1063e0ee/build/common.gypi

Comment 4 by sebmarchand@chromium.org, Jun 15 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment