New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 618160 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocked on:
issue 613441



Sign in to add a comment

Animometer - Composited Transforms test renders images with wrong colors

Project Member Reported by vmi...@chromium.org, Jun 8 2016

Issue description

Version: r395672
OS: All

What steps will reproduce the problem?
(1) https://trac.webkit.org/export/HEAD/trunk/PerformanceTests/Animometer/developer.html
(2) Run "Composited Transforms" in the HTML Suite.

On Safari & Firefox the composited images are multi-colored.  On Chrome they are all the same color.
 
Safari.png
1.1 MB View Download
Chrome.png
1013 KB View Download
Labels: Hotlist-Animometer
Labels: -Pri-2 Pri-3
This test is setting style "filter: hue-rotate".  It requires "-webkit-" prefix to work in Chrome.

Comment 3 by pdr@chromium.org, Jun 8 2016

Cc: f...@opera.com
Just in case you haven't seen it, Fredrik (fs@opera) is fixing this right now:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/ZVT2kxuFMaA/zPkymq0bBgAJ
Components: -Internals>Compositing>Rasterization
Owner: f...@opera.com
Status: Assigned (was: Available)

Comment 5 by f...@opera.com, Jun 8 2016

Blockedon: 613441
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a0f0e2eb0abdd68fb377d5b789682acfe10757d

commit 7a0f0e2eb0abdd68fb377d5b789682acfe10757d
Author: fs <fs@opera.com>
Date: Mon Jun 20 19:59:36 2016

Unprefix the CSS 'filter' property

Parse 'filter' in the same way as '-webkit-filter', and make the latter
an alias of the former.
For SVG content, only the "url(...)" function is allowed still, with the
exception of the outermost <svg> (LayoutSVGRoot), since that "has a box".

Update tests to use 'filter' where reasonable and applicable.

Intent to Ship: https://groups.google.com/a/chromium.org/d/topic/blink-dev/ZVT2kxuFMaA/discussion

Based on https://codereview.chromium.org/1987943002 by noel@chromium.org.

BUG= 613441 , 618160 , 550249 , 535786 , 244295 ,109224

Review-Url: https://codereview.chromium.org/2065593002
Cr-Commit-Position: refs/heads/master@{#400752}

[add] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/animations/animated-filter-svg-element-expected.html
[add] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/animations/animated-filter-svg-element.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/compositing/will-change/stacking-context-creation-expected.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/compositing/will-change/stacking-context-creation.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-all-on-background-expected.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-blur-hw.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-blur.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-brightness-clamping-hw.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-brightness-clamping.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-brightness-hw.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-brightness.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-combined-hw.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-combined.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-contrast-hw.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-contrast.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-drop-shadow-hw.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-drop-shadow.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-grayscale-hw.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-grayscale.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-hue-rotate-hw.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-hue-rotate.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-invert-hw.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-invert.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-opacity-hw.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-opacity.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-reference-composite-hw.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-reference-composite.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-reference-hw.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-reference-ordering-hw.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-reference-ordering.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-reference.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-saturate-hw.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-saturate.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-sepia-hw.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-sepia.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/fecomposite-non-zero-inoffset.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/feoffset-region-zoom-expected.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/filter-property-computed-style.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/filter-property-parsing-invalid.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/filter-property-parsing.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/filter-region-transformed-child-expected.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/filter-repaint-blur.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/filter-repaint-shadow.html
[add] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/unprefixed.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/svg/filters/filter-refresh-expected.txt
[add] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/svg/filters/svg-element-invalid-filter-expected.html
[add] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/svg/filters/svg-element-invalid-filter.html
[add] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/svg/filters/svg-filter-child-box-reflect-expected.html
[add] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/svg/filters/svg-filter-child-box-reflect.html
[add] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/svg/filters/svg-filter-root-box-reflect-expected.html
[add] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/svg/filters/svg-filter-root-box-reflect.html
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/animation/DeferredLegacyStyleInterpolationTest.cpp
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/animation/ElementAnimations.cpp
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/animation/FilterListPropertyFunctions.h
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/animation/PropertyInterpolationTypesMapping.cpp
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/css/CSSProperties.in
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/css/CSSPropertyEquality.cpp
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/frame/UseCounter.cpp
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/layout/svg/SVGLayoutTreeAsText.cpp
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/layout/svg/SVGResources.cpp
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/layout/svg/SVGResources.h
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/layout/svg/SVGResourcesCache.cpp
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/paint/SVGPaintContext.cpp
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/paint/SVGRootPainter.cpp
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/style/SVGComputedStyle.h
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/style/SVGComputedStyleDefs.cpp
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/style/SVGComputedStyleDefs.h
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp
[modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

After fs@'s change, this test looks correct in ToT. Can we mark this as fixed?

Comment 8 by vmi...@chromium.org, Jul 27 2016

Status: Verified (was: Assigned)

Sign in to add a comment