When a web animations keyframe contains valid property keys that have unparseable value strings, we should emit a warning on the console.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ddf77acbf3b11ee0a3922ca5c1df57d769bac83 commit 1ddf77acbf3b11ee0a3922ca5c1df57d769bac83 Author: alancutter <alancutter@chromium.org> Date: Fri Nov 25 13:21:52 2016 Emit console warning when element.animate() keyframe value fails to parse This change adds a return value to the CSS parser to state whether a CSS value was parsed successfully for a given property. This information is used to allow calls to element.animate() to warn the developer when provided keyframe values are invalid. BUG= 618157 Review-Url: https://codereview.chromium.org/2524303002 Cr-Commit-Position: refs/heads/master@{#434490} [add] https://crrev.com/1ddf77acbf3b11ee0a3922ca5c1df57d769bac83/third_party/WebKit/LayoutTests/animations/element-animate-keyframe-value-warning-expected.txt [add] https://crrev.com/1ddf77acbf3b11ee0a3922ca5c1df57d769bac83/third_party/WebKit/LayoutTests/animations/element-animate-keyframe-value-warning.html [modify] https://crrev.com/1ddf77acbf3b11ee0a3922ca5c1df57d769bac83/third_party/WebKit/LayoutTests/animations/option-element-crash-expected.txt [modify] https://crrev.com/1ddf77acbf3b11ee0a3922ca5c1df57d769bac83/third_party/WebKit/LayoutTests/fast/inline/inline-marquee-crash-expected.txt [modify] https://crrev.com/1ddf77acbf3b11ee0a3922ca5c1df57d769bac83/third_party/WebKit/LayoutTests/imported/wpt/web-animations/interfaces/Animatable/animate-expected.txt [modify] https://crrev.com/1ddf77acbf3b11ee0a3922ca5c1df57d769bac83/third_party/WebKit/LayoutTests/imported/wpt/web-animations/interfaces/KeyframeEffect/constructor-expected.txt [modify] https://crrev.com/1ddf77acbf3b11ee0a3922ca5c1df57d769bac83/third_party/WebKit/Source/core/animation/EffectInput.cpp [modify] https://crrev.com/1ddf77acbf3b11ee0a3922ca5c1df57d769bac83/third_party/WebKit/Source/core/animation/EffectInput.h [modify] https://crrev.com/1ddf77acbf3b11ee0a3922ca5c1df57d769bac83/third_party/WebKit/Source/core/animation/StringKeyframe.cpp [modify] https://crrev.com/1ddf77acbf3b11ee0a3922ca5c1df57d769bac83/third_party/WebKit/Source/core/animation/StringKeyframe.h [modify] https://crrev.com/1ddf77acbf3b11ee0a3922ca5c1df57d769bac83/third_party/WebKit/Source/core/css/DOMWindowCSS.cpp [modify] https://crrev.com/1ddf77acbf3b11ee0a3922ca5c1df57d769bac83/third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp [modify] https://crrev.com/1ddf77acbf3b11ee0a3922ca5c1df57d769bac83/third_party/WebKit/Source/core/css/StylePropertySet.cpp [modify] https://crrev.com/1ddf77acbf3b11ee0a3922ca5c1df57d769bac83/third_party/WebKit/Source/core/css/StylePropertySet.h [modify] https://crrev.com/1ddf77acbf3b11ee0a3922ca5c1df57d769bac83/third_party/WebKit/Source/core/css/parser/CSSParser.cpp [modify] https://crrev.com/1ddf77acbf3b11ee0a3922ca5c1df57d769bac83/third_party/WebKit/Source/core/css/parser/CSSParser.h [modify] https://crrev.com/1ddf77acbf3b11ee0a3922ca5c1df57d769bac83/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp [modify] https://crrev.com/1ddf77acbf3b11ee0a3922ca5c1df57d769bac83/third_party/WebKit/Source/core/css/parser/CSSParserImpl.h [modify] https://crrev.com/1ddf77acbf3b11ee0a3922ca5c1df57d769bac83/third_party/WebKit/Source/core/dom/Element.cpp [modify] https://crrev.com/1ddf77acbf3b11ee0a3922ca5c1df57d769bac83/third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp
Comment 1 by suzyh@chromium.org
, Jun 8 2016