New issue
Advanced search Search tips

Issue 618148 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: rectify presence of src/content/browser/devtools/browser_protocol.json

Project Member Reported by paulir...@chromium.org, Jun 7 2016

Issue description

This file seems like it should now live with the "other", "real" browser_protocol.json

https://cs.chromium.org/chromium/src/content/browser/devtools/browser_protocol.json?q=f:protocol.json&sq=package:chromium&dr


 
(In the meantime, we should at least rename this one so folks aren't confused when searching for "browser_protocol.json")
Status: Started (was: Assigned)
CL https://codereview.chromium.org/2100883002/
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23f2c5c0aa550db9e4f51024bb412bcd8d770bd8

commit 23f2c5c0aa550db9e4f51024bb412bcd8d770bd8
Author: pfeldman <pfeldman@chromium.org>
Date: Thu Jul 07 04:02:47 2016

DevTools: merge browser_protocol.json files from content and core/inspector.

BUG= 618148 
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2100883002
Cr-Commit-Position: refs/heads/master@{#404070}

[modify] https://crrev.com/23f2c5c0aa550db9e4f51024bb412bcd8d770bd8/chrome/browser/devtools/BUILD.gn
[modify] https://crrev.com/23f2c5c0aa550db9e4f51024bb412bcd8d770bd8/chrome/browser/devtools/devtools_protocol_constants.gyp
[modify] https://crrev.com/23f2c5c0aa550db9e4f51024bb412bcd8d770bd8/chrome/browser/devtools/devtools_protocol_constants_generator.py
[modify] https://crrev.com/23f2c5c0aa550db9e4f51024bb412bcd8d770bd8/content/browser/devtools/BUILD.gn
[delete] https://crrev.com/a28a718e3bb30195a185279d09e9765538fac5e2/content/browser/devtools/browser_protocol.json
[modify] https://crrev.com/23f2c5c0aa550db9e4f51024bb412bcd8d770bd8/content/browser/devtools/devtools.gyp
[modify] https://crrev.com/23f2c5c0aa550db9e4f51024bb412bcd8d770bd8/content/browser/devtools/protocol/devtools_protocol_handler_generator.py
[modify] https://crrev.com/23f2c5c0aa550db9e4f51024bb412bcd8d770bd8/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/23f2c5c0aa550db9e4f51024bb412bcd8d770bd8/third_party/WebKit/Source/devtools/PRESUBMIT.py
[modify] https://crrev.com/23f2c5c0aa550db9e4f51024bb412bcd8d770bd8/third_party/WebKit/Source/devtools/protocol.json

Status: Fixed (was: Started)

Sign in to add a comment