New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 618143 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Move the routing-info inside the jingle element.

Project Member Reported by kelv...@chromium.org, Jun 7 2016

Issue description

Previously, routing info are encoded in the iq node.  When the host is
offline, the talk network responds with an error IQ that doesn't get
relayed to the client because it doesn't have the routing info that the
signaling service needs.

Since an error IQ always contain the original request, by moving the
routing info inside the original jingle request, we can reliably route
the error message back to the client.
 
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src/+/046534d38813b82d7f3bcb61b7f8c2fdc7f9cc74

commit 046534d38813b82d7f3bcb61b7f8c2fdc7f9cc74
Author:	kelvinp <kelvinp@chromium.org>
Date: Tue Jun 07 21:37:50 2016

Move the routing-info inside the jingle element.

Previously, routing info are encoded in the iq node.  When the host is
offline, the talk network responds with an error IQ that doesn't get
relayed to the client because it doesn't have the routing info that the
signaling service needs.

Since an error IQ always contain the original request, by moving the
routing info inside the original jingle request, we can reliably route
the error message back to the client.

Review-Url: https://codereview.chromium.org/2042513002
BUG= 618143 
Cr-Commit-Position: refs/heads/master@{#398383}

[modify] http://crrev.com/046534d38813b82d7f3bcb61b7f8c2fdc7f9cc74/remoting/protocol/jingle_messages.cc
[modify] http://crrev.com/046534d38813b82d7f3bcb61b7f8c2fdc7f9cc74/remoting/protocol/jingle_messages_unittest.cc
Labels: Merge-Request-52
Request Merge to M52 as the fix of this bug is required for our new client release. This only affects the chromoting host and does not affect the Chrome binary.  

Comment 3 by tin...@google.com, Jun 8 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Can you please merge this to M52 branch asap so that it gets picked for the next Beta release scheduled for next week ?
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 11 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbc9d492a9b1369b4db5715612c7c9170ac20fbe

commit cbc9d492a9b1369b4db5715612c7c9170ac20fbe
Author: kelvinp@chromium.org <kelvinp@chromium.org>
Date: Sat Jun 11 00:16:32 2016

Move the routing-info inside the jingle element.

Previously, routing info are encoded in the iq node.  When the host is
offline, the talk network responds with an error IQ that doesn't get
relayed to the client because it doesn't have the routing info that the
signaling service needs.

Since an error IQ always contain the original request, by moving the
routing info inside the original jingle request, we can reliably route
the error message back to the client.

Review-Url: https://codereview.chromium.org/2042513002
Cr-Commit-Position: refs/heads/master@{#398383}
(cherry picked from commit 046534d38813b82d7f3bcb61b7f8c2fdc7f9cc74)

BUG= 618143 

Review URL: https://codereview.chromium.org/2061503002 .

Cr-Commit-Position: refs/branch-heads/2743@{#326}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/cbc9d492a9b1369b4db5715612c7c9170ac20fbe/remoting/protocol/jingle_messages.cc
[modify] https://crrev.com/cbc9d492a9b1369b4db5715612c7c9170ac20fbe/remoting/protocol/jingle_messages_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbc9d492a9b1369b4db5715612c7c9170ac20fbe

commit cbc9d492a9b1369b4db5715612c7c9170ac20fbe
Author: kelvinp@chromium.org <kelvinp@chromium.org>
Date: Sat Jun 11 00:16:32 2016

Move the routing-info inside the jingle element.

Previously, routing info are encoded in the iq node.  When the host is
offline, the talk network responds with an error IQ that doesn't get
relayed to the client because it doesn't have the routing info that the
signaling service needs.

Since an error IQ always contain the original request, by moving the
routing info inside the original jingle request, we can reliably route
the error message back to the client.

Review-Url: https://codereview.chromium.org/2042513002
Cr-Commit-Position: refs/heads/master@{#398383}
(cherry picked from commit 046534d38813b82d7f3bcb61b7f8c2fdc7f9cc74)

BUG= 618143 

Review URL: https://codereview.chromium.org/2061503002 .

Cr-Commit-Position: refs/branch-heads/2743@{#326}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/cbc9d492a9b1369b4db5715612c7c9170ac20fbe/remoting/protocol/jingle_messages.cc
[modify] https://crrev.com/cbc9d492a9b1369b4db5715612c7c9170ac20fbe/remoting/protocol/jingle_messages_unittest.cc

Labels: Needs-Feedback
kelvinp@, can you please let us know if this can be tested manually so that we can verify it at our end ?
Labels: -Needs-Feedback
Status: Verified (was: Fixed)
This was a change for CRD (chrome remote desktop) host, not chrome. We'll test it as part of the CRD release process, which is separate from chrome's

Sign in to add a comment