Looks like this was just missing BFS?

Yep. For the case of views-mus, it also looks like we are also setting up the ContextFactory etc. incorrectly for aura/compositor.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19bc819e7192b19cd060a1f36c6d76ae0c9c9bf1

commit 19bc819e7192b19cd060a1f36c6d76ae0c9c9bf1
Author: sadrul <sadrul@chromium.org>
Date: Fri Mar 17 19:57:51 2017

views/mus: Install a mus-friendly ContextFactory for tests.

A test running with aura-mus (in aura, views, or ash) does not need a
ui::ContextFactoryPrivate instance. It only needs a ui::ContextFactory.
ui::InProcessContextFactory is not the right implementation to use in a
mus client though, since it directly deals with cc::SurfaceManager,
cc::Display etc., which are not suitable for a mus client. So provide a
simpler implementation of ContextFactory instead in compositor which can
be used from aura, views, and ash.

Use this new ContextFactory for views_mus_unittests and mash_unittests.
This fixes using ui::DrawWaiterForTest in these tests.

BUG= 618136 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2752303002
Cr-Commit-Position: refs/heads/master@{#457865}

[modify] https://crrev.com/19bc819e7192b19cd060a1f36c6d76ae0c9c9bf1/ash/laser/laser_pointer_controller_unittest.cc
[modify] https://crrev.com/19bc819e7192b19cd060a1f36c6d76ae0c9c9bf1/ash/mus/BUILD.gn
[modify] https://crrev.com/19bc819e7192b19cd060a1f36c6d76ae0c9c9bf1/ash/mus/non_client_frame_controller_unittest.cc
[modify] https://crrev.com/19bc819e7192b19cd060a1f36c6d76ae0c9c9bf1/cc/test/fake_compositor_frame_sink.cc
[modify] https://crrev.com/19bc819e7192b19cd060a1f36c6d76ae0c9c9bf1/cc/test/fake_compositor_frame_sink.h
[modify] https://crrev.com/19bc819e7192b19cd060a1f36c6d76ae0c9c9bf1/mash/test/mash_test_suite.cc
[modify] https://crrev.com/19bc819e7192b19cd060a1f36c6d76ae0c9c9bf1/mash/test/mash_test_suite.h
[modify] https://crrev.com/19bc819e7192b19cd060a1f36c6d76ae0c9c9bf1/ui/aura/window_tree_host.cc
[modify] https://crrev.com/19bc819e7192b19cd060a1f36c6d76ae0c9c9bf1/ui/compositor/BUILD.gn
[modify] https://crrev.com/19bc819e7192b19cd060a1f36c6d76ae0c9c9bf1/ui/compositor/compositor_unittest.cc
[add] https://crrev.com/19bc819e7192b19cd060a1f36c6d76ae0c9c9bf1/ui/compositor/test/fake_context_factory.cc
[add] https://crrev.com/19bc819e7192b19cd060a1f36c6d76ae0c9c9bf1/ui/compositor/test/fake_context_factory.h
[modify] https://crrev.com/19bc819e7192b19cd060a1f36c6d76ae0c9c9bf1/ui/views/mus/BUILD.gn
[modify] https://crrev.com/19bc819e7192b19cd060a1f36c6d76ae0c9c9bf1/ui/views/mus/views_mus_test_suite.cc
[modify] https://crrev.com/19bc819e7192b19cd060a1f36c6d76ae0c9c9bf1/ui/views/test/platform_test_helper.cc
[modify] https://crrev.com/19bc819e7192b19cd060a1f36c6d76ae0c9c9bf1/ui/views/test/platform_test_helper.h
[modify] https://crrev.com/19bc819e7192b19cd060a1f36c6d76ae0c9c9bf1/ui/views/test/scoped_views_test_helper.cc
[modify] https://crrev.com/19bc819e7192b19cd060a1f36c6d76ae0c9c9bf1/ui/views/view_unittest.cc