New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 618130 link

Starred by 4 users
Status: Fixed
Owner:
aga...@chromium.org
Closed: Nov 2016
Cc:
tandrii@chromium.org
seanmccullough@chromium.org
█ andyb...@chromium.org
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Document pitfalls of linked accounts and benefits of unlinking

Project Member Reported by martiniss@chromium.org, Jun 7 2016 
For the CL https://chromium-review.googlesource.com/c/350116/, the Presubmit is failing because it's saying I don't have an LGTM from a valid owner of the files. One of my reviewers (seanmccollough), is listed as an OWNER in the root OWNERS file. 

This hasn't happened before on rietveld CQ, so it might be a problem with gerrit CQ?

Comment 1 by seanmccullough@google.com, Jun 7 2016 

Do OWNERs have to be @google.com or @chromium.org? I can't seem to lgtm it as seanmccullough@google.com from gerrit (can't switch accounts), just @chromium.org.

Comment 2 by tandrii@chromium.org, Jun 8 2016

Labels: Rietveld2Gerrit-dogfood

Comment 3 by tandrii@chromium.org, Jun 8 2016 

The latest CQ run on that CL actually was totally green. Are you sure teh LGTM wasn't due to no-rebase which resulted in git diff showing lots of changed files, for which indeed there was no owner?

Comment 4 by tandrii@chromium.org, Jun 8 2016 

OK, turns out the real problem was that uploader account was google.com, but OWNER has chromium.org. see issue which is related: 583769, and into which this bug might be de-duped. 

I am unsure that the reviewers are however correctly processed by gerrit presubmit, so i'll keep this open for now.

Comment 5 by tandrii@chromium.org, Jun 29 2016

Labels: -Rietveld2Gerrit-dogfood Proj-Gerrit-Migration

Comment 6 by benhenry@chromium.org, Aug 3 2016

Status: Untriaged (was: Unconfirmed)

Comment 7 by andyb...@chromium.org, Aug 11 2016

Status: Available (was: Untriaged)

Comment 8 by andyb...@chromium.org, Sep 27 2016

Labels: Milestone-Fishfood
Summary: Document pitfalls of linked accounts and benefits of unlinking (was: Infra OWNERS presubmit check broken)

Comment 9 by aga...@chromium.org, Nov 29 2016

Owner: aga...@chromium.org
Status: Fixed (was: Available)
Carefully documented in the fishfood/dogfood/launch doc that I'm sending to all teams in their PSAs: https://docs.google.com/document/d/1gAkgIH3ZKQgQoo0mDgcTkcYgQF7eZYg8bTSmEBT_j60/edit#heading=h.wjvy6v7vxcl5
►

Sign in to add a comment